[PATCH 1/3] Clean up scanning functions and printouts

[Eugene Krasnikov]

I guess we also need to remove is_scanning from wcn36xx.h file?

2013/6/4 Olof Johansson <dev at skyshaper.net>:
> The is_scanning state is no longer needed and was an unfortunate
> leftover from earlier.
>
> The scanning works well enough to not have it using info prints any
> more.
>
> Signed-off-by: Olof Johansson <dev at skyshaper.net>
> ---
>  main.c | 6 ++----
>  smd.c  | 2 +-
>  2 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/main.c b/main.c
> index 70ad27b..bcdc7c3 100644
> --- a/main.c
> +++ b/main.c
> @@ -153,7 +153,7 @@ static int wcn36xx_config(struct ieee80211_hw *hw,
> u32 changed)
>         if (changed & IEEE80211_CONF_CHANGE_CHANNEL) {
>                 wcn->ch = hw->conf.chandef.chan->hw_value;
>                 wcn->current_channel = hw->conf.chandef.chan;
> -               wcn36xx_info("wcn36xx_config channel switch=%d", wcn->ch);
> +               wcn36xx_dbg(WCN36XX_DBG_MAC, "wcn36xx_config channel switch=%d", wcn->ch);
>                 wcn36xx_smd_switch_channel_req(wcn, wcn->ch);
>         }
>
> @@ -270,20 +270,18 @@ out:
>
>  static void wcn36xx_sw_scan_start(struct ieee80211_hw *hw)
>  {
> -
>         struct wcn36xx *wcn = hw->priv;
>
>         wcn36xx_smd_init_scan(wcn);
>         wcn36xx_smd_start_scan(wcn, wcn->ch);
> -       wcn->is_scanning = 1;
>  }
>
>  static void wcn36xx_sw_scan_complete(struct ieee80211_hw *hw)
>  {
>         struct wcn36xx *wcn = hw->priv;
> +
>         wcn36xx_smd_end_scan(wcn, wcn->ch);
>         wcn36xx_smd_finish_scan(wcn);
> -       wcn->is_scanning = 0;
>  }
>
>  static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw,
> diff --git a/smd.c b/smd.c
> index d46f5b2..8d5f88d 100644
> --- a/smd.c
> +++ b/smd.c
> @@ -273,7 +273,7 @@ static void wcn36xx_smd_switch_channel_rsp(void
> *buf, size_t len)
>  {
>         struct wcn36xx_hal_switch_channel_rsp_msg *rsp;
>         rsp = (struct wcn36xx_hal_switch_channel_rsp_msg *)buf;
> -       wcn36xx_info("channel switched to: %d, status: %d", rsp->channel_number,
> +       wcn36xx_dbg(WCN36XX_DBG_HAL, "channel switched to: %d, status: %d",
> rsp->channel_number,
>                      rsp->status);
>  }
>
> --
> 1.8.2.2
>
> _______________________________________________
> wcn36xx mailing list
> wcn36xx at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/wcn36xx



-- 
Best regards,
Eugene