[PATCH] Add IEEE80211_TX_CTL_REQ_TX_STATUS support
Kalle Valo
kvalo at qca.qualcomm.com
Wed Jun 5 03:00:14 EDT 2013
Pontus Fuchs <pontus.fuchs at gmail.com> writes:
> On 2013-06-05 08:17, Kalle Valo wrote:
>>> + wcn36xx_fill_tx_bd(wcn, ctl->bd_cpu_addr, broadcast, 0, tx_ack);
>>> + } else
>>> + wcn36xx_fill_tx_bd(wcn, ctl->bd_cpu_addr, broadcast, 1, tx_ack);
>>
>> Forgot to mention that I think that the coding style requires braces
>> also for the else branch here.
>
> I first had braces but checkpatch complained.
Heh, should have guessed that. Sometimes (lately more than before) I
just hate checkpatch, it comes up with it's own rules and is just too
difficult. From CodingStyle:
"This does not apply if only one branch of a conditional statement is a single
statement; in the latter case use braces in both branches:
if (condition) {
do_this();
do_that();
} else {
otherwise();
}"
And in my opinion CodingStyle rule is better here. But I guess it's
easier for us to follow checkpatch's rule here so let's do that.
--
Kalle Valo
More information about the wcn36xx
mailing list