[PATCH 1/1] Enable different bd_rates for different packet types

Kalle Valo kvalo at qca.qualcomm.com
Wed Jun 5 02:21:11 EDT 2013


Olof Johansson <dev at skyshaper.net> writes:

> This commit enable Auto TX Rate adaption for standard ofdm/dsss rates.
>
> Signed-off-by: Olof Johansson <dev at skyshaper.net>

Thanks, looks good to me. Few cosmetic comments:

> @@ -483,6 +484,7 @@ int wcn36xx_dxe_tx(struct wcn36xx *wcn,
>  	struct wcn36xx_dxe_ctl *ctl = NULL;
>  	struct wcn36xx_dxe_desc *desc = NULL;
>  	struct wcn36xx_dxe_ch *ch = NULL;
> +	struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data;

We use two styles now:

(struct foo *)bar
(struct foo *) bar

Which one do we want to use? I vote for the latter, but I don't really
care as long as we use it consistently.

> --- a/txrx.h
> +++ b/txrx.h
> @@ -27,6 +27,11 @@
>  /* broadcast wq ID */
>  #define WCN36XX_TX_B_WQ_ID		0xA
>  #define WCN36XX_TX_U_WQ_ID		0x9
> +/* bd_rate */
> +#define WCN36XX_BD_RATE_DATA 0
> +#define WCN36XX_BD_RATE_MGMT 2
> +#define WCN36XX_BD_RATE_CTRL 3

Having an empty line before the commit would make it more readable.

-- 
Kalle Valo



More information about the wcn36xx mailing list