[PATCH 02/11] wcn36xx: Move \n out of print functions
Eugene Krasnikov
k.eugene.e at gmail.com
Thu Aug 22 04:45:55 EDT 2013
To make code similar as in all ath drivers.
Signed-off-by: Eugene Krasnikov <k.eugene.e at gmail.com>
---
debug.c | 2 +-
dxe.c | 28 +++++++++----------
main.c | 94 +++++++++++++++++++++++++++++++--------------------------------
pmc.c | 2 +-
smd.c | 94 +++++++++++++++++++++++++++++++--------------------------------
txrx.c | 18 ++++++------
wcn36xx.h | 8 +++---
7 files changed, 123 insertions(+), 123 deletions(-)
diff --git a/debug.c b/debug.c
index ef21fc5..91508f3 100644
--- a/debug.c
+++ b/debug.c
@@ -148,7 +148,7 @@ void wcn36xx_debugfs_init(struct wcn36xx *wcn)
dfs->rootdir = debugfs_create_dir(KBUILD_MODNAME,
wcn->hw->wiphy->debugfsdir);
if (IS_ERR(dfs->rootdir)) {
- wcn36xx_warn("Create the debugfs failed");
+ wcn36xx_warn("Create the debugfs failed\n");
dfs->rootdir = NULL;
}
diff --git a/dxe.c b/dxe.c
index 4668efa..140d70b 100644
--- a/dxe.c
+++ b/dxe.c
@@ -38,7 +38,7 @@ void *wcn36xx_dxe_get_next_bd(struct wcn36xx *wcn, bool is_low)
static void wcn36xx_dxe_write_register(struct wcn36xx *wcn, int addr, int data)
{
wcn36xx_dbg(WCN36XX_DBG_DXE,
- "wcn36xx_dxe_write_register: addr=%x, data=%x",
+ "wcn36xx_dxe_write_register: addr=%x, data=%x\n",
addr, data);
writel(data, wcn->mmio + addr);
@@ -49,7 +49,7 @@ static void wcn36xx_dxe_read_register(struct wcn36xx *wcn, int addr, int *data)
*data = readl(wcn->mmio + addr);
wcn36xx_dbg(WCN36XX_DBG_DXE,
- "wcn36xx_dxe_read_register: addr=%x, data=%x",
+ "wcn36xx_dxe_read_register: addr=%x, data=%x\n",
addr, *data);
}
@@ -147,7 +147,7 @@ int wcn36xx_dxe_alloc_ctl_blks(struct wcn36xx *wcn)
return 0;
out_err:
- wcn36xx_error("Failed to allocate DXE control blocks");
+ wcn36xx_error("Failed to allocate DXE control blocks\n");
wcn36xx_dxe_free_ctl_blks(wcn);
return -ENOMEM;
}
@@ -319,7 +319,7 @@ void wcn36xx_dxe_tx_ack_ind(struct wcn36xx *wcn, u32 status)
spin_unlock_irqrestore(&wcn->dxe_lock, flags);
if (!skb) {
- wcn36xx_warn("Spurious TX complete indication");
+ wcn36xx_warn("Spurious TX complete indication\n");
return;
}
@@ -328,7 +328,7 @@ void wcn36xx_dxe_tx_ack_ind(struct wcn36xx *wcn, u32 status)
if (status == 1)
info->flags |= IEEE80211_TX_STAT_ACK;
- wcn36xx_dbg(WCN36XX_DBG_DXE, "dxe tx ack status: %d", status);
+ wcn36xx_dbg(WCN36XX_DBG_DXE, "dxe tx ack status: %d\n", status);
ieee80211_tx_status_irqsafe(wcn->hw, skb);
ieee80211_wake_queues(wcn->hw);
@@ -390,7 +390,7 @@ static irqreturn_t wcn36xx_irq_tx_complete(int irq, void *dev)
wcn36xx_dxe_write_register(wcn, WCN36XX_DXE_0_INT_ED_CLR,
WCN36XX_INT_MASK_CHAN_TX_H);
- wcn36xx_dbg(WCN36XX_DBG_DXE, "dxe tx ready high");
+ wcn36xx_dbg(WCN36XX_DBG_DXE, "dxe tx ready high\n");
reap_tx_dxes(wcn, &wcn->dxe_tx_h_ch);
}
@@ -406,7 +406,7 @@ static irqreturn_t wcn36xx_irq_tx_complete(int irq, void *dev)
wcn36xx_dxe_write_register(wcn, WCN36XX_DXE_0_INT_ED_CLR,
WCN36XX_INT_MASK_CHAN_TX_L);
- wcn36xx_dbg(WCN36XX_DBG_DXE, "dxe tx ready low");
+ wcn36xx_dbg(WCN36XX_DBG_DXE, "dxe tx ready low\n");
reap_tx_dxes(wcn, &wcn->dxe_tx_l_ch);
}
@@ -430,14 +430,14 @@ static int wcn36xx_dxe_request_irqs(struct wcn36xx *wcn)
ret = request_irq(wcn->tx_irq, wcn36xx_irq_tx_complete,
IRQF_TRIGGER_HIGH, "wcn36xx_tx", wcn);
if (ret) {
- wcn36xx_error("failed to alloc tx irq");
+ wcn36xx_error("failed to alloc tx irq\n");
goto out_err;
}
ret = request_irq(wcn->rx_irq, wcn36xx_irq_rx_ready, IRQF_TRIGGER_HIGH,
"wcn36xx_rx", wcn);
if (ret) {
- wcn36xx_error("failed to alloc rx irq");
+ wcn36xx_error("failed to alloc rx irq\n");
goto out_txirq;
}
@@ -477,7 +477,7 @@ static int wcn36xx_rx_handle_packets(struct wcn36xx *wcn,
WCN36XX_DXE_INT_CH3_MASK);
break;
default:
- wcn36xx_warn("Unknown channel");
+ wcn36xx_warn("Unknown channel\n");
}
dma_unmap_single(NULL, dma_addr, WCN36XX_PKT_SIZE,
@@ -514,7 +514,7 @@ void wcn36xx_dxe_rx_frame(struct wcn36xx *wcn)
}
if (!int_src)
- wcn36xx_warn("No DXE interrupt pending");
+ wcn36xx_warn("No DXE interrupt pending\n");
}
int wcn36xx_dxe_allocate_mem_pools(struct wcn36xx *wcn)
@@ -556,7 +556,7 @@ int wcn36xx_dxe_allocate_mem_pools(struct wcn36xx *wcn)
out_err:
wcn36xx_dxe_free_mem_pools(wcn);
- wcn36xx_error("Failed to allocate BD mempool");
+ wcn36xx_error("Failed to allocate BD mempool\n");
return -ENOMEM;
}
@@ -614,7 +614,7 @@ int wcn36xx_dxe_tx_frame(struct wcn36xx *wcn,
desc->fr_len = sizeof(struct wcn36xx_tx_bd);
desc->ctrl = ch->ctrl_bd;
- wcn36xx_dbg(WCN36XX_DBG_DXE, "DXE TX");
+ wcn36xx_dbg(WCN36XX_DBG_DXE, "DXE TX\n");
wcn36xx_dbg_dump(WCN36XX_DBG_DXE_DUMP, "DESC1 >>> ",
(char *)desc, sizeof(*desc));
@@ -627,7 +627,7 @@ int wcn36xx_dxe_tx_frame(struct wcn36xx *wcn,
ctl->skb = skb;
desc = ctl->desc;
if (ctl->bd_cpu_addr) {
- wcn36xx_error("bd_cpu_addr cannot be NULL for skb DXE");
+ wcn36xx_error("bd_cpu_addr cannot be NULL for skb DXE\n");
return -EINVAL;
}
diff --git a/main.c b/main.c
index e4bf796..35e3b01 100644
--- a/main.c
+++ b/main.c
@@ -195,52 +195,52 @@ static int wcn36xx_start(struct ieee80211_hw *hw)
struct wcn36xx *wcn = hw->priv;
int ret;
- wcn36xx_dbg(WCN36XX_DBG_MAC, "mac start");
+ wcn36xx_dbg(WCN36XX_DBG_MAC, "mac start\n");
/* SMD initialization */
ret = wcn36xx_smd_open(wcn);
if (ret) {
- wcn36xx_error("Failed to open smd channel: %d", ret);
+ wcn36xx_error("Failed to open smd channel: %d\n", ret);
goto out_err;
}
/* Allocate memory pools for Mgmt BD headers and Data BD headers */
ret = wcn36xx_dxe_allocate_mem_pools(wcn);
if (ret) {
- wcn36xx_error("Failed to alloc DXE mempool: %d", ret);
+ wcn36xx_error("Failed to alloc DXE mempool: %d\n", ret);
goto out_smd_close;
}
ret = wcn36xx_dxe_alloc_ctl_blks(wcn);
if (ret) {
- wcn36xx_error("Failed to alloc DXE ctl blocks: %d", ret);
+ wcn36xx_error("Failed to alloc DXE ctl blocks: %d\n", ret);
goto out_free_dxe_pool;
}
/* Maximum SMD message size is 4k */
wcn->smd_buf = kmalloc(WCN36XX_SMD_BUF_SIZE, GFP_KERNEL);
if (!wcn->smd_buf) {
- wcn36xx_error("Failed to allocate smd buf");
+ wcn36xx_error("Failed to allocate smd buf\n");
ret = -ENOMEM;
goto out_free_dxe_ctl;
}
ret = wcn36xx_smd_load_nv(wcn);
if (ret) {
- wcn36xx_error("Failed to push NV to chip");
+ wcn36xx_error("Failed to push NV to chip\n");
goto out_free_smd_buf;
}
ret = wcn36xx_smd_start(wcn);
if (ret) {
- wcn36xx_error("Failed to start chip");
+ wcn36xx_error("Failed to start chip\n");
goto out_free_smd_buf;
}
/* DMA channel initialization */
ret = wcn36xx_dxe_init(wcn);
if (ret) {
- wcn36xx_error("DXE init failed");
+ wcn36xx_error("DXE init failed\n");
goto out_smd_stop;
}
@@ -250,7 +250,7 @@ static int wcn36xx_start(struct ieee80211_hw *hw)
if (!wcn36xx_is_fw_version(wcn, 1, 2, 2, 24)) {
ret = wcn36xx_smd_feature_caps_exchange(wcn);
if (ret)
- wcn36xx_warn("Exchange feature caps failed");
+ wcn36xx_warn("Exchange feature caps failed\n");
}
return 0;
@@ -273,7 +273,7 @@ static void wcn36xx_stop(struct ieee80211_hw *hw)
{
struct wcn36xx *wcn = hw->priv;
- wcn36xx_dbg(WCN36XX_DBG_MAC, "mac stop");
+ wcn36xx_dbg(WCN36XX_DBG_MAC, "mac stop\n");
wcn36xx_debugfs_exit(wcn);
wcn36xx_smd_stop(wcn);
@@ -290,11 +290,11 @@ static int wcn36xx_config(struct ieee80211_hw *hw, u32 changed)
{
struct wcn36xx *wcn = hw->priv;
- wcn36xx_dbg(WCN36XX_DBG_MAC, "mac config changed 0x%08x", changed);
+ wcn36xx_dbg(WCN36XX_DBG_MAC, "mac config changed 0x%08x\n", changed);
if (changed & IEEE80211_CONF_CHANGE_CHANNEL) {
int ch = WCN36XX_HW_CHANNEL(wcn);
- wcn36xx_dbg(WCN36XX_DBG_MAC, "wcn36xx_config channel switch=%d",
+ wcn36xx_dbg(WCN36XX_DBG_MAC, "wcn36xx_config channel switch=%d\n",
ch);
wcn36xx_smd_switch_channel(wcn, ch);
}
@@ -308,7 +308,7 @@ static void wcn36xx_configure_filter(struct ieee80211_hw *hw,
unsigned int changed,
unsigned int *total, u64 multicast)
{
- wcn36xx_dbg(WCN36XX_DBG_MAC, "mac configure filter");
+ wcn36xx_dbg(WCN36XX_DBG_MAC, "mac configure filter\n");
changed &= WCN36XX_SUPPORTED_FILTERS;
*total &= WCN36XX_SUPPORTED_FILTERS;
@@ -337,8 +337,8 @@ static int wcn36xx_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
int ret = 0;
u8 key[WLAN_MAX_KEY_LEN];
- wcn36xx_dbg(WCN36XX_DBG_MAC, "mac80211 set key");
- wcn36xx_dbg(WCN36XX_DBG_MAC, "Key: cmd=0x%x algo:0x%x, id:%d, len:%d flags 0x%x",
+ wcn36xx_dbg(WCN36XX_DBG_MAC, "mac80211 set key\n");
+ wcn36xx_dbg(WCN36XX_DBG_MAC, "Key: cmd=0x%x algo:0x%x, id:%d, len:%d flags 0x%x\n",
cmd, key_conf->cipher, key_conf->keyidx,
key_conf->keylen, key_conf->flags);
wcn36xx_dbg_dump(WCN36XX_DBG_MAC, "KEY: ",
@@ -353,7 +353,7 @@ static int wcn36xx_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
wcn->encrypt_type = WCN36XX_HAL_ED_TKIP;
break;
default:
- wcn36xx_error("Unsupported key type 0x%x",
+ wcn36xx_error("Unsupported key type 0x%x\n",
key_conf->cipher);
ret = -EOPNOTSUPP;
goto out;
@@ -416,7 +416,7 @@ static int wcn36xx_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
}
break;
default:
- wcn36xx_error("Unsupported key cmd 0x%x", cmd);
+ wcn36xx_error("Unsupported key cmd 0x%x\n", cmd);
ret = -EOPNOTSUPP;
goto out;
break;
@@ -493,19 +493,19 @@ static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw,
wcn->current_vif = (struct wcn36xx_vif *)vif->drv_priv;
- wcn36xx_dbg(WCN36XX_DBG_MAC, "mac bss info changed vif %p changed 0x%08x",
+ wcn36xx_dbg(WCN36XX_DBG_MAC, "mac bss info changed vif %p changed 0x%08x\n",
vif, changed);
if (changed & BSS_CHANGED_BEACON_INFO) {
wcn36xx_dbg(WCN36XX_DBG_MAC,
- "mac bss changed dtim period %d",
+ "mac bss changed dtim period %d\n",
bss_conf->dtim_period);
wcn->dtim_period = bss_conf->dtim_period;
}
if (changed & BSS_CHANGED_BSSID) {
- wcn36xx_dbg(WCN36XX_DBG_MAC, "mac bss changed_bssid %pM",
+ wcn36xx_dbg(WCN36XX_DBG_MAC, "mac bss changed_bssid %pM\n",
bss_conf->bssid);
if (!is_zero_ether_addr(bss_conf->bssid)) {
@@ -523,7 +523,7 @@ static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw,
if (changed & BSS_CHANGED_SSID) {
wcn36xx_dbg(WCN36XX_DBG_MAC,
- "mac bss changed ssid");
+ "mac bss changed ssid\n");
wcn36xx_dbg_dump(WCN36XX_DBG_MAC, "ssid ",
bss_conf->ssid, bss_conf->ssid_len);
@@ -538,7 +538,7 @@ static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw,
struct wcn36xx_sta *sta_priv;
wcn36xx_dbg(WCN36XX_DBG_MAC,
- "mac assoc bss %pM vif %pM AID=%d",
+ "mac assoc bss %pM vif %pM AID=%d\n",
bss_conf->bssid,
vif->addr,
bss_conf->aid);
@@ -548,7 +548,7 @@ static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw,
rcu_read_lock();
sta = ieee80211_find_sta(vif, bss_conf->bssid);
if (!sta) {
- wcn36xx_error("sta %pM is not found",
+ wcn36xx_error("sta %pM is not found\n",
bss_conf->bssid);
rcu_read_unlock();
goto out;
@@ -567,7 +567,7 @@ static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw,
rcu_read_unlock();
} else {
wcn36xx_dbg(WCN36XX_DBG_MAC,
- "disassociated bss %pM vif %pM AID=%d",
+ "disassociated bss %pM vif %pM AID=%d\n",
bss_conf->bssid,
vif->addr,
bss_conf->aid);
@@ -580,10 +580,10 @@ static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw,
}
if (changed & BSS_CHANGED_AP_PROBE_RESP) {
- wcn36xx_dbg(WCN36XX_DBG_MAC, "mac bss changed ap probe resp");
+ wcn36xx_dbg(WCN36XX_DBG_MAC, "mac bss changed ap probe resp\n");
skb = ieee80211_proberesp_get(hw, vif);
if (!skb) {
- wcn36xx_error("failed to alloc probereq skb");
+ wcn36xx_error("failed to alloc probereq skb\n");
goto out;
}
@@ -593,7 +593,7 @@ static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw,
if (changed & BSS_CHANGED_BEACON_ENABLED) {
wcn36xx_dbg(WCN36XX_DBG_MAC,
- "mac bss changed beacon enabled %d",
+ "mac bss changed beacon enabled %d\n",
bss_conf->enable_beacon);
if (bss_conf->enable_beacon) {
@@ -603,7 +603,7 @@ static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw,
skb = ieee80211_beacon_get_tim(hw, vif, &tim_off,
&tim_len);
if (!skb) {
- wcn36xx_error("failed to alloc beacon skb");
+ wcn36xx_error("failed to alloc beacon skb\n");
goto out;
}
wcn36xx_smd_send_beacon(wcn, skb, tim_off, 0);
@@ -631,7 +631,7 @@ out:
static int wcn36xx_set_rts_threshold(struct ieee80211_hw *hw, u32 value)
{
struct wcn36xx *wcn = hw->priv;
- wcn36xx_dbg(WCN36XX_DBG_MAC, "mac set RTS threshold %d", value);
+ wcn36xx_dbg(WCN36XX_DBG_MAC, "mac set RTS threshold %d\n", value);
wcn36xx_smd_update_cfg(wcn, WCN36XX_HAL_CFG_RTS_THRESHOLD, value);
return 0;
@@ -641,7 +641,7 @@ static void wcn36xx_remove_interface(struct ieee80211_hw *hw,
struct ieee80211_vif *vif)
{
struct wcn36xx *wcn = hw->priv;
- wcn36xx_dbg(WCN36XX_DBG_MAC, "mac remove interface vif %p", vif);
+ wcn36xx_dbg(WCN36XX_DBG_MAC, "mac remove interface vif %p\n", vif);
wcn36xx_smd_delete_sta_self(wcn, vif->addr);
}
@@ -650,7 +650,7 @@ static int wcn36xx_add_interface(struct ieee80211_hw *hw,
{
struct wcn36xx *wcn = hw->priv;
- wcn36xx_dbg(WCN36XX_DBG_MAC, "mac add interface vif %p type %d",
+ wcn36xx_dbg(WCN36XX_DBG_MAC, "mac add interface vif %p type %d\n",
vif, vif->type);
wcn->current_vif = (struct wcn36xx_vif *)vif->drv_priv;
@@ -667,7 +667,7 @@ static int wcn36xx_add_interface(struct ieee80211_hw *hw,
wcn36xx_smd_add_sta_self(wcn, vif->addr, 0);
break;
default:
- wcn36xx_warn("Unsupported interface type requested: %d",
+ wcn36xx_warn("Unsupported interface type requested: %d\n",
vif->type);
return -EOPNOTSUPP;
}
@@ -680,7 +680,7 @@ static int wcn36xx_sta_add(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
{
struct wcn36xx *wcn = hw->priv;
- wcn36xx_dbg(WCN36XX_DBG_MAC, "mac sta add vif %p sta %pM",
+ wcn36xx_dbg(WCN36XX_DBG_MAC, "mac sta add vif %p sta %pM\n",
vif, sta->addr);
wcn->sta = (struct wcn36xx_sta *)sta->drv_priv;
@@ -697,7 +697,7 @@ static int wcn36xx_sta_remove(struct ieee80211_hw *hw,
struct wcn36xx *wcn = hw->priv;
struct wcn36xx_sta *sta_priv = (struct wcn36xx_sta *)sta->drv_priv;
- wcn36xx_dbg(WCN36XX_DBG_MAC, "mac sta remove vif %p sta %pM index %d",
+ wcn36xx_dbg(WCN36XX_DBG_MAC, "mac sta remove vif %p sta %pM index %d\n",
vif, sta->addr, sta_priv->sta_index);
wcn36xx_smd_delete_sta(wcn, sta_priv->sta_index);
@@ -714,7 +714,7 @@ static int wcn36xx_suspend(struct ieee80211_hw *hw, struct cfg80211_wowlan *wow)
struct ieee80211_vif,
drv_priv);
- wcn36xx_dbg(WCN36XX_DBG_MAC, "mac suspend");
+ wcn36xx_dbg(WCN36XX_DBG_MAC, "mac suspend\n");
mutex_lock(&wcn->pm_mutex);
@@ -739,7 +739,7 @@ static int wcn36xx_resume(struct ieee80211_hw *hw)
struct ieee80211_vif,
drv_priv);
- wcn36xx_dbg(WCN36XX_DBG_MAC, "mac resume");
+ wcn36xx_dbg(WCN36XX_DBG_MAC, "mac resume\n");
wcn->is_suspended = false;
@@ -747,7 +747,7 @@ static int wcn36xx_resume(struct ieee80211_hw *hw)
wcn36xx_pmc_exit_bmps_state(wcn);
if (wcn->is_con_lost_pending) {
- wcn36xx_dbg(WCN36XX_DBG_MAC, "report connection lost");
+ wcn36xx_dbg(WCN36XX_DBG_MAC, "report connection lost\n");
ieee80211_connection_loss(vif);
}
@@ -765,7 +765,7 @@ static int wcn36xx_ampdu_action(struct ieee80211_hw *hw,
struct wcn36xx *wcn = hw->priv;
struct wcn36xx_sta *sta_priv = NULL;
- wcn36xx_dbg(WCN36XX_DBG_MAC, "mac ampdu action action %d tid %d",
+ wcn36xx_dbg(WCN36XX_DBG_MAC, "mac ampdu action action %d tid %d\n",
action, tid);
sta_priv = (struct wcn36xx_sta *)sta->drv_priv;
@@ -797,7 +797,7 @@ static int wcn36xx_ampdu_action(struct ieee80211_hw *hw,
case IEEE80211_AMPDU_TX_STOP_FLUSH_CONT:
break;
default:
- wcn36xx_error("Unknown AMPDU action");
+ wcn36xx_error("Unknown AMPDU action\n");
}
return 0;
@@ -886,7 +886,7 @@ static int wcn36xx_platform_get_resources(struct wcn36xx *wcn,
res = platform_get_resource_byname(pdev, IORESOURCE_IRQ,
"wcnss_wlantx_irq");
if (!res) {
- wcn36xx_error("failed to get tx_irq");
+ wcn36xx_error("failed to get tx_irq\n");
return -ENOENT;
}
wcn->tx_irq = res->start;
@@ -895,7 +895,7 @@ static int wcn36xx_platform_get_resources(struct wcn36xx *wcn,
res = platform_get_resource_byname(pdev, IORESOURCE_IRQ,
"wcnss_wlanrx_irq");
if (!res) {
- wcn36xx_error("failed to get rx_irq");
+ wcn36xx_error("failed to get rx_irq\n");
return -ENOENT;
}
wcn->rx_irq = res->start;
@@ -904,12 +904,12 @@ static int wcn36xx_platform_get_resources(struct wcn36xx *wcn,
res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
"wcnss_mmio");
if (!res) {
- wcn36xx_error("failed to get mmio");
+ wcn36xx_error("failed to get mmio\n");
return -ENOENT;
}
wcn->mmio = ioremap(res->start, resource_size(res));
if (!wcn->mmio) {
- wcn36xx_error("failed to map io memory");
+ wcn36xx_error("failed to map io memory\n");
return -ENOMEM;
}
return 0;
@@ -936,11 +936,11 @@ static int wcn36xx_probe(struct platform_device *pdev)
HW_RATE_INDEX_5_5MBPS,
HW_RATE_INDEX_11MBPS
};
- wcn36xx_dbg(WCN36XX_DBG_MAC, "platform probe");
+ wcn36xx_dbg(WCN36XX_DBG_MAC, "platform probe\n");
hw = ieee80211_alloc_hw(sizeof(struct wcn36xx), &wcn36xx_ops);
if (!hw) {
- wcn36xx_error("failed to alloc hw");
+ wcn36xx_error("failed to alloc hw\n");
ret = -ENOMEM;
goto out_err;
}
@@ -962,7 +962,7 @@ static int wcn36xx_probe(struct platform_device *pdev)
wcn->supported_rates.supported_mcs_set[0] = 0xFF;
if (!wcn->ctrl_ops->get_hw_mac(wcn->addresses.addr)) {
- wcn36xx_info("mac address: %pM", wcn->addresses.addr);
+ wcn36xx_info("mac address: %pM\n", wcn->addresses.addr);
SET_IEEE80211_PERM_ADDR(wcn->hw, wcn->addresses.addr);
}
@@ -988,7 +988,7 @@ static int wcn36xx_remove(struct platform_device *pdev)
{
struct ieee80211_hw *hw = platform_get_drvdata(pdev);
struct wcn36xx *wcn = hw->priv;
- wcn36xx_dbg(WCN36XX_DBG_MAC, "platform remove");
+ wcn36xx_dbg(WCN36XX_DBG_MAC, "platform remove\n");
mutex_destroy(&wcn->pm_mutex);
mutex_destroy(&wcn->smd_mutex);
diff --git a/pmc.c b/pmc.c
index ce7771f..f72096e 100644
--- a/pmc.c
+++ b/pmc.c
@@ -41,6 +41,6 @@ int wcn36xx_pmc_exit_bmps_state(struct wcn36xx *wcn)
int wcn36xx_enable_keep_alive_null_packet(struct wcn36xx *wcn)
{
- wcn36xx_dbg(WCN36XX_DBG_PMC, "%s", __func__);
+ wcn36xx_dbg(WCN36XX_DBG_PMC, "%s\n", __func__);
return wcn36xx_smd_keep_alive_req(wcn, WCN36XX_HAL_KEEP_ALIVE_NULL_PKT);
}
diff --git a/smd.c b/smd.c
index 1f6f71d..8947d7e 100644
--- a/smd.c
+++ b/smd.c
@@ -27,7 +27,7 @@ static int put_cfg_tlv_u32(struct wcn36xx *wcn, size_t *len, u32 id, u32 value)
u32 *val;
if (*len + sizeof(*entry) + sizeof(u32) >= WCN36XX_SMD_BUF_SIZE) {
- wcn36xx_error("Not enough room for TLV entry");
+ wcn36xx_error("Not enough room for TLV entry\n");
return -ENOMEM;
}
@@ -222,7 +222,7 @@ int wcn36xx_smd_load_nv(struct wcn36xx *wcn)
ret = request_firmware(&nv, WLAN_NV_FILE, wcn->dev);
if (ret) {
- wcn36xx_error("Failed to load nv file %s: %d",
+ wcn36xx_error("Failed to load nv file %s: %d\n",
WLAN_NV_FILE, ret);
goto out_free_nv;
}
@@ -285,7 +285,7 @@ int wcn36xx_smd_start(struct wcn36xx *wcn)
PREPARE_HAL_BUF(wcn->smd_buf, msg_body);
- wcn36xx_dbg(WCN36XX_DBG_HAL, "hal start type %d",
+ wcn36xx_dbg(WCN36XX_DBG_HAL, "hal start type %d\n",
msg_body.params.type);
return wcn36xx_smd_send_and_wait(wcn, msg_body.header.len);
@@ -317,10 +317,10 @@ static int wcn36xx_smd_start_rsp(struct wcn36xx *wcn, void *buf, size_t len)
wcn->fw_minor = rsp->start_rsp_params.version.minor;
wcn->fw_major = rsp->start_rsp_params.version.major;
- wcn36xx_info("firmware WLAN version '%s' and CRM version '%s'",
+ wcn36xx_info("firmware WLAN version '%s' and CRM version '%s'\n",
wcn->wlan_version, wcn->crm_version);
- wcn36xx_info("firmware API %u.%u.%u.%u, %u stations, %u bssids",
+ wcn36xx_info("firmware API %u.%u.%u.%u, %u stations, %u bssids\n",
wcn->fw_major, wcn->fw_minor,
wcn->fw_version, wcn->fw_revision,
rsp->start_rsp_params.stations,
@@ -352,7 +352,7 @@ int wcn36xx_smd_init_scan(struct wcn36xx *wcn)
PREPARE_HAL_BUF(wcn->smd_buf, msg_body);
- wcn36xx_dbg(WCN36XX_DBG_HAL, "hal init scan mode %d", msg_body.mode);
+ wcn36xx_dbg(WCN36XX_DBG_HAL, "hal init scan mode %d\n", msg_body.mode);
return wcn36xx_smd_send_and_wait(wcn, msg_body.header.len);
}
@@ -367,7 +367,7 @@ int wcn36xx_smd_start_scan(struct wcn36xx *wcn)
PREPARE_HAL_BUF(wcn->smd_buf, msg_body);
- wcn36xx_dbg(WCN36XX_DBG_HAL, "hal start scan channel %d",
+ wcn36xx_dbg(WCN36XX_DBG_HAL, "hal start scan channel %d\n",
msg_body.scan_channel);
return wcn36xx_smd_send_and_wait(wcn, msg_body.header.len);
@@ -383,7 +383,7 @@ int wcn36xx_smd_end_scan(struct wcn36xx *wcn)
PREPARE_HAL_BUF(wcn->smd_buf, msg_body);
- wcn36xx_dbg(WCN36XX_DBG_HAL, "hal end scan channel %d",
+ wcn36xx_dbg(WCN36XX_DBG_HAL, "hal end scan channel %d\n",
msg_body.scan_channel);
return wcn36xx_smd_send_and_wait(wcn, msg_body.header.len);
@@ -399,7 +399,7 @@ int wcn36xx_smd_finish_scan(struct wcn36xx *wcn)
PREPARE_HAL_BUF(wcn->smd_buf, msg_body);
- wcn36xx_dbg(WCN36XX_DBG_HAL, "hal finish scan mode %d",
+ wcn36xx_dbg(WCN36XX_DBG_HAL, "hal finish scan mode %d\n",
msg_body.mode);
return wcn36xx_smd_send_and_wait(wcn, msg_body.header.len);
@@ -425,7 +425,7 @@ static void wcn36xx_smd_switch_channel_rsp(void *buf, size_t len)
{
struct wcn36xx_hal_switch_channel_rsp_msg *rsp;
rsp = (struct wcn36xx_hal_switch_channel_rsp_msg *)buf;
- wcn36xx_dbg(WCN36XX_DBG_HAL, "channel switched to: %d, status: %d",
+ wcn36xx_dbg(WCN36XX_DBG_HAL, "channel switched to: %d, status: %d\n",
rsp->channel_number, rsp->status);
}
@@ -447,7 +447,7 @@ int wcn36xx_smd_update_scan_params(struct wcn36xx *wcn)
PREPARE_HAL_BUF(wcn->smd_buf, msg_body);
wcn36xx_dbg(WCN36XX_DBG_HAL,
- "hal update scan params channel_count %d",
+ "hal update scan params channel_count %d\n",
msg_body.channel_count);
return wcn36xx_smd_send_and_wait(wcn, msg_body.header.len);
@@ -463,7 +463,7 @@ static int wcn36xx_smd_update_scan_params_rsp(void *buf, size_t len)
rsp->status &= (~(WCN36XX_FW_MSG_PNO_VERSION_MASK));
if (WCN36XX_FW_MSG_RESULT_SUCCESS != rsp->status) {
- wcn36xx_warn("error response from update scan");
+ wcn36xx_warn("error response from update scan\n");
return -EIO;
}
@@ -482,7 +482,7 @@ int wcn36xx_smd_add_sta_self(struct wcn36xx *wcn, u8 *addr, u32 status)
PREPARE_HAL_BUF(wcn->smd_buf, msg_body);
wcn36xx_dbg(WCN36XX_DBG_HAL,
- "hal add sta self self_addr %pM status %d",
+ "hal add sta self self_addr %pM status %d\n",
msg_body.self_addr, msg_body.status);
return wcn36xx_smd_send_and_wait(wcn, msg_body.header.len);
@@ -500,13 +500,13 @@ static int wcn36xx_smd_add_sta_self_rsp(struct wcn36xx *wcn,
rsp = (struct wcn36xx_hal_add_sta_self_rsp_msg *)buf;
if (rsp->status != WCN36XX_FW_MSG_RESULT_SUCCESS) {
- wcn36xx_warn("hal add sta self failure: %d",
+ wcn36xx_warn("hal add sta self failure: %d\n",
rsp->status);
return -EIO;
}
wcn36xx_dbg(WCN36XX_DBG_HAL,
- "hal add sta self status %d self_sta_index %d dpu_index %d",
+ "hal add sta self status %d self_sta_index %d dpu_index %d\n",
rsp->status, rsp->self_sta_index, rsp->dpu_index);
wcn->current_vif->self_sta_index = rsp->self_sta_index;
@@ -539,7 +539,7 @@ int wcn36xx_smd_delete_sta(struct wcn36xx *wcn, u8 sta_index)
PREPARE_HAL_BUF(wcn->smd_buf, msg_body);
wcn36xx_dbg(WCN36XX_DBG_HAL,
- "hal delete sta sta_index %d",
+ "hal delete sta sta_index %d\n",
msg_body.sta_index);
return wcn36xx_smd_send_and_wait(wcn, msg_body.header.len);
@@ -572,7 +572,7 @@ int wcn36xx_smd_join(struct wcn36xx *wcn, const u8 *bssid, u8 *vif, u8 ch)
PREPARE_HAL_BUF(wcn->smd_buf, msg_body);
wcn36xx_dbg(WCN36XX_DBG_HAL,
- "hal join req bssid %pM self_sta_mac_addr %pM channel %d link_state %d",
+ "hal join req bssid %pM self_sta_mac_addr %pM channel %d link_state %d\n",
msg_body.bssid, msg_body.self_sta_mac_addr,
msg_body.channel, msg_body.link_state);
@@ -594,7 +594,7 @@ int wcn36xx_smd_set_link_st(struct wcn36xx *wcn, const u8 *bssid,
PREPARE_HAL_BUF(wcn->smd_buf, msg_body);
wcn36xx_dbg(WCN36XX_DBG_HAL,
- "hal set link state bssid %pM self_mac_addr %pM state %d",
+ "hal set link state bssid %pM self_mac_addr %pM state %d\n",
msg_body.bssid, msg_body.self_mac_addr, msg_body.state);
return wcn36xx_smd_send_and_wait(wcn, msg_body.header.len);
@@ -636,7 +636,7 @@ static int wcn36xx_smd_config_sta_v1(struct wcn36xx *wcn,
PREPARE_HAL_BUF(wcn->smd_buf, msg_body);
wcn36xx_dbg(WCN36XX_DBG_HAL,
- "hal config sta v1 action %d sta_index %d bssid_index %d bssid %pM type %d mac %pM aid %d",
+ "hal config sta v1 action %d sta_index %d bssid_index %d bssid %pM type %d mac %pM aid %d\n",
sta->action, sta->sta_index, sta->bssid_index,
sta->bssid, sta->type, sta->mac, sta->aid);
@@ -661,7 +661,7 @@ int wcn36xx_smd_config_sta(struct wcn36xx *wcn, struct ieee80211_vif *vif,
PREPARE_HAL_BUF(wcn->smd_buf, msg);
wcn36xx_dbg(WCN36XX_DBG_HAL,
- "hal config sta action %d sta_index %d bssid_index %d bssid %pM type %d mac %pM aid %d",
+ "hal config sta action %d sta_index %d bssid_index %d bssid %pM type %d mac %pM aid %d\n",
sta_params->action, sta_params->sta_index,
sta_params->bssid_index, sta_params->bssid,
sta_params->type, sta_params->mac, sta_params->aid);
@@ -682,7 +682,7 @@ static int wcn36xx_smd_config_sta_rsp(struct wcn36xx *wcn, void *buf,
params = &rsp->params;
if (params->status != WCN36XX_FW_MSG_RESULT_SUCCESS) {
- wcn36xx_warn("hal config sta response failure: %d",
+ wcn36xx_warn("hal config sta response failure: %d\n",
params->status);
return -EIO;
}
@@ -694,7 +694,7 @@ static int wcn36xx_smd_config_sta_rsp(struct wcn36xx *wcn, void *buf,
}
wcn36xx_dbg(WCN36XX_DBG_HAL,
- "hal config sta rsp status %d sta_index %d bssid_index %d p2p %d",
+ "hal config sta rsp status %d sta_index %d bssid_index %d p2p %d\n",
params->status, params->sta_index, params->bssid_index,
params->p2p);
@@ -711,7 +711,7 @@ static int wcn36xx_smd_join_rsp(void *buf, size_t len)
rsp = (struct wcn36xx_hal_join_rsp_msg *)buf;
wcn36xx_dbg(WCN36XX_DBG_HAL,
- "hal rsp join status %d tx_mgmt_power %d",
+ "hal rsp join status %d tx_mgmt_power %d\n",
rsp->status, rsp->tx_mgmt_power);
return 0;
@@ -812,12 +812,12 @@ static int wcn36xx_smd_config_bss_v1(struct wcn36xx *wcn,
PREPARE_HAL_BUF(wcn->smd_buf, msg_body);
wcn36xx_dbg(WCN36XX_DBG_HAL,
- "hal config bss v1 bssid %pM self_mac_addr %pM bss_type %d oper_mode %d nw_type %d",
+ "hal config bss v1 bssid %pM self_mac_addr %pM bss_type %d oper_mode %d nw_type %d\n",
bss->bssid, bss->self_mac_addr, bss->bss_type,
bss->oper_mode, bss->nw_type);
wcn36xx_dbg(WCN36XX_DBG_HAL,
- "- sta bssid %pM action %d sta_index %d bssid_index %d aid %d type %d mac %pM",
+ "- sta bssid %pM action %d sta_index %d bssid_index %d aid %d type %d mac %pM\n",
sta->bssid, sta->action, sta->sta_index,
sta->bssid_index, sta->aid, sta->type, sta->mac);
@@ -862,7 +862,7 @@ int wcn36xx_smd_config_bss(struct wcn36xx *wcn, struct ieee80211_vif *vif,
/* STA */
bss->oper_mode = 1;
} else {
- wcn36xx_warn("Unknown type for bss config: %d", vif->type);
+ wcn36xx_warn("Unknown type for bss config: %d\n", vif->type);
}
if (vif->type == NL80211_IFTYPE_STATION)
@@ -921,12 +921,12 @@ int wcn36xx_smd_config_bss(struct wcn36xx *wcn, struct ieee80211_vif *vif,
PREPARE_HAL_BUF(wcn->smd_buf, msg);
wcn36xx_dbg(WCN36XX_DBG_HAL,
- "hal config bss bssid %pM self_mac_addr %pM bss_type %d oper_mode %d nw_type %d",
+ "hal config bss bssid %pM self_mac_addr %pM bss_type %d oper_mode %d nw_type %d\n",
bss->bssid, bss->self_mac_addr, bss->bss_type,
bss->oper_mode, bss->nw_type);
wcn36xx_dbg(WCN36XX_DBG_HAL,
- "- sta bssid %pM action %d sta_index %d bssid_index %d aid %d type %d mac %pM",
+ "- sta bssid %pM action %d sta_index %d bssid_index %d aid %d type %d mac %pM\n",
sta_params->bssid, sta_params->action,
sta_params->sta_index, sta_params->bssid_index,
sta_params->aid, sta_params->type,
@@ -949,7 +949,7 @@ static int wcn36xx_smd_config_bss_rsp(struct wcn36xx *wcn,
params = &rsp->bss_rsp_params;
if (params->status != WCN36XX_FW_MSG_RESULT_SUCCESS) {
- wcn36xx_warn("hal config bss response failure: %d",
+ wcn36xx_warn("hal config bss response failure: %d\n",
params->status);
return -EIO;
}
@@ -957,7 +957,7 @@ static int wcn36xx_smd_config_bss_rsp(struct wcn36xx *wcn,
wcn36xx_dbg(WCN36XX_DBG_HAL,
"hal config bss rsp status %d bss_idx %d dpu_desc_index %d"
" sta_idx %d self_idx %d bcast_idx %d mac %pM"
- " power %d ucast_dpu_signature %d",
+ " power %d ucast_dpu_signature %d\n",
params->status, params->bss_index, params->dpu_desc_index,
params->bss_sta_index, params->bss_self_sta_index,
params->bss_bcast_sta_idx, params->mac,
@@ -986,7 +986,7 @@ int wcn36xx_smd_delete_bss(struct wcn36xx *wcn)
PREPARE_HAL_BUF(wcn->smd_buf, msg_body);
- wcn36xx_dbg(WCN36XX_DBG_HAL, "hal delete bss %d", msg_body.bss_index);
+ wcn36xx_dbg(WCN36XX_DBG_HAL, "hal delete bss %d\n", msg_body.bss_index);
return wcn36xx_smd_send_and_wait(wcn, msg_body.header.len);
}
@@ -1005,7 +1005,7 @@ int wcn36xx_smd_send_beacon(struct wcn36xx *wcn, struct sk_buff *skb_beacon,
memcpy(&(msg_body.beacon[4]), skb_beacon->data,
skb_beacon->len);
} else {
- wcn36xx_error("Beacon is to big: beacon size=%d",
+ wcn36xx_error("Beacon is to big: beacon size=%d\n",
msg_body.beacon_length);
return -ENOMEM;
}
@@ -1017,7 +1017,7 @@ int wcn36xx_smd_send_beacon(struct wcn36xx *wcn, struct sk_buff *skb_beacon,
PREPARE_HAL_BUF(wcn->smd_buf, msg_body);
wcn36xx_dbg(WCN36XX_DBG_HAL,
- "hal send beacon beacon_length %d",
+ "hal send beacon beacon_length %d\n",
msg_body.beacon_length);
return wcn36xx_smd_send_and_wait(wcn, msg_body.header.len);
@@ -1030,7 +1030,7 @@ int wcn36xx_smd_update_proberesp_tmpl(struct wcn36xx *wcn, struct sk_buff *skb)
INIT_HAL_MSG(msg, WCN36XX_HAL_UPDATE_PROBE_RSP_TEMPLATE_REQ);
if (skb->len > BEACON_TEMPLATE_SIZE) {
- wcn36xx_warn("probe response template is too big: %d",
+ wcn36xx_warn("probe response template is too big: %d\n",
skb->len);
return -E2BIG;
}
@@ -1043,7 +1043,7 @@ int wcn36xx_smd_update_proberesp_tmpl(struct wcn36xx *wcn, struct sk_buff *skb)
PREPARE_HAL_BUF(wcn->smd_buf, msg);
wcn36xx_dbg(WCN36XX_DBG_HAL,
- "hal update probe rsp len %d bssid %pM",
+ "hal update probe rsp len %d bssid %pM\n",
msg.probe_resp_template_len, msg.bssid);
return wcn36xx_smd_send_and_wait(wcn, msg.header.len);
@@ -1178,7 +1178,7 @@ int wcn36xx_smd_keep_alive_req(struct wcn36xx *wcn, int packet_type)
} else if (packet_type == WCN36XX_HAL_KEEP_ALIVE_UNSOLICIT_ARP_RSP) {
/* TODO: it also support ARP response type */
} else {
- wcn36xx_warn("unknow keep alive packet type %d", packet_type);
+ wcn36xx_warn("unknow keep alive packet type %d\n", packet_type);
return -EINVAL;
}
@@ -1211,7 +1211,7 @@ static inline void set_feat_caps(u32 *bitmap,
int arr_idx, bit_idx;
if (cap < 0 || cap > 127) {
- wcn36xx_warn("error cap idx %d", cap);
+ wcn36xx_warn("error cap idx %d\n", cap);
return;
}
@@ -1227,7 +1227,7 @@ static inline int get_feat_caps(u32 *bitmap,
int ret = 0;
if (cap < 0 || cap > 127) {
- wcn36xx_warn("error cap idx %d", cap);
+ wcn36xx_warn("error cap idx %d\n", cap);
return -EINVAL;
}
@@ -1243,7 +1243,7 @@ static inline void clear_feat_caps(u32 *bitmap,
int arr_idx, bit_idx;
if (cap < 0 || cap > 127) {
- wcn36xx_warn("error cap idx %d", cap);
+ wcn36xx_warn("error cap idx %d\n", cap);
return;
}
@@ -1270,7 +1270,7 @@ int wcn36xx_smd_feature_caps_exchange_rsp(void *buf, size_t len)
{
/* TODO: print the caps of rsp for comapre */
if (wcn36xx_smd_rsp_status_check(buf, len)) {
- wcn36xx_warn("error response for caps exchange");
+ wcn36xx_warn("error response for caps exchange\n");
return -EIO;
}
@@ -1359,7 +1359,7 @@ static int wcn36xx_smd_tx_compl_ind(struct wcn36xx *wcn, void *buf, size_t len)
struct wcn36xx_hal_tx_compl_ind_msg *rsp = buf;
if (len != sizeof(*rsp)) {
- wcn36xx_warn("Bad TX complete indication");
+ wcn36xx_warn("Bad TX complete indication\n");
return -EIO;
}
@@ -1385,10 +1385,10 @@ static int wcn36xx_smd_missed_beacon_ind(struct wcn36xx *wcn,
*/
if (wcn->is_suspended) {
wcn36xx_dbg(WCN36XX_DBG_HAL,
- "postpone connection lost notification");
+ "postpone connection lost notification\n");
wcn->is_con_lost_pending = true;
} else {
- wcn36xx_dbg(WCN36XX_DBG_HAL, "beacon missed");
+ wcn36xx_dbg(WCN36XX_DBG_HAL, "beacon missed\n");
ieee80211_connection_loss(vif);
}
@@ -1408,7 +1408,7 @@ static int wcn36xx_smd_delete_sta_context_ind(struct wcn36xx *wcn,
struct ieee80211_sta *sta;
if (len != sizeof(*rsp)) {
- wcn36xx_warn("Bad delete sta indication");
+ wcn36xx_warn("Bad delete sta indication\n");
return -EIO;
}
@@ -1418,7 +1418,7 @@ static int wcn36xx_smd_delete_sta_context_ind(struct wcn36xx *wcn,
sta = ieee80211_find_sta(vif, rsp->addr2);
if (sta) {
wcn36xx_dbg(WCN36XX_DBG_HAL,
- "delete station indication %pM", rsp->addr2);
+ "delete station indication %pM\n", rsp->addr2);
ieee80211_report_low_ack(sta, 0);
}
@@ -1490,7 +1490,7 @@ static void wcn36xx_smd_rsp_process(struct wcn36xx *wcn, void *buf, size_t len)
case WCN36XX_HAL_TRIGGER_BA_RSP:
case WCN36XX_HAL_UPDATE_CFG_RSP:
if (wcn36xx_smd_rsp_status_check(buf, len)) {
- wcn36xx_warn("error response from hal request %d",
+ wcn36xx_warn("error response from hal request %d\n",
msg_header->msg_type);
}
break;
@@ -1516,7 +1516,7 @@ static void wcn36xx_smd_rsp_process(struct wcn36xx *wcn, void *buf, size_t len)
wcn36xx_smd_delete_sta_context_ind(wcn, buf, len);
break;
default:
- wcn36xx_error("SMD_EVENT (%d) not supported",
+ wcn36xx_error("SMD_EVENT (%d) not supported\n",
msg_header->msg_type);
}
}
diff --git a/txrx.c b/txrx.c
index 973389d..8a6285e 100644
--- a/txrx.c
+++ b/txrx.c
@@ -57,7 +57,7 @@ int wcn36xx_rx_skb(struct wcn36xx *wcn, struct sk_buff *skb)
RX_FLAG_MMIC_STRIPPED |
RX_FLAG_DECRYPTED;
- wcn36xx_dbg(WCN36XX_DBG_RX, "status.flags=%x status->vendor_radiotap_len=%x",
+ wcn36xx_dbg(WCN36XX_DBG_RX, "status.flags=%x status->vendor_radiotap_len=%x\n",
status.flag, status.vendor_radiotap_len);
memcpy(IEEE80211_SKB_RXCB(skb), &status, sizeof(status));
@@ -67,12 +67,12 @@ int wcn36xx_rx_skb(struct wcn36xx *wcn, struct sk_buff *skb)
sn = IEEE80211_SEQ_TO_SN(__le16_to_cpu(hdr->seq_ctrl));
if (ieee80211_is_beacon(hdr->frame_control)) {
- wcn36xx_dbg(WCN36XX_DBG_BEACON, "beacon skb %p len %d fc %04x sn %d",
+ wcn36xx_dbg(WCN36XX_DBG_BEACON, "beacon skb %p len %d fc %04x sn %d\n",
skb, skb->len, fc, sn);
wcn36xx_dbg_dump(WCN36XX_DBG_BEACON_DUMP, "SKB <<< ",
(char *)skb->data, skb->len);
} else {
- wcn36xx_dbg(WCN36XX_DBG_RX, "rx skb %p len %d fc %04x sn %d",
+ wcn36xx_dbg(WCN36XX_DBG_RX, "rx skb %p len %d fc %04x sn %d\n",
skb, skb->len, fc, sn);
wcn36xx_dbg_dump(WCN36XX_DBG_RX_DUMP, "SKB <<< ",
(char *)skb->data, skb->len);
@@ -154,7 +154,7 @@ static void wcn36xx_set_tx_mgmt(struct wcn36xx_tx_bd *bd,
else if (ieee80211_is_ctl(hdr->frame_control))
bd->bd_rate = WCN36XX_BD_RATE_CTRL;
else
- wcn36xx_warn("frame control type unknown");
+ wcn36xx_warn("frame control type unknown\n");
/*
* In joining state trick hardware that probe is sent as
@@ -194,14 +194,14 @@ int wcn36xx_start_tx(struct wcn36xx *wcn,
* wierd. TODO: Recover from this situation
*/
- wcn36xx_error("bd address may not be NULL for BD DXE");
+ wcn36xx_error("bd address may not be NULL for BD DXE\n");
return -EINVAL;
}
memset(bd, 0, sizeof(*bd));
wcn36xx_dbg(WCN36XX_DBG_TX,
- "tx skb %p len %d fc %04x sn %d %s %s",
+ "tx skb %p len %d fc %04x sn %d %s %s\n",
skb, skb->len, __le16_to_cpu(hdr->frame_control),
IEEE80211_SEQ_TO_SN(__le16_to_cpu(hdr->seq_ctrl)),
is_low ? "low" : "high", bcast ? "bcast" : "ucast");
@@ -212,11 +212,11 @@ int wcn36xx_start_tx(struct wcn36xx *wcn,
bd->tx_comp = info->flags & IEEE80211_TX_CTL_REQ_TX_STATUS;
if (bd->tx_comp) {
- wcn36xx_dbg(WCN36XX_DBG_DXE, "TX_ACK status requested");
+ wcn36xx_dbg(WCN36XX_DBG_DXE, "TX_ACK status requested\n");
spin_lock_irqsave(&wcn->dxe_lock, flags);
if (wcn->tx_ack_skb) {
spin_unlock_irqrestore(&wcn->dxe_lock, flags);
- wcn36xx_warn("tx_ack_skb already set");
+ wcn36xx_warn("tx_ack_skb already set\n");
ieee80211_free_txskb(wcn->hw, skb);
return -EINVAL;
}
@@ -239,7 +239,7 @@ int wcn36xx_start_tx(struct wcn36xx *wcn,
* frame to nobody. Why?
*/
if (!sta_priv)
- wcn36xx_warn("Sending data packet to nobody");
+ wcn36xx_warn("Sending data packet to nobody\n");
wcn36xx_set_tx_data(bd, wcn, sta_priv, hdr, bcast);
wcn36xx_set_tx_pdu(bd,
ieee80211_is_data_qos(hdr->frame_control) ?
diff --git a/wcn36xx.h b/wcn36xx.h
index c718cb5..6504d57 100644
--- a/wcn36xx.h
+++ b/wcn36xx.h
@@ -54,17 +54,17 @@ enum wcn36xx_debug_mask {
};
#define wcn36xx_error(fmt, arg...) \
- printk(KERN_ERR pr_fmt("ERROR " fmt "\n"), ##arg);
+ printk(KERN_ERR pr_fmt("ERROR " fmt), ##arg);
#define wcn36xx_warn(fmt, arg...) \
- printk(KERN_WARNING pr_fmt("WARNING " fmt "\n"), ##arg)
+ printk(KERN_WARNING pr_fmt("WARNING " fmt), ##arg)
#define wcn36xx_info(fmt, arg...) \
- printk(KERN_INFO pr_fmt(fmt "\n"), ##arg)
+ printk(KERN_INFO pr_fmt(fmt), ##arg)
#define wcn36xx_dbg(mask, fmt, arg...) do { \
if (debug_mask & mask) \
- printk(KERN_DEBUG pr_fmt(fmt "\n"), ##arg); \
+ printk(KERN_DEBUG pr_fmt(fmt), ##arg); \
} while (0)
#define wcn36xx_dbg_dump(mask, prefix_str, buf, len) do { \
--
1.8.2.2
More information about the wcn36xx
mailing list