[PATCH 09/16] wcn36xx: Add smd.c

Eugene Krasnikov k.eugene.e at gmail.com
Wed Aug 21 03:58:39 EDT 2013


2013/8/20 Joe Perches <joe at perches.com>:
> On Tue, 2013-08-20 at 19:41 +0200, Eugene Krasnikov wrote:
>
>> diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
> []
>> +int wcn36xx_smd_load_nv(struct wcn36xx *wcn)
>> +{
> []
>> +             /* Add NV body itself */
>> +             /* Rework me */
>> +             memcpy(wcn->smd_buf + sizeof(msg_body),
>> +                    (void *)(&nv_d->table) + fm_offset,
>> +                    msg_body.nv_img_buffer_size);
>
> Does this really do what you want?
>
> Perhaps it should be:
>
>                 memcpy(wcn->smd_buf + sizeof(msg_body),
>                        ((void *)&nv_d->table) + fm_offset,
>                        msg_body.nv_img_buffer_size);
>

Yes, this line is working. Tested it for ARM. Do you see any potential
problems with this pointer operation?


-- 
Best regards,
Eugene



More information about the wcn36xx mailing list