[PATCH 3/3] Use writel/readl as it is available on x86

Eugene Krasnikov k.eugene.e at gmail.com
Tue Aug 20 09:11:11 EDT 2013


writel/readl_relaxed is no available on x86.
Also new checkpatch allows writel/readl.

Signed-off-by: Eugene Krasnikov <k.eugene.e at gmail.com>
---
 dxe.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/dxe.c b/dxe.c
index 13724c6..4cd325f 100644
--- a/dxe.c
+++ b/dxe.c
@@ -40,14 +40,12 @@ static void wcn36xx_dxe_write_register(struct wcn36xx *wcn, int addr, int data)
 		    "wcn36xx_dxe_write_register: addr=%x, data=%x",
 		    addr, data);
 
-	wmb();
-	writel_relaxed(data, wcn->mmio + addr);
+	writel(data, wcn->mmio + addr);
 }
 
 static void wcn36xx_dxe_read_register(struct wcn36xx *wcn, int addr, int *data)
 {
-	*data = readl_relaxed(wcn->mmio + addr);
-	rmb();
+	*data = readl(wcn->mmio + addr);
 
 	wcn36xx_dbg(WCN36XX_DBG_DXE,
 		    "wcn36xx_dxe_read_register: addr=%x, data=%x",
-- 
1.8.2.2




More information about the wcn36xx mailing list