[PATCH] Remove obsolete comments

Eugene Krasnikov k.eugene.e at gmail.com
Tue Aug 13 02:24:56 EDT 2013


Some TODO and FIXME comments are not valid any more.

Signed-off-by: Eugene Krasnikov <k.eugene.e at gmail.com>
---
 dxe.c  | 2 --
 main.c | 1 -
 smd.c  | 3 ---
 3 files changed, 6 deletions(-)

diff --git a/dxe.c b/dxe.c
index e0def82..8aa4323 100644
--- a/dxe.c
+++ b/dxe.c
@@ -140,7 +140,6 @@ int wcn36xx_dxe_alloc_ctl_blks(struct wcn36xx *wcn)
 	if (ret)
 		goto out_err;
 
-	/* TODO most probably do not need this */
 	/* Initialize SMSM state  Clear TX Enable RING EMPTY STATE */
 	ret = smsm_change_state(SMSM_APPS_STATE,
 		WCN36XX_SMSM_WLAN_TX_ENABLE,
@@ -629,7 +628,6 @@ int wcn36xx_dxe_tx_frame(struct wcn36xx *wcn,
 	ctl->skb = skb;
 	desc = ctl->desc;
 	if (ctl->bd_cpu_addr) {
-		/* TODO: Recover from this situation */
 		wcn36xx_error("bd_cpu_addr cannot be NULL for skb DXE");
 		return -EINVAL;
 	}
diff --git a/main.c b/main.c
index ad7b5ba..bac09cb 100644
--- a/main.c
+++ b/main.c
@@ -224,7 +224,6 @@ static int wcn36xx_start(struct ieee80211_hw *hw)
 		goto out_free_dxe_ctl;
 	}
 
-	/* TODO pass configuration to FW */
 	ret = wcn36xx_smd_load_nv(wcn);
 	if (ret) {
 		wcn36xx_error("Failed to push NV to chip");
diff --git a/smd.c b/smd.c
index 114566f..cf9360e 100644
--- a/smd.c
+++ b/smd.c
@@ -895,8 +895,6 @@ int wcn36xx_smd_config_bss(struct wcn36xx *wcn, struct ieee80211_vif *vif,
 	bss->ssid.length = wcn->ssid.length;
 	memcpy(bss->ssid.ssid, wcn->ssid.ssid, wcn->ssid.length);
 
-	/* FIXME: set rateset */
-
 	bss->obss_prot_enabled = 0;
 	bss->rmf = 0;
 	bss->max_probe_resp_retry_limit = 0;
@@ -1001,7 +999,6 @@ int wcn36xx_smd_send_beacon(struct wcn36xx *wcn, struct sk_buff *skb_beacon,
 	/* TODO need to find out why this is needed? */
 	msg_body.beacon_length = skb_beacon->len + 6;
 
-	/* TODO make this as a const */
 	if (BEACON_TEMPLATE_SIZE > msg_body.beacon_length) {
 		memcpy(&msg_body.beacon, &skb_beacon->len, sizeof(u32));
 		memcpy(&(msg_body.beacon[4]), skb_beacon->data,
-- 
1.8.2.2




More information about the wcn36xx mailing list