[PATCH 2/2] Remove debug_mask from debugfs
Eugene Krasnikov
k.eugene.e at gmail.com
Wed Aug 7 03:11:09 EDT 2013
debug_mask is available in /sys/module/wcn36xx/parameters/debug_mask
No need to add it to the debugfs.
Signed-off-by: Eugene Krasnikov <k.eugene.e at gmail.com>
---
debug.c | 41 -----------------------------------------
debug.h | 1 -
2 files changed, 42 deletions(-)
diff --git a/debug.c b/debug.c
index 1e18c9b..9565920 100644
--- a/debug.c
+++ b/debug.c
@@ -131,45 +131,6 @@ static const struct file_operations fops_wcn36xx_dump = {
.write = write_file_dump,
};
-static ssize_t read_file_debug_mask(struct file *file, char __user *user_buf,
- size_t count, loff_t *ppos)
-{
- char buf[32];
- unsigned int len;
-
- len = snprintf(buf, 32, "0x%08x\n", debug_mask);
-
- return simple_read_from_buffer(user_buf, count, ppos, buf, 2);
-}
-
-static ssize_t write_file_debug_mask(struct file *file,
- const char __user *user_buf,
- size_t count, loff_t *ppos)
-{
- unsigned long mask;
- char buf[32];
- ssize_t len;
-
- len = min(count, sizeof(buf) - 1);
- if (copy_from_user(buf, user_buf, len))
- return -EFAULT;
-
- buf[len] = '\0';
-
- if (kstrtoul(buf, 0, &mask))
- return -EINVAL;
-
- debug_mask = mask;
-
- return count;
-}
-
-static const struct file_operations fops_wcn36xx_debug_mask = {
- .open = wcn36xx_debugfs_open,
- .read = read_file_debug_mask,
- .write = write_file_debug_mask,
-};
-
#define ADD_FILE(name, mode, fop, priv_data) \
do { \
struct dentry *d; \
@@ -198,8 +159,6 @@ void wcn36xx_debugfs_init(struct wcn36xx *wcn)
ADD_FILE(bmps_switcher, S_IRUSR | S_IWUSR,
&fops_wcn36xx_bmps, wcn);
ADD_FILE(dump, S_IWUSR, &fops_wcn36xx_dump, wcn);
- ADD_FILE(debug_mask, S_IRUSR | S_IWUSR,
- &fops_wcn36xx_debug_mask, wcn);
}
void wcn36xx_debugfs_exit(struct wcn36xx *wcn)
diff --git a/debug.h b/debug.h
index 52770f2..207f187 100644
--- a/debug.h
+++ b/debug.h
@@ -37,7 +37,6 @@ struct wcn36xx_dfs_entry {
struct dentry *rootdir;
struct wcn36xx_dfs_file file_bmps_switcher;
struct wcn36xx_dfs_file file_dump;
- struct wcn36xx_dfs_file file_debug_mask;
};
void wcn36xx_debugfs_init(struct wcn36xx *wcn);
--
1.8.2.2
More information about the wcn36xx
mailing list