Initial Linux-wireless contribution

Kalle Valo kvalo at qca.qualcomm.com
Tue Aug 6 07:33:08 EDT 2013


Eugene Krasnikov <k.eugene.e at gmail.com> writes:

>> Why do we need dev there? That's not clear to me.
>
> for one single call : SET_IEEE80211_DEV(wcn->hw, wcn->pdata->dev);

Yes, we need a struct device. But why do we need to pass the struct
device through platform data? We should be using the struct device we
get from the probe function's argument.

>> Also the fact that the file is in arch/arm/mach-msm/include/mach/ might
>> make things difficult. We should be able to compile wcn36xx also on x86
>> but I'm not sure how that's possible now.
>
> It makes more sense to me to abstract from SMD as well.

SMD is a bus and I doubt that abstracting a bus interface through
platform data will fly in upstream.

-- 
Kalle Valo



More information about the wcn36xx mailing list