Initial Linux-wireless contribution

Kalle Valo kvalo at qca.qualcomm.com
Tue Aug 6 07:30:27 EDT 2013


Eugene Krasnikov <k.eugene.e at gmail.com> writes:

>>> With mmio I'm not sure. I was thinking that we would provide 'struct
>>> resource *wcnss_memory' instead so that we can do ioremap() in the probe
>>> and iounmap() in the remove. I think it's easier to manage allocations
>>> that way.
>>
>> Let me double check that. platform_device_add_resources must be use probably.
>
> Kalle, what is the idea behind calling ioremap/iounmap from wcn36xx
> but not from wcn36xx_msm module?
>
> From platform perspective tx,rx irq and memory are all resources. So
> or we let wcn36xx handle all resources or we let wcn36xx_msm handle
> resources. Under 'handle' i mean call of platform_get_resource_byname.
>
> I think that it is better to let  wcn36xx_msm to handle resources so
> that wcn36xx will deal with he final data.

wcn36xx_msm is just a temporary module, the proper way to manage this to
do it in the board files (arch/arm/mach-*). And they do not know when
wcn36xx is loaded or removed so the board files would need to always do
the resource allocation during boot.

-- 
Kalle Valo



More information about the wcn36xx mailing list