[PATCH 1/6] Change name of rates table

[Kalle Valo]

Olof Johansson <dev at skyshaper.net> writes:

>  /* 1,2,5.5,11 */
> -#define WCN36XX_HAL_NUM_11B_RATES           4
> +#define WCN36XX_HAL_NUM_DSSS_RATES           4
>
>  /* 6,9,12,18,24,36,48,54 */
> -#define WCN36XX_HAL_NUM_11A_RATES           8
> +#define WCN36XX_HAL_NUM_OFDM_RATES           8
>
>  /* 72,96,108 */
>  #define WCN36XX_HAL_NUM_POLARIS_RATES       3
> @@ -1026,8 +1026,8 @@ struct wcn36xx_hal_supported_rates {
>
>  	/* 11b, 11a and aniLegacyRates are IE rates which gives rate in
>  	 * unit of 500Kbps */
> -	u16 llb_rates[WCN36XX_HAL_NUM_11B_RATES];
> -	u16 lla_rates[WCN36XX_HAL_NUM_11A_RATES];
> +	u16 dsss_rates[WCN36XX_HAL_NUM_DSSS_RATES];
> +	u16 ofdm_rates[WCN36XX_HAL_NUM_OFDM_RATES];
>  	u16 legacy_rates[WCN36XX_HAL_NUM_POLARIS_RATES];
>  	u16 reserved;

The problem with changes like this (ie. changing terms) is that when
it's more difficult to compare with the firmware code. That's why I
would prefer to use the same HAL terms as the prima driver uses as much
as possible.

This change per se isn't a problem but just something to keep in mind in
the future.

-- 
Kalle Valo