speedtch speedtch.c,1.81,1.82

Duncan Sands baldrick at free.fr
Thu Jul 12 04:47:43 EDT 2007


On Wednesday 11 July 2007 14:55:20 David Woodhouse wrote:
> On Wed, 2007-07-11 at 13:36 +0100, Duncan Sands wrote:
> >         if (usb_dev->descriptor.bDeviceClass != USB_CLASS_VENDOR_SPEC) {
> > -               usb_err(usbatm, "%s: wrong device class %d\n", __func__, usb_dev->descriptor.bDeviceClass);
> > +               usb_err(usbatm, "%s: wrong device class %d\n", __func__,
> > +                       usb_dev->descriptor.bDeviceClass);
> >                 return -ENODEV; 
> 
> You're better off leaving those messages on a single line. They're
> neater that way.

They are neater that way, but awfully long.  Another solution would be
to factor some of this code out into another function, which would
reduce the amount of indentation.

Ciao,

Duncan.



More information about the Usbatm mailing list