[ATMSAR] Request for review - update #1

[matthieu castet]

Hi,

Giampaolo Tomassoni wrote:
> Dears,
> 

> Also, in order to allow you to evaluate it, I prepared a driver adopting the ATMSAR API for the Globespan Pulsar ADSL PCI card. 
>This driver is made after the one from Guy Ellis (see http://adsl4linux.no-ip.org/pulsar.html for further reference). 
>My version is a two-part driver: a GPL one ( http://www.tomassoni.biz/download/pulsar/pulsaradsl-1.0.1-source.tar.bz2 ) 
>and the same proprietary library you may find in the Ellis' driver from the above-mentioned URL.
> 
How could you mix GPL and proprietary library ?

In your ATM SAR lib you use EXPORT_SYMBOL_GPL. So how this proprietary 
module could use it ?

Otherwise I agree it could be a good idea to split atm and usb code from 
usb atm.


Matthieu