[PATCH] finish iso support

matthieu castet castet.matthieu at free.fr
Wed Jun 29 16:01:22 EDT 2005


Hi Duncan,

Duncan Sands wrote:
>>If I rename quirk attribute from quirk patch to option.
>>Could be acceptable to define a flag to tell usbatm we want iso ?
> 
> 
> Why can't it tell from the choice of endpoint?
In struct usbatm_driver we pass only the number of the endpoint.
Then in usbatm init, we convert this number into endpoint with 
usb_rcvbulkpipe macro.
We can't pass directly endpoint in struct usbatm_driver as we need 
struct usb_device for usb_rcvbulkpipe.

What need could do something like in usb_rcvbulkpipe to indicate if it 
is a bulk or iso pipe :
for bulk .in=(PIPE_BULK << 30) | number
for iso  .in=(PIPE_ISOCHRONOUS << 30) | number

With this usb_pipetype macros should work...

If we don't want to break the API, we could just add it for iso.

Is it ok ?

Thanks

Matthieu



More information about the Usbatm mailing list