[PATCH] finish iso support

Duncan Sands duncan.sands at math.u-psud.fr
Mon Jun 27 16:32:34 EDT 2005


Hi Matthieu,

> this patch aim to finish iso support in usbatm.

+module_param(rcv_buf_iso_packets, uint, S_IRUGO);
+MODULE_PARM_DESC(rcv_buf_iso_packets,
+                "Number of packets in a iso frame(range: 1-"
+                __MODULE_STRING(UDSL_MAX_RCV_ISO_PACKETS) ", default: "
+                __MODULE_STRING(UDSL_DEFAULT_RCV_ISO_PACKETS) ")");

can you please explain why you add this new parameter.

Also, what are your reasons for adding the use_iso field, rather than using
some other method.  Other methods:

(1) modify the struct usbatm_driver in the bind() call, setting the right
endpoint (in order for this to work properly, usbatm should use a copy of
the original struct usbatm_driver, but that's easy to arrange).

(2) supply usbatm_usb_probe with different values for struct usbatm_driver.

Thanks in advance for explaining your thinking!

Ciao,

Duncan.



More information about the Usbatm mailing list