Error in ATM_PHY_SIG_* logic on speedtch.c?

Duncan Sands duncan.sands at math.u-psud.fr
Wed Jun 15 04:43:05 EDT 2005


Hi Aurelio,

> Now speedtch.c use this:
>     0x00 => ATM_PHY_SIG_LOST
>     0x08 => ATM_PHY_SIG_UNKNOWN
>     0x10 => ATM_PHY_SIG_LOST
>     0x20 => ATM_PHY_SIG_FOUND
> 
> But at 0x10 you don't lost the sync...
> 
> And if you get  0x00, 0x08, 0x10, 0x00 you lost the state change and  
> speedtch_start_synchro isn't it call.
> 
> I use this logic too at amedyn.c so I have to change it too.
> 
> Store and check last modem state?

another possibility would be to use ATM_PHY_SIG_UNKNOWN for the 0x10
case.  But I reckon you are right: the best solution would be to store and
compare with the last state.  Want to code it up?

Ciao,

Duncan.



More information about the Usbatm mailing list