speedtch usbatm.h,1.4,1.5 usbatm2.c,1.13,1.14

Duncan Sands baldrick at free.fr
Sat Feb 12 09:35:00 EST 2005

Hi Roman,

> If it doesn't go in, I think we at least should remove that bogus kfree call
> in udsl_destroy_instance: a memleak is better than a probability of a
> crash.

which bogus kfree do you mean?  I see a kfree in udsl_destroy_instance,
but it looks fine to me...

For me the main problem with getting these changes into the kernel tree
is that they are not backwards compatible:
(1) the ioctl for signalling that firmware has been loaded from
userspace has gone.  It is still possible to load things from userspace,
by unbinding the kernel driver, loading the firmware, then rebinding it,
but the old modem_run method will no longer work.
(2) the ATM device is only created once the USB device is fully
initialized, not straight away like now.  This may cause trouble for
scripts.  What is more, the ATM layer does not yet support sysfs

> Besides, I think we need to make up a usbatm subtree buildable within
> the kernel, so that users of 2.6.1[01] could fetch it and replace the
> original contents of drivers/usb/atm.  I'll add Kconfig and
> Makefile.kernel to CVS, if you don't mind.


> > Sorry for the silence these last few
> > days: I've been recovering my system from major filesystem corruption
> Oh my, what a week!  David is still struggling to make
> lists.infradead.org visibile to the outside world after the ISP
> changeoverr; the lab I work at had a power outage, still not fully
> recovered, so my development machine was inaccessible for a while...
> Thanks God, it's already Friday!

The beginning of the working weekend!



More information about the Usbatm mailing list