speedtch Makefile, 1.12, 1.13 cxacru2.c, 1.3, 1.4 usbatm.h, 1.5, 1.6 usbatm2.c, 1.15, 1.16

matthieu castet castet.matthieu at free.fr
Thu Feb 3 16:17:01 EST 2005


Hi,
Roman Kagan wrote:
>   Hi Duncan,
> 
> FWIW here's a patch to the current CVS removing all the subdriver
> registration and making the subdriver's probe pass the pointer to struct
> usbatm_driver to the core.  Aren't you impressed by the diff stats:
> 
>  cxacru.c |   21 +++++++--------------
>  usbatm.c |   45 ++-------------------------------------------
>  usbatm.h |   10 ++--------
>  3 files changed, 11 insertions(+), 65 deletions(-)
> 
> (I didn't touch the speedtouch - not enough speed :)
> 
> And this way it becomes free from the deficiency inherited from
> usb-serial, where multiple subdrivers matching the same usb_device_id
> would ruin the registration stuff.
> 
> Cheers,
>   Roman.
> 
This week I am busy so I haven't time to look to your changes.

Some comments :
In the driver structure you could remove .owner and .id_table fields.
id is useless in usbatm_usb_probe.

Matthieu



More information about the Usbatm mailing list