speedtch usbatm.c,1.54,1.55

Duncan Sands duncan at infradead.org
Fri Nov 18 12:53:52 EST 2005


Update of /home/cvs/speedtch
In directory phoenix.infradead.org:/tmp/cvs-serv22421

Modified Files:
	usbatm.c 
Log Message:
Debug message for when an urb has a bad status.  Bring vendor/product output
format in line with that in /proc/bus/usb/devices.


Index: usbatm.c
===================================================================
RCS file: /home/cvs/speedtch/usbatm.c,v
retrieving revision 1.54
retrieving revision 1.55
diff -u -r1.54 -r1.55
--- usbatm.c	18 Nov 2005 10:35:04 -0000	1.54
+++ usbatm.c	18 Nov 2005 17:53:49 -0000	1.55
@@ -269,10 +269,13 @@
 
 	spin_unlock_irqrestore(&channel->lock, flags);
 
-	if (unlikely(urb->status))
+	if (unlikely(urb->status)) {
+		if (printk_ratelimit())
+			atm_warn(channel->usbatm, "%s: urb 0x%p failed (%d)!\n",
+				__func__, urb, urb->status);
 		/* throttle processing in case of an error */
 		mod_timer(&channel->delay, jiffies + msecs_to_jiffies(THROTTLE_MSECS));
-	else
+	} else
 		tasklet_schedule(&channel->tasklet);
 }
 
@@ -1052,7 +1055,7 @@
 	int i, length;
 	int need_heavy, flags;
 
-	dev_dbg(dev, "%s: trying driver %s with vendor=0x%x, product=0x%x, ifnum %d\n",
+	dev_dbg(dev, "%s: trying driver %s with vendor=%04x, product=%04x, ifnum %2d\n",
 			__func__, driver->driver_name,
 			le16_to_cpu(usb_dev->descriptor.idVendor),
 			le16_to_cpu(usb_dev->descriptor.idProduct),




More information about the Usbatm-commits mailing list