speedtch usbatm.c,1.31,1.32
Duncan Sands
duncan at infradead.org
Tue May 3 09:57:35 EDT 2005
Update of /home/cvs/speedtch
In directory phoenix.infradead.org:/tmp/cvs-serv970
Modified Files:
usbatm.c
Log Message:
Revert wrong list_add -> list_add_tail change (pointed out by Roman).
Index: usbatm.c
===================================================================
RCS file: /home/cvs/speedtch/usbatm.c,v
retrieving revision 1.31
retrieving revision 1.32
diff -u -r1.31 -r1.32
--- usbatm.c 3 May 2005 13:53:12 -0000 1.31
+++ usbatm.c 3 May 2005 13:57:32 -0000 1.32
@@ -241,7 +241,10 @@
/* consider all errors transient and return the buffer back to the queue */
spin_lock_irq(&channel->lock);
- list_add_tail(&trx->list, &channel->list);
+
+ /* must add to the front when sending; doesn't matter when receiving */
+ list_add(&trx->list, &channel->list);
+
spin_unlock_irq(&channel->lock);
/* make sure the channel doesn't stall */
@@ -262,7 +265,10 @@
/* usually in_interrupt(), but not always */
spin_lock_irqsave(&channel->lock, flags);
+
+ /* must add to the back when receiving; doesn't matter when sending */
list_add_tail(&trx->list, &channel->list);
+
spin_unlock_irqrestore(&channel->lock, flags);
if (unlikely(urb->status)) {
More information about the Usbatm-commits
mailing list