speedtch usbatm.c,1.26,1.27

Duncan Sands duncan at infradead.org
Tue May 3 05:34:37 EDT 2005


Update of /home/cvs/speedtch
In directory phoenix.infradead.org:/tmp/cvs-serv31965

Modified Files:
	usbatm.c 
Log Message:
Add failed urbs to the back of the list, not the front.  The second list_add
-> list_add_tail change is rather pointless, but it does mean that the
transceivers initially get fired in the order you expect, which may save a
some brain time when debugging.


Index: usbatm.c
===================================================================
RCS file: /home/cvs/speedtch/usbatm.c,v
retrieving revision 1.26
retrieving revision 1.27
diff -u -r1.26 -r1.27
--- usbatm.c	3 May 2005 08:41:56 -0000	1.26
+++ usbatm.c	3 May 2005 09:34:34 -0000	1.27
@@ -241,7 +241,7 @@
 
 		/* consider all errors transient and return the buffer back to the queue */
 		spin_lock_irq(&channel->lock);
-		list_add(&trx->list, &channel->list);
+		list_add_tail(&trx->list, &channel->list);
 		spin_unlock_irq(&channel->lock);
 
 		/* make sure the channel doesn't stall */
@@ -260,7 +260,7 @@
 	vdbg("%s: urb 0x%p, status %d, actual_length %d, trx 0x%p",
 	     __func__, urb, urb->status, urb->actual_length, trx);
 
-	/* may be in_interrupt() */
+	/* usually in_interrupt(), but not always */
 	spin_lock_irqsave(&channel->lock, flags);
 	list_add_tail(&trx->list, &channel->list);
 	spin_unlock_irqrestore(&channel->lock, flags);
@@ -1085,7 +1085,7 @@
 
 		/* put all tx URBs on the list of spares */
 		if (i >= num_rcv_urbs)
-			list_add(&trx->list, &trx->channel->list);
+			list_add_tail(&trx->list, &trx->channel->list);
 
 		vdbg("%s: alloced trx 0x%p buffer 0x%p buf size %u urb 0x%p",
 		     __func__, trx, trx->urb->transfer_buffer, trx->urb->transfer_buffer_length, trx->urb);




More information about the Usbatm-commits mailing list