speedtch speedtch.c,1.46,1.47

Duncan Sands duncan at infradead.org
Fri Apr 15 04:58:59 EDT 2005


Update of /home/cvs/speedtch
In directory phoenix.infradead.org:/tmp/cvs-serv8190

Modified Files:
	speedtch.c 
Log Message:
We are no longer going to support the IOCTL from userspace.  If someone
wants to do userspace firmware loading, then they should grab the firmware
interface (maybe bumping off the module), upload the firmware, then rebind
the module.  This can all be done using usbfs.


Index: speedtch.c
===================================================================
RCS file: /home/cvs/speedtch/speedtch.c,v
retrieving revision 1.46
retrieving revision 1.47
diff -u -r1.46 -r1.47
--- speedtch.c	15 Apr 2005 08:50:45 -0000	1.46
+++ speedtch.c	15 Apr 2005 08:58:54 -0000	1.47
@@ -43,7 +43,7 @@
 
 static const char speedtch_driver_name[] = "speedtch";
 
-/* Timeout in jiffies */
+/* Timeout in milliseconds */
 #define CTRL_TIMEOUT 2000
 #define DATA_TIMEOUT 2000
 
@@ -83,9 +83,6 @@
 		 "Enable software buffering (default: "
 		 __MODULE_STRING(SPEEDTCH_DEFAULT_SW_BUFFERING) ")");
 
-#define UDSL_IOCTL_LINE_UP		1
-#define UDSL_IOCTL_LINE_DOWN		2
-
 #define SPEEDTCH_ENDPOINT_INT		0x81
 #define SPEEDTCH_ENDPOINT_DATA		0x07
 #define SPEEDTCH_ENDPOINT_FIRMWARE	0x05
@@ -605,31 +602,6 @@
 //**  USB  **
 //**********/
 //
-//static int speedtch_usb_ioctl(struct usb_interface *intf, unsigned int code,
-//			      void *user_data)
-//{
-//	struct speedtch_instance_data *instance = usb_get_intfdata(intf);
-//
-//	dbg("speedtch_usb_ioctl entered");
-//
-//	if (!instance) {
-//		dbg("speedtch_usb_ioctl: NULL instance!");
-//		return -ENODEV;
-//	}
-//
-//	switch (code) {
-//	case UDSL_IOCTL_LINE_UP:
-//		instance->u.atm_dev->signal = ATM_PHY_SIG_FOUND;
-//		speedtch_got_firmware(instance, 1);
-//		return (instance->u.status == UDSL_LOADED_FIRMWARE) ? 0 : -EIO;
-//	case UDSL_IOCTL_LINE_DOWN:
-//		instance->u.atm_dev->signal = ATM_PHY_SIG_LOST;
-//		return 0;
-//	default:
-//		return -ENOTTY;
-//	}
-//}
-//
 //static int speedtch_usb_probe(struct usb_interface *intf,
 //			      const struct usb_device_id *id)
 //{




More information about the Usbatm-commits mailing list