[PATCH] alx: Don't check netif_running() on resume

[Adrian Chadd]

So the consensus is "merge" ?



adrian


On 24 April 2013 19:52, Huang, Xiong <xiong at qca.qualcomm.com> wrote:
>> >
>> > Hi Tim
>> >
>> >      Alx_open will do same thing when this interface is 'up'. So just leave it as it,
>> if this interface status is 'down' when resume.
>> >
>> > Best Regards,
>> > Xiong
>> >
>>
>> Try this under Ubuntu and see how well it works for you. pm-suspend works fine,
>> but once you get the network stack involved via network manager it doesn't
>> work so well.
>>
>> I looked at e1000 as an example.
>>
> Yes,  for e1000 code, there is no such running status check.
> I still have no idea how network manager causes it abnormal, I haven't Ubutun on hand to try :(
> Maybe this is the cause for ehtX not working after supend/resume (need 'if up' again to restore).
>
> Anyway, this patch seems no harm to anything.
>
> Thanks
> Xiong
>
> _______________________________________________
> unified-drivers mailing list
> unified-drivers at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/unified-drivers