[PATCH] alx: Don't check netif_running() on resume
Huang, Xiong
xiong at qca.qualcomm.com
Wed Apr 24 16:09:31 EDT 2013
> Sent: Thursday, April 25, 2013 2:30 AM
> To: unified-drivers at lists.infradead.org
> Cc: Tim Gardner
> Subject: [PATCH] alx: Don't check netif_running() on resume
>
> The resume function must power up the device regardless of the state of the
> network stack.
>
> Signed-off-by: Tim Gardner <tim.gardner at canonical.com>
> ---
> src/alx_main.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/src/alx_main.c b/src/alx_main.c index 7fe3f4b..c2606eb 100644
> --- a/src/alx_main.c
> +++ b/src/alx_main.c
> @@ -1693,9 +1693,6 @@ static int alx_resume(struct device *dev)
> struct alx_hw *hw = &adpt->hw;
> int err;
>
> - if (!netif_running(netdev))
> - return 0;
> -
Hi Tim
Alx_open will do same thing when this interface is 'up'. So just leave it as it, if this interface status is 'down' when resume.
Best Regards,
Xiong
More information about the unified-drivers
mailing list