[PATCH] alx: revise self-test flag for external loopback

[Chadd, Adrian]

So this is the final patch?



Adrian


-----Original Message-----
From: unified-drivers [mailto:unified-drivers-bounces at lists.infradead.org] On Behalf Of xiong
Sent: Wednesday, April 03, 2013 4:55 PM
To: adrian at freebsd.org
Cc: Huang, Xiong; mcgrof at kernel.org; unified-drivers at lists.infradead.org
Subject: [PATCH] alx: revise self-test flag for external loopback

in previous code, etest->flag is
(ETH_TEST_FL_OFFLINE | ETH_TEST_FL_EXTERNAL_LB), for command 'ethtool -t ethX external_lb'.
and the bug-code cause external loopback wouldn't be excuted.
revising the flag condition sentence from '==' to "&' to fix this bug.


Signed-off-by: xiong <xiong at qca.qualcomm.com>
Tested-by: Wu, Ken <kenw at qca.qualcomm.com>
---
 src/alx_ethtool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/alx_ethtool.c b/src/alx_ethtool.c index 074c640..8c73790 100644
--- a/src/alx_ethtool.c
+++ b/src/alx_ethtool.c
@@ -1695,7 +1695,7 @@ static void alx_self_test(struct net_device *netdev,
 	if (if_running)
 		dev_close(netdev);
 
-	if (etest->flags == ETH_TEST_FL_OFFLINE) {
+	if (etest->flags & ETH_TEST_FL_OFFLINE) {
 		netif_info(adpt, hw, adpt->netdev,  "offline test start...\n");
 
 		if (alx_diag_register(adpt, &data[0]))
--
1.8.0.msysgit.0


_______________________________________________
unified-drivers mailing list
unified-drivers at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/unified-drivers