[PATCH] alx: revise self-test flag for external loopback

[Huang, Xiong]

> 
> On Wed, Apr 03, 2013 at 06:22:05PM -0700, Huang, Xiong wrote:
> > It's a self-test function which could be trigged by ethtool.
> 
> Who would run this?
> 
The OEM customer  will use it,
and end user who encounter something abnormal may run it too.

> > At run time, or
> > normal data path of rx/tx, those codes won't be excuted.
> 
> OK so we don't need this as a stable fix for users?
>

I don't think so, we may ask the end user to run it when issue appear,
For OEM customer, they need run it  in the factory before formal sale.
And this function can't be achieved without the driver help.


> > There is a standard interface set for ethtool, the user use it to
> > enable/disable some features such as TSO, checksum offload...  Dump
> > chip specific registers, statistics, diagnostic (self test) , and so on...
> 
> Can you clarify all this on the commit log then ?
> 

I thought these functions were well-known, I haven't seen a NIC without  ethtool interface in upstreamed driver :)
I will add it to the commit log soon.


Thanks
Xiong