[PATCH] alx: revise self-test flag for external loopback

[Huang, Xiong]

It's a self-test function which could be trigged by ethtool.
At run time, or normal data path of rx/tx, those codes won't be excuted.


There is a standard interface set for ethtool, the user use it to enable/disable some features such as TSO, checksum offload...
Dump chip specific registers, statistics, diagnostic (self test) , and so on...

Thanks
Xiong 

> -----Original Message-----
> From: Rodriguez, Luis
> Sent: Thursday, April 04, 2013 8:40 AM
> To: Huang, Xiong
> Cc: adrian at freebsd.org; mcgrof at kernel.org; unified-
> drivers at lists.infradead.org
> Subject: Re: [PATCH] alx: revise self-test flag for external loopback
> 
> On Thu, Apr 04, 2013 at 07:54:40AM +0800, xiong wrote:
> > in previous code, etest->flag is
> > (ETH_TEST_FL_OFFLINE | ETH_TEST_FL_EXTERNAL_LB), for command
> 'ethtool
> > -t ethX external_lb'.
> > and the bug-code cause external loopback wouldn't be excuted.
> > revising the flag condition sentence from '==' to "&' to fix this bug.
> 
> Is this a run time user thing or an OEM / vendor tool thing? Its still not clear to
> me if I need to apply it to stable for users.
> 
>   Luis