[PATCH] alx: revise self-test flag for external loopback

[Luis R. Rodriguez]

On Wed, Apr 03, 2013 at 12:27:23PM +0800, xiong wrote:
> the issue will cause the external loopback can't be excuted,
> revise the test flag to fix it.
> 
> Signed-off-by: xiong <xiong at qca.qualcomm.com>
> Tested-by: Wu, Ken <kenw at qca.qualcomm.com>
> ---
>  src/alx_ethtool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/alx_ethtool.c b/src/alx_ethtool.c
> index 074c640..8c73790 100644
> --- a/src/alx_ethtool.c
> +++ b/src/alx_ethtool.c
> @@ -1695,7 +1695,7 @@ static void alx_self_test(struct net_device *netdev,
>  	if (if_running)
>  		dev_close(netdev);
>  
> -	if (etest->flags == ETH_TEST_FL_OFFLINE) {
> +	if (etest->flags & ETH_TEST_FL_OFFLINE) {
>  		netif_info(adpt, hw, adpt->netdev,  "offline test start...\n");
>  

What is this fixing? Does this need to be applied to the
stable branches? Please expand your commit log to explain
the impact. If there is no impact you can do this to be
clear after the commit log, after the three dash lines "---"
to clearify to developers this. This message then would not be
included as part of the commit log message and I would then
not have to ask you via e-mail to clarify.

  Luis