[PATCH] alx: revise self-test flag for external loopback

Huang, Xiong xiong at qca.qualcomm.com
Wed Apr 3 00:28:59 EDT 2013


Hi adrian, I also attach a separate patch file for your convenience.

Thanks
Xiong

> -----Original Message-----
> From: Huang, Xiong
> Sent: Wednesday, April 03, 2013 12:27 PM
> To: adrian at freebsd.org
> Cc: mcgrof at kernel.org; unified-drivers at lists.infradead.org; Huang, Xiong
> Subject: [PATCH] alx: revise self-test flag for external loopback
> 
> the issue will cause the external loopback can't be excuted, revise the test
> flag to fix it.
> 
> Signed-off-by: xiong <xiong at qca.qualcomm.com>
> Tested-by: Wu, Ken <kenw at qca.qualcomm.com>
> ---
>  src/alx_ethtool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/alx_ethtool.c b/src/alx_ethtool.c index 074c640..8c73790
> 100644
> --- a/src/alx_ethtool.c
> +++ b/src/alx_ethtool.c
> @@ -1695,7 +1695,7 @@ static void alx_self_test(struct net_device *netdev,
>  	if (if_running)
>  		dev_close(netdev);
> 
> -	if (etest->flags == ETH_TEST_FL_OFFLINE) {
> +	if (etest->flags & ETH_TEST_FL_OFFLINE) {
>  		netif_info(adpt, hw, adpt->netdev,  "offline test start...\n");
> 
>  		if (alx_diag_register(adpt, &data[0]))
> --
> 1.8.0.msysgit.0

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-alx-revise-self-test-flag-for-external-loopback.patch
Type: application/octet-stream
Size: 940 bytes
Desc: 0001-alx-revise-self-test-flag-for-external-loopback.patch
URL: <http://lists.infradead.org/pipermail/unified-drivers/attachments/20130403/01dbbad7/attachment.obj>


More information about the unified-drivers mailing list