[Pcsclite-muscle] New version of pcsc-lite: 2.3.1

[Greg Troxel]

Ludovic Rousseau <ludovic.rousseau at gmail.com> writes:

> Le ven. 27 déc. 2024 à 16:01, Greg Troxel <gdt at lexort.com> a écrit :
>> My diff is wrong, but I think the basic concept, of only compiling the
>> peercred-using IsClientAuthorized if both polkit is present and there is
>> one or the other PEERCRED define is present, is sound.
>
> The idea is to explicitly fail if polkit is enabled but
> IsClientAuthorized() can't use it.
> In that case the choice is to disable polkit, instead of silently ignore it.

Thanks.  I did not come to understand that this was intentional from the
comments :-)

It would be nice to give the plan, 
to make it easier for someone trying to figure out what to do.  As it
is, it requires figuring out the intent, and then that polkit is used
only for this, not something else.  The README gives options but doesn't
list enable/disable polkit, and doesn't explain.  I don't mean to demand
you do anything - just giving a trip report from a packager doing an
update labeled micro (which turned out to have breaking changes).

It would also be nice to label the else/endif with commented copies of
the if conditions.  Of course I can figure that out but with nested ifs
and not understanding the intent, I think it would help others.

The use of FreeBSD ifdef is unfortunate, vs the sockopt showing up in
the header. I mean to still have the if, but instead of on FreeBSD be on
LOCAL_PEERCRED, assuming that it's an API that may be elsewhere.
It is very likely LOCAL_PEERCRED works on DragonFly, and it might well
show up in other BSDs at some point.