[Pcsclite-muscle] New version of pcsc-lite: 2.3.1

[Ludovic Rousseau]

Hello Greg,

Le ven. 27 déc. 2024 à 13:25, Greg Troxel <gdt at lexort.com> a écrit :
>
> Thanks for the update.  I used to use smartcards at work, and have kept
> updating pcsc stuff in pkgsrc partly for old times sake and partly
> because I think I might be using them again someday.
>
> I had a few wrinkles updating pgksrc to 2.3.1 from 2.3.0
>
> * polkit being present threw an error
>
> Building on NetBSD under pkgsrc, where polkit is provided:
>
> ===> Building for pcsc-lite-2.3.1
> ninja: Entering directory `output'
> [18/57] Compiling C object pcscd.p/src_auth.c.o
> FAILED: pcscd.p/src_auth.c.o
> gcc -Ipcscd.p -I. -I.. -I../src -I../src/PCSC -I/usr/pkg/include/libusb-1.0 -I/usr/pkg/include/polkit-1 -I/usr/pkg/include -I/usr/pkg/include/glib-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include/gio-unix-2.0 -I/usr/include -I/usr/pkg/include/python3.12 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -fvisibility=hidden -O2 -pthread -DPCSCD -MD -MQ pcscd.p/src_auth.c.o -MF pcscd.p/src_auth.c.o.d -o pcscd.p/src_auth.c.o -c ../src/auth.c
> ../src/auth.c:185:2: error: #error polkit is enabled, but no socket cred implementation for this platform
>   185 | #error polkit is enabled, but no socket cred implementation for this platform
>       |  ^~~~~
> [21/57] Compiling C object libpcsclite.a.p/src_winscard_clnt.c.o
> ninja: build stopped: subcommand failed.
>
> I get where you are coming from, but it seems better to build as if
> polkit is not there, basically requiring both tests to enable the
> feature.
>
> When hiding polkit, it built.
>
> Did pcsc-lite used to actually use polkit?

Polkit is used since 2014 and is enabled by default since Nov 2023.

Support of FreeBSD was added in
https://github.com/LudovicRousseau/PCSC/commit/19d0b26402a3d584186ff28d4c528382d7fd1a5e
But it looks like NetBSD do not have LOCAL_PEERCRED.
A patch is welcome.

> * default file is in a linuxy place
>
> ERROR: The following files are in /tmp/work/security/pcsc-lite/work/.destdir/usr/pkg but not in the PLIST:
> ERROR:         /tmp/work/security/pcsc-lite/work/.destdir/usr/pkg/etc/default/pcscd
>
> so perhaps should only be installed on GNU/Linux.   It's not clear if
> this is a file that actually *sets* defaults that should be read, or an
> example that someone could copy, or if pcsd-lite now tries to read from
> this path before reading from a more standard config file location
> within $prefix.
>
> pkgsrc, when building to /usr/pkg expects config files to be in
> /usr/pkg/etc/foo.conf or /usr/pkg/etc/foo/whatever.conf).
>
> It's also not clear to me if this file is meant to be edited by the
> sysadmin, in which case it isn't really "default" so much as the system
> config, perhaps read before a user config.
>
>
> The big question for me is: did anything change about config file
> placement/reading other than installing this file?   If not, I can just
> not install it and do the update, and if so, I don't feel that I can
> commit the update without untangling the config file location/reading.

This file is supposed to be used/read by the launching system (systemd
for example).
It is NOT used by pcscd. But it defines environment variables used by pcscd.
It is supposed to be edited by the local admin.

If you do not have an equivalent on NetBSD you can ignore it.

Bye

-- 
 Dr. Ludovic Rousseau