[Pcsclite-muscle] SCardControl() should return SCARD_E_INSUFFICIENT_BUFFER similar to SCardTransmit()

[Ludovic Rousseau]

2017-02-17 20:24 GMT+01:00 Maximilian Stein <maximilian.stein at secunet.com>:

> Hello,
>

Hello,


>
> I think SCardControl() should work similar to SCardTransmit() regarding
> client application buffer size as in commit [1]. Depending on the
> underlying IFD handler the current implementation might cause the same
> incorrect behaviour as described in [1].
>
> If the underlying IFD Handler is not correctly checking the buffer size,
> the current implementation could even cause a buffer overflow in the
> client application.
>
> The attached patch solves this similar to the fix in [1].
>
>
> Kind regards
> Maximilian Stein
>
> [1] 8eb9ea1b354b050f997d003cf3b0c5b56f29f9f7 - SCardTransmit() may
> return SCARD_E_INSUFFICIENT_BUFFER
>
>
You are right.
Patch applied in
https://github.com/LudovicRousseau/PCSC/commit/09cf6c7de55f1b4ab1d8a3f86c7a56d7a8621538

Thanks

-- 
 Dr. Ludovic Rousseau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pcsclite-muscle/attachments/20170228/8cc00d40/attachment.html>