[Pcsclite-muscle] Bug in reconnecting to a card.
Abraham Macias Paredes
amacias
Fri Sep 23 03:45:07 PDT 2016
Hi PCSC lite Project people,
I?m developing a software that nowadays is not stable (my software is
buggy), but I detected that a bug in my software causes a bug in pcsc-lite.
The ?SCardReconnect? doesn?t check if the connection has a transaction
opened. So if you open a transtaction and reconnects the transaction is
still opened. And also you can open a new transaction.
Check this sample code:
#ifdef WIN32
#undef UNICODE
#endif
#include <stdio.h>
#include <stdlib.h>
#ifdef __APPLE__
#include <PCSC/winscard.h>
#include <PCSC/wintypes.h>
#else
#include <winscard.h>
#endif
#ifdef WIN32
static char *pcsc_stringify_error(LONG rv)
{
static char out[20];
sprintf_s(out, sizeof(out), "0x%08X", rv);
return out;
}
#endif
#define CHECK(f, rv) \
if (SCARD_S_SUCCESS != rv) \
{ \
printf(f ": %s\n", pcsc_stringify_error(rv)); \
return -1; \
}
int main(void)
{
LONG rv;
SCARDCONTEXT hContext;
LPTSTR mszReaders;
SCARDHANDLE hCard;
DWORD dwReaders, dwActiveProtocol, dwRecvLength;
SCARD_IO_REQUEST pioSendPci;
BYTE pbRecvBuffer[258];
BYTE cmd1[] = { 0x00, 0xA4, 0x04, 0x00, 0x0A, 0xA0,
0x00, 0x00, 0x00, 0x62, 0x03, 0x01, 0x0C, 0x06, 0x01 };
BYTE cmd2[] = { 0x00, 0x00, 0x00, 0x00 };
unsigned int i;
rv = SCardEstablishContext(SCARD_SCOPE_SYSTEM, NULL, NULL, &hContext);
CHECK("SCardEstablishContext", rv)
#ifdef SCARD_AUTOALLOCATE
dwReaders = SCARD_AUTOALLOCATE;
rv = SCardListReaders(hContext, NULL, (LPTSTR)&mszReaders, &dwReaders);
CHECK("SCardListReaders", rv)
#else
rv = SCardListReaders(hContext, NULL, NULL, &dwReaders);
CHECK("SCardListReaders", rv)
mszReaders = calloc(dwReaders, sizeof(char));
rv = SCardListReaders(hContext, NULL, mszReaders, &dwReaders);
CHECK("SCardListReaders", rv)
#endif
printf("reader name: %s\n", mszReaders);
printf("SCardConnect\n");
rv = SCardConnect(hContext, mszReaders, SCARD_SHARE_SHARED,
SCARD_PROTOCOL_T0 | SCARD_PROTOCOL_T1, &hCard, &dwActiveProtocol);
CHECK("SCardConnect", rv)
printf("hCard = %08x\n",hCard);
printf("First SCardBeginTransaction\n");
rv = SCardBeginTransaction(hCard);
CHECK("SCardBeginTransaction", rv)
printf("First SCardReconnect\n");
rv = SCardReconnect(hCard, SCARD_SHARE_SHARED,
SCARD_PROTOCOL_T0 | SCARD_PROTOCOL_T1, SCARD_LEAVE_CARD,
&dwActiveProtocol);
CHECK("SCardReconnect", rv)
printf("hCard = %08x\n",hCard);
printf("Second SCardBeginTransaction\n");
rv = SCardBeginTransaction(hCard);
CHECK("SCardBeginTransaction", rv)
printf("SCardEndTransaction\n");
rv = SCardEndTransaction(hCard, SCARD_LEAVE_CARD);
CHECK("SCardEndTransaction", rv)
printf("SCardEstablishContext --- \n");
rv = SCardEstablishContext(SCARD_SCOPE_SYSTEM, NULL, NULL, &hContext);
CHECK("SCardEstablishContext", rv)
printf("SCardConnect to the new context\n");
rv = SCardConnect(hContext, mszReaders, SCARD_SHARE_SHARED,
SCARD_PROTOCOL_T0 | SCARD_PROTOCOL_T1, &hCard, &dwActiveProtocol);
CHECK("SCardConnect", rv)
printf("Connected OK!\n");
rv = SCardDisconnect(hCard, SCARD_LEAVE_CARD);
CHECK("SCardDisconnect", rv)
#ifdef SCARD_AUTOALLOCATE
rv = SCardFreeMemory(hContext, mszReaders);
CHECK("SCardFreeMemory", rv)
#else
free(mszReaders);
#endif
rv = SCardReleaseContext(hContext);
CHECK("SCardReleaseContext", rv)
return 0;
}
The output of this code is:
reader name: C3PO LTC31 v2 (17070129) 00 00
SCardConnect
hCard = 761d7d91
First SCardBeginTransaction
First SCardReconnect
hCard = 761d7d91
Second SCardBeginTransaction
SCardEndTransaction
SCardEstablishContext ---
SCardConnect to the new context
I think that the problem could be in ?readerfactory.c? in the
?RFCheckSharing? function:
LONG RFCheckSharing(SCARDHANDLE hCard, READER_CONTEXT * rContext)
{
if (rContext->hLockId == 0 || rContext->hLockId == hCard)
return SCARD_S_SUCCESS;
else
return SCARD_E_SHARING_VIOLATION;
}
This code only checks the card handle, that is the same for the
?reconnection?. So you can begin several transactions in the same card.
I added a debug line to see the LockCount:
00000004 pcscdaemon.c:134:SVCServiceRunLoop() A new context thread creation
is requested: 12
00005871 winscard_svc.c:331:ContextThread() Authorized PC/SC client
00000017 winscard_svc.c:335:ContextThread() Thread is started:
dwClientID=12, threadContext @0x2408d00
00000010 winscard_svc.c:353:ContextThread() Received command: CMD_VERSION
from client 12
00000005 winscard_svc.c:365:ContextThread() Client is protocol version 4:3
00000003 winscard_svc.c:385:ContextThread() CMD_VERSION rv=0x0 for client 12
00000035 winscard_svc.c:353:ContextThread() Received command:
ESTABLISH_CONTEXT from client 12
00000012 winscard.c:215:SCardEstablishContext() Establishing Context:
0x76FF5983
00000004 winscard_svc.c:446:ContextThread() ESTABLISH_CONTEXT rv=0x0 for
client 12
00000016 winscard_svc.c:353:ContextThread() Received command:
CMD_GET_READERS_STATE from client 12
00000093 winscard_svc.c:353:ContextThread() Received command: CONNECT from
client 12
00002777 winscard_svc.c:484:ContextThread() Authorized client for 'C3PO
LTC31 v2 (17070129) 00 00'
00000011 winscard.c:257:SCardConnect() Attempting Connect to C3PO LTC31 v2
(17070129) 00 00 using protocol: 3
00000004 readerfactory.c:768:RFReaderInfo() RefReader() count was: 1
00000003 winscard.c:352:SCardConnect() powerState: POWER_STATE_INUSE
00000003 prothandler.c:110:PHSetProtocol() Attempting PTS to T=0
00000005 ifdhandler.c:682:IFDHSetProtocolParameters() protocol T=0,
usb:0783/0006:libudev:0:/dev/bus/usb/001/003 (lun: 0)
00000003 ifdhandler.c:2047:extra_egt() Extra EGT patch applied
00023748 winscard.c:431:SCardConnect() Active Protocol: T=0
00000033 winscard.c:451:SCardConnect() hCard Identity: 761d7d91
00000006 winscard.c:512:SCardConnect() UnrefReader() count was: 2
00000005 winscard_svc.c:498:ContextThread() CONNECT rv=0x0 for client 12
00000068 winscard_svc.c:353:ContextThread() Received command:
BEGIN_TRANSACTION from client 12
00000007 readerfactory.c:795:RFReaderInfoById() RefReader() count was: 1
00000003 readerfactory.c:955:RFLockSharing() BEGIN
00000003 readerfactory.c:962:RFLockSharing() Card: 761d7d91 LockCount: 1
00000003 readerfactory.c:966:RFLockSharing() END
00000003 winscard.c:1104:SCardBeginTransaction() Status: 0x00000000
00000002 winscard.c:1107:SCardBeginTransaction() UnrefReader() count was: 2
00000003 winscard_svc.c:550:ContextThread() BEGIN_TRANSACTION rv=0x0 for
client 12
00000017 winscard_svc.c:353:ContextThread() Received command: RECONNECT from
client 12
00000005 winscard.c:526:SCardReconnect() Attempting reconnect to token.
00000002 readerfactory.c:795:RFReaderInfoById() RefReader() count was: 1
00000003 winscard.c:725:SCardReconnect() Active Protocol: T=0
00000013 winscard.c:815:SCardReconnect() UnrefReader() count was: 2
00000003 winscard_svc.c:517:ContextThread() RECONNECT rv=0x0 for client 12
00000019 winscard_svc.c:353:ContextThread() Received command:
BEGIN_TRANSACTION from client 12
00000004 readerfactory.c:795:RFReaderInfoById() RefReader() count was: 1
00000003 readerfactory.c:955:RFLockSharing() BEGIN
00000002 readerfactory.c:962:RFLockSharing() Card: 761d7d91 LockCount: 2
00000002 readerfactory.c:966:RFLockSharing() END
00000003 winscard.c:1104:SCardBeginTransaction() Status: 0x00000000
00000002 winscard.c:1107:SCardBeginTransaction() UnrefReader() count was: 2
00000003 winscard_svc.c:550:ContextThread() BEGIN_TRANSACTION rv=0x0 for
client 12
00000014 winscard_svc.c:353:ContextThread() Received command:
END_TRANSACTION from client 12
00000005 readerfactory.c:795:RFReaderInfoById() RefReader() count was: 1
00000002 readerfactory.c:974:RFUnlockSharing() BEGIN
00000003 readerfactory.c:982:RFUnlockSharing() Card: 761d7d91 LockCount: 1
00000002 readerfactory.c:994:RFUnlockSharing() END
00000003 winscard.c:1247:SCardEndTransaction() Status: 0x00000000
00000002 winscard.c:1250:SCardEndTransaction() UnrefReader() count was: 2
00000003 winscard_svc.c:566:ContextThread() END_TRANSACTION rv=0x0 for
client 12
00009089 winscard_msg_srv.c:253:ProcessEventsServer() Common channel packet
arrival
00000016 winscard_msg_srv.c:265:ProcessEventsServer()
ProcessCommonChannelRequest detects: 14
00000004 pcscdaemon.c:134:SVCServiceRunLoop() A new context thread creation
is requested: 14
00003876 winscard_svc.c:331:ContextThread() Authorized PC/SC client
00000011 winscard_svc.c:335:ContextThread() Thread is started:
dwClientID=14, threadContext @0x2412cf0
00000007 winscard_svc.c:353:ContextThread() Received command: CMD_VERSION
from client 14
00000004 winscard_svc.c:365:ContextThread() Client is protocol version 4:3
00000003 winscard_svc.c:385:ContextThread() CMD_VERSION rv=0x0 for client 14
00000015 winscard_svc.c:353:ContextThread() Received command:
ESTABLISH_CONTEXT from client 14
00000005 winscard.c:215:SCardEstablishContext() Establishing Context:
0x2F00BA9
00000002 winscard_svc.c:446:ContextThread() ESTABLISH_CONTEXT rv=0x0 for
client 14
00000019 winscard_svc.c:353:ContextThread() Received command: CONNECT from
client 14
00004487 winscard_svc.c:484:ContextThread() Authorized client for 'C3PO
LTC31 v2 (17070129) 00 00'
00000013 winscard.c:257:SCardConnect() Attempting Connect to C3PO LTC31 v2
(17070129) 00 00 using protocol: 3
00000004 readerfactory.c:768:RFReaderInfo() RefReader() count was: 1
00000003 winscard.c:294:SCardConnect() Waiting for release of lock
Thanks and best regards!
Abraham Mac?as Paredes
Analista / Programador
Departamento de Desarrollo y Soluciones
amacias at solutia-it.es <mailto:amacias at solutia-it.es>
<http://solutia-it.es/>
Solutia Innovaworld Technologies S.L.
Parque empresarial Los Llanos
C/ Extremadura, 108 - 41909 - Salteras (Sevilla)
T: +34 955 11 11 55
F: +34 954 37 11 42
<http://www.solutia-it.es> www.solutia-it.es
<http://solutia-it.es/calidad/>
Sus datos personales contenidos en esta comunicaci?n han sido recogidos de
los contactos mantenidos por Vd. o por personas de su entorno, con personal
de SOLUTIA INNOVAWORLD TECHNOLOGIES, S.L. y han sido incorporados al fichero
de GESTI?N COMERCIAL con la finalidad de realizar la gesti?n, seguimiento y
mantenimiento de nuestra relaci?n comercial, o a otro fichero
correspondiente al tipo de relaci?n que mantiene con nosotros, de lo que Vd.
fue convenientemente informado al recibir bien el documento contractual
entregado al inicio de los contactos bien en una comunicaci?n inmediatamente
posterior en que se daba cumplimiento al derecho de informaci?n y se le
solicitaba consentimiento para tratar sus datos personales, tratamiento que
se efectuar? de acuerdo a las finalidades all? expresadas.
En el caso en que ?sta sea la primera comunicaci?n que recibe por nuestra
parte, le solicitamos su consentimiento para proceder al tratamiento de sus
datos de acuerdo a las condiciones detalladas al inicio. Entenderemos que
nos presta su consentimiento si en el plazo de un mes a contar desde la
recepci?n de esta comunicaci?n no nos expresa su voluntad en contra. Le
informamos que puede revocar en cualquier momento su consentimiento
respondiendo a este mail indicando que no desea recibir m?s informaci?n
acerca de nuestra empresa, supuesto en el que ser? autom?ticamente dado de
baja de nuestra lista de correo.
Podr? ejercer sus derechos de acceso, rectificaci?n, cancelaci?n y oposici?n
ante el Responsable del fichero, SOLUTIA INNOVAWORLD TECHNOLOGIES, S.L. en
la direcci?n C/ Extremadura, 108 Parque empresarial Los Llanos; 41909
Salteras, SEVILLA, indicando en la comunicaci?n la referencia "LOPD"
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pcsclite-muscle/attachments/20160923/a4728184/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.gif
Type: image/gif
Size: 1443 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pcsclite-muscle/attachments/20160923/a4728184/attachment-0003.gif>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image002.gif
Type: image/gif
Size: 3498 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pcsclite-muscle/attachments/20160923/a4728184/attachment-0004.gif>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image003.gif
Type: image/gif
Size: 13916 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pcsclite-muscle/attachments/20160923/a4728184/attachment-0005.gif>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image004.jpg
Type: image/jpeg
Size: 9470 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pcsclite-muscle/attachments/20160923/a4728184/attachment-0001.jpg>
More information about the pcsclite-muscle
mailing list