[Pcsclite-muscle] Tracing feature in the client side

[Ludovic Rousseau]

2016-03-10 13:13 GMT+01:00 Maksim Ivanov <emaxx at google.com>:

> Hello all,
>

Hello Maksim,


>
> I have a couple of small suggestions regarding the tracing feature of
> the PC/SC-Lite's client side library. This feature is controlled by
> the "DO_TRACE" preprocessor definition.
>
> First, it's impossible to trigger this feature using the compiler
> flags: for some reason, the winscard_clnt.c file contains directive
> "#undef DO_TRACE". If it were a commented "#define" directive, then
> this would be more useful: the feature could be triggered both by
> editing the source file and by modifying the compiler flags.
>

Fixed in ea0a50bf2088906d888cf1888b4439f3391eb111


> Second, there is an inconsistency between the printf format specifier
> and the passed value in the trace function, that produces a warning.
> E.g. with clang 3.7.0:
>
> > pcsc-lite/src-1.8.15/src/winscard_clnt.c:162:14: error: format specifies
> type 'unsigned long' but the argument has type 'pthread_t'
> >       (aka 'struct __nc_basic_thread_data *') [-Werror,-Wformat]
> >                 direction, pthread_self(), func);
> >                            ^~~~~~~~~~~~~~
>

Can you propose a patch for that?

pthread_t may not be a numerical value. It may be a structure.
http://stackoverflow.com/questions/1759794/how-to-print-pthread-t

Regards,

-- 
 Dr. Ludovic Rousseau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pcsclite-muscle/attachments/20160311/34e7aef5/attachment.html>