[From nobody Thu Jun 25 05:55:58 2020 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jnoYP-0001Eo-Sw for openwrt-devel@merlin.infradead.org; Tue, 23 Jun 2020 19:25:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:Cc:To:Subject:Message-ID: Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dp5b0GZqr0aQy6cxAtHRKtOqfjHj4l1wVpExPvw6PAo=; b=sAP8kIe5ZCYLm0gSakrSm3OkLi YqkZTaXI5L5y7I2vKYmC/0vmYePytcPwEspyd1KCSOelAwVPIATNzW66CYN5+iLyojew3RVe2w6HM yGLBw1pPZCSNYXLn62ySDQ/YlGKr/hfW7zSdsYsLs7NIxZLDZvEy3mgsb2okvpuqhwsfjUpQWovwB AUQa6Qs/gWG8EiMUy9tiEBckKPNBB5KwsCVxfj/sWw4GlD5RoukrPYWhHJa2T9/5wfT07TXqHx2fC 3FAtzxxoQDyuQfUwQRcBbDNkuSz5u2G1SmBDgHQLLEr20XenXPz22cp0pJEg+h4CSEaXnZ3gXvpBT ULUteGSw==; Received: from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jnoYM-00008Z-Nf for openwrt-devel@lists.openwrt.org; Tue, 23 Jun 2020 19:25:57 +0000 Received: by mail-ej1-x644.google.com with SMTP id a1so8736970ejg.12 for <openwrt-devel@lists.openwrt.org>; Tue, 23 Jun 2020 12:25:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dp5b0GZqr0aQy6cxAtHRKtOqfjHj4l1wVpExPvw6PAo=; b=Sg4N8Szu4R+yJbrCnCKKjcngDXPyoYCe1x8IzjK/0cgR+FFwmdOpvw45YzstgNBWOk pbRYGdfSNYM0QGB1k66/MreWyGIoYRx8pxZutBDVFjxTHF95P2HqfjH6n5G/7zsmF7bg 9WLYmN7lBqPIoswoMT2cTK+fE9rUXGzc1p3OmQG/eo6ujMXwaIKb7LF6+YNfMRYDjrYx 2muXsJipdXwIOiOzn1vuzqMiM+mkpm09ISJk6MyrxfX/VapcTGrXVwUH1rPazpGXy57f FQRh3P627Rh+ams8cVCE56+LhD+xSHcDdwh3ipd68tzhSyrPbZPm/dAoQ0wMxgANB2mc 9YSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dp5b0GZqr0aQy6cxAtHRKtOqfjHj4l1wVpExPvw6PAo=; b=LG1Dqpe6MuJ706xSG2o3EqD+JC2ECB2BqWo2EOKUK1pxhnH8wfNmXIuTvp2EXXTO+9 FpCoj8o3silYUkiu5GrzZjwQXr8dQXRArGEV3856BvAy/9CSV2SuzXd3F/UU4MCD119i vuXoidAUM0hbTOg772xNZ9+Y3lfhFFPZMYA/2TAOQbleer0BQfIESre+gQgU0Qf7pP8P AH8iL115xA5D8pjjcMbly9D63etQWe5xEyvma990c25TBetPuIcFAqRfq2m55V6NpIjJ AnRrge7hXWyOQlC8WTCU4FucBQrBgURsMpp9lUKMqyR0miMPNH5txooQ+rwpV71T+mDB a/og== X-Gm-Message-State: AOAM530ORZD6AdOMpIULqmDlLTHEahNMWNmRBpXLksCiB+TxjPvHOVOh mu2xG47ddakTV9hgaKw1lJG1gump0zKTiyTUh9rkjR3K X-Google-Smtp-Source: ABdhPJxgqg+O1l9It/CMWgB/vZABpq6NPHZnirq4BagYEyTWkd6mxIYl5ER+wQaxghQD8wXzZ+I39o1RbDpU7FJZhxk= X-Received: by 2002:a17:906:2287:: with SMTP id p7mr3632721eja.537.1592940351451; Tue, 23 Jun 2020 12:25:51 -0700 (PDT) MIME-Version: 1.0 References: <20200623094028.1248246-1-john@phrozen.org> In-Reply-To: <20200623094028.1248246-1-john@phrozen.org> From: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Date: Tue, 23 Jun 2020 21:25:40 +0200 Message-ID: <CAFBinCCBM9m62=2QOFVmuNNoufWdu46FrjO6cXCnMA+VNEHoMQ@mail.gmail.com> Subject: Re: [PATCH V1] netifd: fix wdev->data lifetime To: John Crispin <john@phrozen.org> Cc: openwrt-devel@lists.openwrt.org Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200623_202554_928348_2CE5D330 X-CRM114-Status: UNSURE ( 8.70 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.1 (--) X-Spam-Report: SpamAssassin version 3.4.4 on casper.infradead.org summary: Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:644 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [martin.blumenstingl[at]googlemail.com] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain Hi John, On Tue, Jun 23, 2020 at 11:43 AM John Crispin <john@phrozen.org> wrote: [...] > @@ -1414,6 +1413,8 @@ wireless_device_notify(struct wireless_device *wdev, struct blob_attr *data, > if (*pdata) > return UBUS_STATUS_INVALID_ARGUMENT; > > + if (*pdata) > + free(*pdata); there's another "if (*pdata)" right above this one which returns (UBUS_STATUS_INVALID_ARGUMENT) from that function. I'm probably missing something so to me it seems as if the new "if (*pdata)" is not reachable Martin ]