[From nobody Thu Jun 25 05:55:23 2020 Received: from mr85p00im-zteg06011501.me.com ([17.58.23.182]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1i9SDu-0007he-Vv for openwrt-devel@lists.openwrt.org; Sun, 15 Sep 2019 10:57:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1568545057; bh=8L7KyCmlRWVuBlWPi/lepAP1pJMtl4YKvGyI9qczwZY=; h=From:Message-Id:Content-Type:Subject:Date:To; b=RwLhQS9madeVIT5vIFR9djIYRAeaOrerlI6u7Mfe5dGlnfA7sWAozA4BspBqT/QPj muYaSa8afTdTS7bxgKd/JQpP5NcUW3j6svvDiixrQL9SNkX0kR1j1ZY0aq/VXozkXf Oy6lKQ9gPyNI7VtG36cJvJJsb3mdp8EK4yLQrU7JpKVoB4KhUVsTRtTrtgYy7Ou5xL +AVNUrk7WY6aimp7vNyDYvB4QcoyGkCljWn4GUUqfdE/v/mwd7kA0mNZYVhZCAJGmH J1dJeSjFmAkIAkXISkNr6B6fUj/+gUJNfKbxLB+sioXIzSI6fbBkC9L7eXlUmCKqJ2 lDFJ+NQ+YzDcg== Received: from aarau.fritz.box (unknown [81.221.232.148]) by mr85p00im-zteg06011501.me.com (Postfix) with ESMTPSA id 91C932A0833; Sun, 15 Sep 2019 10:57:35 +0000 (UTC) From: =?utf-8?Q?Ivan_H=C3=B6rler?= <i.hoerler@me.com> Message-Id: <A3F757F3-DDFE-4273-B380-8048EB79EC1B@me.com> Content-Type: multipart/alternative; boundary="Apple-Mail=_282E45E5-C872-473A-8331-B0CF87DA21E9" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: [OpenWrt-Devel] [ramips] Linkit Smart 7688 kmod-sdhci-mt7620 Date: Sun, 15 Sep 2019 12:57:33 +0200 In-Reply-To: <openwrt/openwrt/pull/2411/c531510195@github.com> Cc: openwrt-devel@lists.openwrt.org To: Adrian Schmutzler <mail@adrianschmutzler.de> References: <openwrt/openwrt/pull/2411@github.com> <openwrt/openwrt/pull/2411/c531510195@github.com> X-Mailer: Apple Mail (2.3445.104.11) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-09-15_05:, , signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1812120000 definitions=main-1909150121 X-Bad-Reply: References and In-Reply-To but no 'Re:' in Subject. X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190915_035743_051073_4B815E7F X-CRM114-Status: GOOD ( 10.75 ) X-Spam-Score: -1.2 (-) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-1.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (i.hoerler[at]me.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [17.58.23.182 listed in list.dnswl.org] 0.0 HTML_MESSAGE BODY: HTML included in message 1.3 HTML_IMAGE_ONLY_24 BODY: HTML: images with 2000-2400 bytes of words -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain --Apple-Mail=_282E45E5-C872-473A-8331-B0CF87DA21E9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi Adrian So i did: https://github.com/openwrt/openwrt/pull/2411 Thanks for the help! Ivan > Am 14.09.2019 um 22:18 schrieb Adrian Schmutzler = <notifications@github.com>: >=20 > Hi, thanks for implementing my suggestions. However, please do not = open a new PR when doing changes, but rebase your commits in the = existing branch in the future, so discussion etc. is kept. >=20 > For this PR, I would like you to address the following minor issues: >=20 > You are changing only Linkit Smart 7688, but your commit title does = not express that. Maybe choose something more specific like > "ramips: add SD-Card support to Linkit Smart 7688" > In the commit description, please remove the reference to 18.06. Your = commit will be applied to master, and then might be backported to older = stable branches, so the reference to 18.06 is wrong in this case. Just = state that the SD-Card reader is not working ATM. > =E2=80=94 > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub = <https://github.com/openwrt/openwrt/pull/2411?email_source=3Dnotifications= &email_token=3DABOOK6AQOMK3SJDOVHP3RYLQJVBIBA5CNFSM4IWXLNB2YY3PNVWWK3TUL52= HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6XDHMY#issuecomment-53151019= 5>, or mute the thread = <https://github.com/notifications/unsubscribe-auth/ABOOK6G5BUMN6F2ZTLJ2OPL= QJVBIBANCNFSM4IWXLNBQ>. >=20 --Apple-Mail=_282E45E5-C872-473A-8331-B0CF87DA21E9 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; = charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; line-break: after-white-space;" class=3D"">Hi = Adrian<div class=3D"">So i did: <a = href=3D"https://github.com/openwrt/openwrt/pull/2411" = class=3D"">https://github.com/openwrt/openwrt/pull/2411</a></div><div = class=3D"">Thanks for the help!</div><div class=3D"">Ivan<br = class=3D""><div><br class=3D""><blockquote type=3D"cite" class=3D""><div = class=3D"">Am 14.09.2019 um 22:18 schrieb Adrian Schmutzler <<a = href=3D"mailto:notifications@github.com" = class=3D"">notifications@github.com</a>>:</div><br = class=3D"Apple-interchange-newline"><div class=3D""><p class=3D"">Hi, = thanks for implementing my suggestions. However, please do not open a = new PR when doing changes, but rebase your commits in the existing = branch in the future, so discussion etc. is kept.</p><p class=3D"">For = this PR, I would like you to address the following minor issues:</p> <ul class=3D""> <li class=3D"">You are changing only Linkit Smart 7688, but your commit = title does not express that. Maybe choose something more specific = like<br class=3D""> "ramips: add SD-Card support to Linkit Smart 7688"</li> <li class=3D"">In the commit description, please remove the reference to = 18.06. Your commit will be applied to master, and then might be = backported to older stable branches, so the reference to 18.06 is wrong = in this case. Just state that the SD-Card reader is not working = ATM.</li> </ul><p = style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;" = class=3D"">=E2=80=94<br class=3D"">You are receiving this because you = authored the thread.<br class=3D"">Reply to this email directly, <a = href=3D"https://github.com/openwrt/openwrt/pull/2411?email_source=3Dnotifi= cations&email_token=3DABOOK6AQOMK3SJDOVHP3RYLQJVBIBA5CNFSM4IWXLNB2YY3P= NVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6XDHMY#issuecomme= nt-531510195" class=3D"">view it on GitHub</a>, or <a = href=3D"https://github.com/notifications/unsubscribe-auth/ABOOK6G5BUMN6F2Z= TLJ2OPLQJVBIBANCNFSM4IWXLNBQ" class=3D"">mute the thread</a>.<img = src=3D"https://github.com/notifications/beacon/ABOOK6ESZUWLQHUT5TZJGEDQJVB= IBA5CNFSM4IWXLNB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWS= ZGOD6XDHMY.gif" height=3D"1" width=3D"1" alt=3D"" class=3D""></p> </div></blockquote></div><br class=3D""></div></body></html>= --Apple-Mail=_282E45E5-C872-473A-8331-B0CF87DA21E9-- ]