
<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi Adrian<div class="">Thanks for your patientness. Wasn’t aware it's so strict. I just added the --signedoff to the commit.</div><div class="">Good to know how to work clean. Now i redone it. </div><div class="">Is this fullfilling openWRT’s rules? <a href="https://github.com/openwrt/openwrt/pull/2411" class="">https://github.com/openwrt/openwrt/pull/2411</a></div><div class="">Regards, Ivan <br class=""><div><br class=""><blockquote type="cite" class=""><div class="">Am 14.09.2019 um 16:27 schrieb Adrian Schmutzler <<a href="mailto:notifications@github.com" class="">notifications@github.com</a>>:</div><br class="Apple-interchange-newline"><div class=""><p class="">Hi, if you haven't yet, please have a look at <a href="https://openwrt.org/submitting-patches" rel="nofollow" class="">https://openwrt.org/submitting-patches</a></p><p class="">Specifically, please</p>

<ul class="">

<li class="">remove the two commits adding and removing the "wrong" version, so that only the correct commit survives (e.g. with <code class="">git rebase -i @~3</code>)</li>

<li class="">add a "ramips: " prefix to your commit titles</li>

<li class="">Your Signed-off-by has to contain a real name</li>

<li class="">add a commit message describing what you change and why</li>

</ul><p style="font-size:small;-webkit-text-size-adjust:none;color:#666;" class="">—<br class="">You are receiving this because you authored the thread.<br class="">Reply to this email directly, <a href="https://github.com/openwrt/openwrt/pull/2410?email_source=notifications&email_token=ABOOK6G3ZRCYYHUGPDDZGA3QJTYDRA5CNFSM4IWXBPP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6W4ZVQ#issuecomment-531483862" class="">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABOOK6DBWEFJN6IA2OBL6BDQJTYDRANCNFSM4IWXBPPQ" class="">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABOOK6DCVBX4WFFPBEYFTU3QJTYDRA5CNFSM4IWXBPP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6W4ZVQ.gif" height="1" width="1" alt="" class=""></p>

</div></blockquote></div><br class=""></div></body></html>