<div dir="ltr"><div><div>Hello, Christian.<br><br></div>This bug was fixed in ath10k-ct by this previous commit.<br><a href="https://github.com/greearb/ath10k-ct/commit/9e5ab25027e0971fa24ccf93373324c08c4e992d">https://github.com/greearb/ath10k-ct/commit/9e5ab25027e0971fa24ccf93373324c08c4e992d</a><br><br></div>As I understand, update should be harmless this time.<br><div><div><div><div><br><br clear="all"><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature">Best Regards,<br>Lukonin Kirill<br></div></div><br></div></div></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">сб, 14 сент. 2019 г. в 00:33, Christian Lamparter <<a href="mailto:chunkeey@gmail.com">chunkeey@gmail.com</a>>:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Friday, September 13, 2019 12:15:39 PM CEST Robert Marko wrote:<br>
> Update the ath10k-ct driver version to 5e8cd86f90dac966d12df6ece84ac41458d0e95f<br>
> to enable dynamic VLANs to work.<br>
> Packages refreshed while bump.<br>
> <br>
> Signed-off-by: Robert Marko <<a href="mailto:robimarko@gmail.com" target="_blank">robimarko@gmail.com</a>><br>
> <br>
> Changes from v1:<br>
> * Fixed wrong mirror hash<br>
<br>
Watch out, there's a request to revert the ath10k-ct, since the<br>
previous "ath10k-ct: update to HEAD of 2019-08-14 - 9e5ab2" patch<br>
apparently broke 160MHz.<br>
<br>
<a href="https://github.com/openwrt/openwrt/commit/e9d875a5371c89a3f351df5aec593ac90ba89ecc#commitcomment-34992683" rel="noreferrer" target="_blank">https://github.com/openwrt/openwrt/commit/e9d875a5371c89a3f351df5aec593ac90ba89ecc#commitcomment-34992683</a><br>
<br>
I didn't see any 160MHz related fixes in the update here... So what to do?<br>
Update or revert?<br>
<br>
> ---<br>
> package/kernel/ath10k-ct/Makefile | 6 +++---<br>
> ...h10k-add-support-for-configuring-management-packet.patch | 4 ++--<br>
> ...h10k-fix-possible-out-of-bound-access-of-ath10k_ra.patch | 2 +-<br>
> ...h10k-fix-incorrect-multicast-broadcast-rate-settin.patch | 4 ++--<br>
> .../patches/164-ath10k-commit-rates-from-mac80211.patch | 6 +++---<br>
> ...-and-GPIO-controlling-support-for-various-chipsets.patch | 6 +++---<br>
> .../202-ath10k-4.16-use-tpt-trigger-by-default.patch | 4 ++--<br>
> ...h10k-Limit-available-channels-via-DT-ieee80211-fre.patch | 2 +-<br>
> ...h10k-Check-if-station-exists-before-forwarding-tx-.patch | 2 +-<br>
> 9 files changed, 18 insertions(+), 18 deletions(-)<br>
> <br>
> diff --git a/package/kernel/ath10k-ct/Makefile b/package/kernel/ath10k-ct/Makefile<br>
> index 05d30891f5..dbf75fe174 100644<br>
> --- a/package/kernel/ath10k-ct/Makefile<br>
> +++ b/package/kernel/ath10k-ct/Makefile<br>
> @@ -8,9 +8,9 @@ PKG_LICENSE_FILES:=<br>
> <br>
> PKG_SOURCE_URL:=<a href="https://github.com/greearb/ath10k-ct.git" rel="noreferrer" target="_blank">https://github.com/greearb/ath10k-ct.git</a><br>
> PKG_SOURCE_PROTO:=git<br>
> -PKG_SOURCE_DATE:=2019-08-14<br>
> -PKG_SOURCE_VERSION:=9e5ab25027e0971fa24ccf93373324c08c4e992d<br>
> -PKG_MIRROR_HASH:=95dc42a5615f80528223859b4f9618feafb5a0a29a9eb4c4bc983f76c74fb535<br>
> +PKG_SOURCE_DATE:=2019-09-09<br>
> +PKG_SOURCE_VERSION:=5e8cd86f90dac966d12df6ece84ac41458d0e95f<br>
> +PKG_MIRROR_HASH:=dc1097f3a7b4b7e346918f206746d00a0b7df07ae3be9b89be55dfaef3cbbe45<br>
> <br>
> # Build the 5.2 ath10k-ct driver version. Other option is "-4.19".<br>
> # Probably this should match as closely as<br>
> diff --git a/package/kernel/ath10k-ct/patches/161-ath10k-add-support-for-configuring-management-packet.patch b/package/kernel/ath10k-ct/patches/161-ath10k-add-support-for-configuring-management-packet.patch<br>
> index d62a1cfcf5..e67003c5a7 100644<br>
> --- a/package/kernel/ath10k-ct/patches/161-ath10k-add-support-for-configuring-management-packet.patch<br>
> +++ b/package/kernel/ath10k-ct/patches/161-ath10k-add-support-for-configuring-management-packet.patch<br>
> @@ -43,7 +43,7 @@ Origin: backport, <a href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux" rel="noreferrer" target="_blank">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux</a><br>
> static int ath10k_mac_get_max_vht_mcs_map(u16 mcs_map, int nss)<br>
> {<br>
> switch ((mcs_map >> (2 * nss)) & 0x3) {<br>
> -@@ -6388,9 +6404,10 @@ static void ath10k_bss_info_changed(stru<br>
> +@@ -6405,9 +6421,10 @@ static void ath10k_bss_info_changed(stru<br>
> struct cfg80211_chan_def def;<br>
> u32 vdev_param, pdev_param, slottime, preamble;<br>
> u16 bitrate, hw_value;<br>
> @@ -56,7 +56,7 @@ Origin: backport, <a href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux" rel="noreferrer" target="_blank">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux</a><br>
> <br>
> mutex_lock(&ar->conf_mutex);<br>
> <br>
> -@@ -6596,6 +6613,30 @@ static void ath10k_bss_info_changed(stru<br>
> +@@ -6613,6 +6630,30 @@ static void ath10k_bss_info_changed(stru<br>
> arvif->vdev_id, ret);<br>
> }<br>
> <br>
> diff --git a/package/kernel/ath10k-ct/patches/162-ath10k-fix-possible-out-of-bound-access-of-ath10k_ra.patch b/package/kernel/ath10k-ct/patches/162-ath10k-fix-possible-out-of-bound-access-of-ath10k_ra.patch<br>
> index ab360b7261..a24029983c 100644<br>
> --- a/package/kernel/ath10k-ct/patches/162-ath10k-fix-possible-out-of-bound-access-of-ath10k_ra.patch<br>
> +++ b/package/kernel/ath10k-ct/patches/162-ath10k-fix-possible-out-of-bound-access-of-ath10k_ra.patch<br>
> @@ -26,7 +26,7 @@ Origin: backport, <a href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux" rel="noreferrer" target="_blank">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux</a><br>
> if (ath10k_rates[i].bitrate == bitrate)<br>
> return hw_value_prefix | ath10k_rates[i].hw_value;<br>
> }<br>
> -@@ -6619,22 +6619,22 @@ static void ath10k_bss_info_changed(stru<br>
> +@@ -6636,22 +6636,22 @@ static void ath10k_bss_info_changed(stru<br>
> return;<br>
> }<br>
> <br>
> diff --git a/package/kernel/ath10k-ct/patches/163-ath10k-fix-incorrect-multicast-broadcast-rate-settin.patch b/package/kernel/ath10k-ct/patches/163-ath10k-fix-incorrect-multicast-broadcast-rate-settin.patch<br>
> index 2b550e76df..f6fd75b7e5 100644<br>
> --- a/package/kernel/ath10k-ct/patches/163-ath10k-fix-incorrect-multicast-broadcast-rate-settin.patch<br>
> +++ b/package/kernel/ath10k-ct/patches/163-ath10k-fix-incorrect-multicast-broadcast-rate-settin.patch<br>
> @@ -17,7 +17,7 @@ Origin: other, <a href="https://patchwork.kernel.org/patch/10723033/" rel="noreferrer" target="_blank">https://patchwork.kernel.org/patch/10723033/</a><br>
> <br>
> --- a/ath10k-4.19/mac.c<br>
> +++ b/ath10k-4.19/mac.c<br>
> -@@ -6404,8 +6404,8 @@ static void ath10k_bss_info_changed(stru<br>
> +@@ -6421,8 +6421,8 @@ static void ath10k_bss_info_changed(stru<br>
> struct cfg80211_chan_def def;<br>
> u32 vdev_param, pdev_param, slottime, preamble;<br>
> u16 bitrate, hw_value;<br>
> @@ -28,7 +28,7 @@ Origin: other, <a href="https://patchwork.kernel.org/patch/10723033/" rel="noreferrer" target="_blank">https://patchwork.kernel.org/patch/10723033/</a><br>
> enum nl80211_band band;<br>
> const struct ieee80211_supported_band *sband;<br>
> <br>
> -@@ -6578,7 +6578,11 @@ static void ath10k_bss_info_changed(stru<br>
> +@@ -6595,7 +6595,11 @@ static void ath10k_bss_info_changed(stru<br>
> if (changed & BSS_CHANGED_MCAST_RATE &&<br>
> !WARN_ON(ath10k_mac_vif_chan(arvif->vif, &def))) {<br>
> band = def.chan->band;<br>
> diff --git a/package/kernel/ath10k-ct/patches/164-ath10k-commit-rates-from-mac80211.patch b/package/kernel/ath10k-ct/patches/164-ath10k-commit-rates-from-mac80211.patch<br>
> index b67ad2c3c4..aab435bccd 100644<br>
> --- a/package/kernel/ath10k-ct/patches/164-ath10k-commit-rates-from-mac80211.patch<br>
> +++ b/package/kernel/ath10k-ct/patches/164-ath10k-commit-rates-from-mac80211.patch<br>
> @@ -11,7 +11,7 @@ Signed-off-by: Sven Eckelmann <<a href="mailto:sven@narfation.org" target="_blank">sven@narfation.org</a>><br>
> <br>
> --- a/ath10k-4.19/mac.c<br>
> +++ b/ath10k-4.19/mac.c<br>
> -@@ -6600,6 +6600,7 @@ static void ath10k_bss_info_changed(stru<br>
> +@@ -6617,6 +6617,7 @@ static void ath10k_bss_info_changed(stru<br>
> "mac vdev %d mcast_rate %x\n",<br>
> arvif->vdev_id, rate);<br>
> <br>
> @@ -19,7 +19,7 @@ Signed-off-by: Sven Eckelmann <<a href="mailto:sven@narfation.org" target="_blank">sven@narfation.org</a>><br>
> vdev_param = ar->wmi.vdev_param->mcast_data_rate;<br>
> ret = ath10k_wmi_vdev_set_param(ar, arvif->vdev_id,<br>
> vdev_param, rate);<br>
> -@@ -6608,6 +6609,7 @@ static void ath10k_bss_info_changed(stru<br>
> +@@ -6625,6 +6626,7 @@ static void ath10k_bss_info_changed(stru<br>
> "failed to set mcast rate on vdev %i: %d\n",<br>
> arvif->vdev_id, ret);<br>
> <br>
> @@ -27,7 +27,7 @@ Signed-off-by: Sven Eckelmann <<a href="mailto:sven@narfation.org" target="_blank">sven@narfation.org</a>><br>
> vdev_param = ar->wmi.vdev_param->bcast_data_rate;<br>
> ret = ath10k_wmi_vdev_set_param(ar, arvif->vdev_id,<br>
> vdev_param, rate);<br>
> -@@ -6634,6 +6636,7 @@ static void ath10k_bss_info_changed(stru<br>
> +@@ -6651,6 +6653,7 @@ static void ath10k_bss_info_changed(stru<br>
> return;<br>
> }<br>
> <br>
> diff --git a/package/kernel/ath10k-ct/patches/201-ath10k-4.16_add-LED-and-GPIO-controlling-support-for-various-chipsets.patch b/package/kernel/ath10k-ct/patches/201-ath10k-4.16_add-LED-and-GPIO-controlling-support-for-various-chipsets.patch<br>
> index 38ec21f52f..ba42fc1d2d 100644<br>
> --- a/package/kernel/ath10k-ct/patches/201-ath10k-4.16_add-LED-and-GPIO-controlling-support-for-various-chipsets.patch<br>
> +++ b/package/kernel/ath10k-ct/patches/201-ath10k-4.16_add-LED-and-GPIO-controlling-support-for-various-chipsets.patch<br>
> @@ -210,7 +210,7 @@ v13:<br>
> <br>
> #include "htt.h"<br>
> #include "htc.h"<br>
> -@@ -1137,7 +1138,6 @@ struct ath10k {<br>
> +@@ -1138,7 +1139,6 @@ struct ath10k {<br>
> u32 low_5ghz_chan;<br>
> u32 high_5ghz_chan;<br>
> bool ani_enabled;<br>
> @@ -218,7 +218,7 @@ v13:<br>
> bool p2p;<br>
> bool ct_all_pkts_htt; /* CT firmware only: native-wifi for all pkts */<br>
> <br>
> -@@ -1388,6 +1388,13 @@ struct ath10k {<br>
> +@@ -1389,6 +1389,13 @@ struct ath10k {<br>
> } testmode;<br>
> <br>
> struct {<br>
> @@ -562,7 +562,7 @@ v13:<br>
> int ath10k_wmi_attach(struct ath10k *ar)<br>
> --- a/ath10k-4.19/wmi.h<br>
> +++ b/ath10k-4.19/wmi.h<br>
> -@@ -3044,6 +3044,41 @@ enum wmi_10_4_feature_mask {<br>
> +@@ -3084,6 +3084,41 @@ enum wmi_10_4_feature_mask {<br>
> <br>
> };<br>
> <br>
> diff --git a/package/kernel/ath10k-ct/patches/202-ath10k-4.16-use-tpt-trigger-by-default.patch b/package/kernel/ath10k-ct/patches/202-ath10k-4.16-use-tpt-trigger-by-default.patch<br>
> index e5dd967a26..0e7a03ef6d 100644<br>
> --- a/package/kernel/ath10k-ct/patches/202-ath10k-4.16-use-tpt-trigger-by-default.patch<br>
> +++ b/package/kernel/ath10k-ct/patches/202-ath10k-4.16-use-tpt-trigger-by-default.patch<br>
> @@ -16,7 +16,7 @@ Signed-off-by: Mathias Kresin <<a href="mailto:dev@kresin.me" target="_blank">dev@kresin.me</a>><br>
> <br>
> --- a/ath10k-4.19/core.h<br>
> +++ b/ath10k-4.19/core.h<br>
> -@@ -1487,6 +1487,10 @@ struct ath10k {<br>
> +@@ -1488,6 +1488,10 @@ struct ath10k {<br>
> u8 csi_data[4096];<br>
> u16 csi_data_len;<br>
> <br>
> @@ -42,7 +42,7 @@ Signed-off-by: Mathias Kresin <<a href="mailto:dev@kresin.me" target="_blank">dev@kresin.me</a>><br>
> if (ret)<br>
> --- a/ath10k-4.19/mac.c<br>
> +++ b/ath10k-4.19/mac.c<br>
> -@@ -9965,7 +9965,7 @@ int ath10k_mac_register(struct ath10k *a<br>
> +@@ -9982,7 +9982,7 @@ int ath10k_mac_register(struct ath10k *a<br>
> wiphy_ext_feature_set(ar->hw->wiphy, NL80211_EXT_FEATURE_CQM_RSSI_LIST);<br>
> <br>
> #ifdef CPTCFG_MAC80211_LEDS<br>
> diff --git a/package/kernel/ath10k-ct/patches/203-ath10k-Limit-available-channels-via-DT-ieee80211-fre.patch b/package/kernel/ath10k-ct/patches/203-ath10k-Limit-available-channels-via-DT-ieee80211-fre.patch<br>
> index 3a22fc74cb..d770948f79 100644<br>
> --- a/package/kernel/ath10k-ct/patches/203-ath10k-Limit-available-channels-via-DT-ieee80211-fre.patch<br>
> +++ b/package/kernel/ath10k-ct/patches/203-ath10k-Limit-available-channels-via-DT-ieee80211-fre.patch<br>
> @@ -29,7 +29,7 @@ Forwarded: <a href="https://patchwork.kernel.org/patch/10549245/" rel="noreferrer" target="_blank">https://patchwork.kernel.org/patch/10549245/</a><br>
> #include <net/mac80211.h><br>
> #include <linux/etherdevice.h><br>
> #include <linux/acpi.h><br>
> -@@ -9689,6 +9690,7 @@ int ath10k_mac_register(struct ath10k *a<br>
> +@@ -9706,6 +9707,7 @@ int ath10k_mac_register(struct ath10k *a<br>
> ar->hw->wiphy->bands[NL80211_BAND_5GHZ] = band;<br>
> }<br>
> <br>
> diff --git a/package/kernel/ath10k-ct/patches/976-ath10k-Check-if-station-exists-before-forwarding-tx-.patch b/package/kernel/ath10k-ct/patches/976-ath10k-Check-if-station-exists-before-forwarding-tx-.patch<br>
> index a2f3a3f41a..cd8967cb93 100644<br>
> --- a/package/kernel/ath10k-ct/patches/976-ath10k-Check-if-station-exists-before-forwarding-tx-.patch<br>
> +++ b/package/kernel/ath10k-ct/patches/976-ath10k-Check-if-station-exists-before-forwarding-tx-.patch<br>
> @@ -70,7 +70,7 @@ Signed-off-by: Hauke Mehrtens <<a href="mailto:hauke@hauke-m.de" target="_blank">hauke@hauke-m.de</a>><br>
> <br>
> --- a/ath10k-5.2/htt_rx.c<br>
> +++ b/ath10k-5.2/htt_rx.c<br>
> -@@ -2497,7 +2497,7 @@ do_generic:<br>
> +@@ -2507,7 +2507,7 @@ do_generic:<br>
> spin_lock_bh(&ar->data_lock);<br>
> <br>
> peer = ath10k_peer_find_by_id(ar, peer_id);<br>
> <br>
<br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
openwrt-devel mailing list<br>
<a href="mailto:openwrt-devel@lists.openwrt.org" target="_blank">openwrt-devel@lists.openwrt.org</a><br>
<a href="https://lists.openwrt.org/mailman/listinfo/openwrt-devel" rel="noreferrer" target="_blank">https://lists.openwrt.org/mailman/listinfo/openwrt-devel</a><br>
</blockquote></div>