<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.EmailStyle18
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=DE link=blue vlink=purple><div class=WordSection1><p><span style='font-family:"Calibri",sans-serif'>Hi,</span> <o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>> -----Original Message-----</span> <br><span style='font-family:"Calibri",sans-serif'>> From: openwrt-devel [<a href="mailto:openwrt-devel-bounces@lists.openwrt.org">mailto:openwrt-devel-bounces@lists.openwrt.org</a>]</span> <br><span style='font-family:"Calibri",sans-serif'>> On Behalf Of David Bauer</span> <br><span style='font-family:"Calibri",sans-serif'>> Sent: Mittwoch, 4. September 2019 21:19</span> <br><span style='font-family:"Calibri",sans-serif'>> To: openwrt-devel@lists.openwrt.org</span> <br><span style='font-family:"Calibri",sans-serif'>> Cc: mail@adrianschmutzler.de</span> <br><span style='font-family:"Calibri",sans-serif'>> Subject: [OpenWrt-Devel] [PATCH] base-files: fix get_mac_address not</span> <br><span style='font-family:"Calibri",sans-serif'>> accepting hex offsets</span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> The get_mac_address helper methods did not support hexadecimal offset</span> <br><span style='font-family:"Calibri",sans-serif'>> values, resulting them to break after 75bfc393ba6c ("treewide:</span> <br><span style='font-family:"Calibri",sans-serif'>> convert MAC address location offsets to hexadecimal")</span> <o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>when I tested it then, the hexdump offset did accept hexadecimal values intrinsically.</span> <br><span style='font-family:"Calibri",sans-serif'>I remember that because I was quite surprised that offset accepted hexadecimal values and size didn't.</span> <o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>In particular I've always been using get_mac_binary with hexadecimal values as second argument.</span> <br><span style='font-family:"Calibri",sans-serif'>Or am I misunderstanding you somewhere?</span> <o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>However, converting it as in this patch doesn't hurt, especially if the behavior of hexdump changes in the future.</span> <o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>Best</span> <o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>Adrian</span> <o:p></o:p></p></div></body></html>