<html><head><meta http-equiv="content-type" content="text/html; charset=UTF-8"><style>body { line-height: 1.5; }blockquote { margin-top: 0px; margin-bottom: 0px; margin-left: 0.5em; }body { font-size: 10.5pt; font-family: 微软雅黑; color: rgb(0, 0, 0); line-height: 1.5; }</style></head><body>
<div><span></span>Hi,</div><div><br></div><div><span style="color: rgb(0, 0, 0); background-color: rgba(0, 0, 0, 0);">Thanks for your advice. I will fix these problems and resubmit the patch</span></div><div><span style="color: rgb(0, 0, 0); background-color: rgba(0, 0, 0, 0);"><br></span></div><div><span style="color: rgb(0, 0, 0); background-color: rgba(0, 0, 0, 0);">Best regards</span></div><div><span style="color: rgb(0, 0, 0); background-color: rgba(0, 0, 0, 0);">Luochongjun</span></div><div><span>
</span></div>
<blockquote style="margin-top: 0px; margin-bottom: 0px; margin-left: 0.5em;"><div> </div><div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm"><div style="PADDING-RIGHT: 8px; PADDING-LEFT: 8px; FONT-SIZE: 12px;FONT-FAMILY:tahoma;COLOR:#000000; BACKGROUND: #efefef; PADDING-BOTTOM: 8px; PADDING-TOP: 8px"><div><b>From:</b> <a href="mailto:gch981213@gmail.com">Chuanhong Guo</a></div><div><b>Date:</b> 2019-08-13 14:38</div><div><b>To:</b> <a href="mailto:luochongjun@gl-inet.com">Luochongjun</a></div><div><b>CC:</b> <a href="mailto:openwrt-devel@lists.openwrt.org">openwrt-devel</a></div><div><b>Subject:</b> Re: [OpenWrt-Devel] [PATCH] ath79: add support for gl-ar750</div></div></div><div><div>Hi! Sorry for the late reply.</div>
<div>Here are 3 more nitpickings below:</div>
<div> </div>
<div>On Fri, Jul 26, 2019 at 11:14 AM Luochongjun <luochongjun@gl-inet.com> wrote:</div>
<div>></div>
<div>> This patch supports gl-ar750, which was previously supported by ar71xx.</div>
<div>></div>
<div>> Specification:</div>
<div>> - SOC: QCA9531 (650MHz)</div>
<div>> - Flash: 16 MiB (W25Q128FVSG)</div>
<div>> - RAM: 128 MiB DDR2</div>
<div>> - Ethernet: 10/100: 2xLAN + 10/100: 1xWAN</div>
<div> </div>
<div>A proper VLAN setup for the two LAN ports should be added in</div>
<div>target/linux/ath79/base-files/etc/board.d/02_network.</div>
<div> </div>
<div>> - Wireless: 2.4GHz (bgn) and 5GHz (ac)</div>
<div>> - USB: 1x USB 2.0 port</div>
<div>> - Switch: 1x switch</div>
<div>> - Button: 1x reset button</div>
<div>> - LED: 3x LEDS (white)</div>
<div>></div>
<div>> Flash instruction:</div>
<div>> Support for sysupgrade directive upgrades, as well as luci upgrades.</div>
<div>></div>
<div>> Signed-off-by: Luochongjun <luochongjun@gl-inet.com></div>
<div>> ---</div>
<div>> .../etc/hotplug.d/firmware/11-ath10k-caldata | 1 +</div>
<div>> target/linux/ath79/dts/qca9531_glinet_gl-ar750.dts | 149 +++++++++++++++++++++</div>
<div>> target/linux/ath79/image/generic.mk | 10 ++</div>
<div>> 3 files changed, 160 insertions(+)</div>
<div>> create mode 100644 target/linux/ath79/dts/qca9531_glinet_gl-ar750.dts</div>
<div>></div>
<div>> diff --git a/target/linux/ath79/base-files/etc/hotplug.d/firmware/11-ath10k-caldata b/target/linux/ath79/base-files/etc/hotplug.d/firmware/11-ath10k-caldata</div>
<div>> index 4118685..5c9fa2f 100644</div>
<div>> --- a/target/linux/ath79/base-files/etc/hotplug.d/firmware/11-ath10k-caldata</div>
<div>> +++ b/target/linux/ath79/base-files/etc/hotplug.d/firmware/11-ath10k-caldata</div>
<div>> @@ -117,6 +117,7 @@ case "$FIRMWARE" in</div>
<div>> ath10kcal_extract "art" 20480 2116</div>
<div>> ath10kcal_patch_mac $(macaddr_add $(cat /sys/class/net/eth0/address) +1)</div>
<div>> ;;</div>
<div>> + glinet,gl-ar750|\</div>
<div>> glinet,gl-ar750s)</div>
<div>> ath10kcal_extract "art" 20480 2116</div>
<div>> ath10kcal_patch_mac $(macaddr_add $(mtd_get_mac_binary art 0) +1)</div>
<div>> diff --git a/target/linux/ath79/dts/qca9531_glinet_gl-ar750.dts b/target/linux/ath79/dts/qca9531_glinet_gl-ar750.dts</div>
<div>> new file mode 100644</div>
<div>> index 0000000..b8f9735</div>
<div>> --- /dev/null</div>
<div>> +++ b/target/linux/ath79/dts/qca9531_glinet_gl-ar750.dts</div>
<div>> @@ -0,0 +1,149 @@</div>
<div>> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT</div>
<div>> +/dts-v1/;</div>
<div>> +</div>
<div>> +#include <dt-bindings/gpio/gpio.h></div>
<div>> +#include <dt-bindings/input/input.h></div>
<div>> +</div>
<div>> +#include "qca953x.dtsi"</div>
<div>> +</div>
<div>> +/ {</div>
<div>> + compatible = "glinet,gl-ar750", "qca,qca9531";</div>
<div>> + model = "GL.iNet GL-AR750";</div>
<div>> +</div>
<div>> + keys {</div>
<div>> + compatible = "gpio-keys";</div>
<div>> +</div>
<div>> + pinctrl-names = "default";</div>
<div>> + pinctrl-0 = <&jtag_disable_pins>;</div>
<div>> +</div>
<div>> + reset {</div>
<div>> + label = "reset";</div>
<div>> + linux,code = <KEY_RESTART>;</div>
<div>> + gpios = <&gpio 3 GPIO_ACTIVE_LOW>;</div>
<div>> + };</div>
<div>> +</div>
<div>> + mode {</div>
<div>> + label = "mode";</div>
<div>> + linux,code = <BTN_0>;</div>
<div>> + gpios = <&gpio 0 GPIO_ACTIVE_LOW>;</div>
<div>> + };</div>
<div>> + };</div>
<div>> +</div>
<div>> + leds {</div>
<div>> + compatible = "gpio-leds";</div>
<div>> +</div>
<div>> + power {</div>
<div>> + label = "gl-ar750:white:power";</div>
<div>> + gpios = <&gpio 12 GPIO_ACTIVE_LOW>;</div>
<div>> + default-state = "on";</div>
<div>> + };</div>
<div>> +</div>
<div>> + wlan2g {</div>
<div>> + label = "gl-ar750:white:wlan2g";</div>
<div>> + gpios = <&gpio 14 GPIO_ACTIVE_LOW>;</div>
<div>> + linux,default-trigger = "phy1tpt";</div>
<div>> + };</div>
<div>> +</div>
<div>> + wlan5g {</div>
<div>> + label = "gl-ar750:white:wlan5g";</div>
<div>> + gpios = <&gpio 13 GPIO_ACTIVE_LOW>;</div>
<div>> + linux,default-trigger = "phy0tpt";</div>
<div>> + };</div>
<div>> +</div>
<div>> + };</div>
<div>> +</div>
<div>> + i2c {</div>
<div>> + compatible = "i2c-gpio";</div>
<div>> +</div>
<div>> + sda-gpios = <&gpio 17 GPIO_ACTIVE_LOW>;</div>
<div>> + scl-gpios = <&gpio 16 GPIO_ACTIVE_LOW>;</div>
<div>> + };</div>
<div>> +</div>
<div>> +</div>
<div>> +};</div>
<div>> +</div>
<div>> +&pcie0 {</div>
<div>> + status = "okay";</div>
<div>> +</div>
<div>> + wifi@0,0 {</div>
<div>> + compatible = "qcom,ath10k";</div>
<div>> + reg = <0 0 0 0 0>;</div>
<div>> + device_type = "pci";</div>
<div>> + };</div>
<div>> +};</div>
<div>> +</div>
<div>> +&uart {</div>
<div>> + status = "okay";</div>
<div>> +};</div>
<div>> +</div>
<div>> +&usb0 {</div>
<div>> + #address-cells = <1>;</div>
<div>> + #size-cells = <0>;</div>
<div>> + status = "okay";</div>
<div>> +</div>
<div>> + hub_port: port@1 {</div>
<div>> + reg = <1>;</div>
<div>> + #trigger-source-cells = <0>;</div>
<div>> + };</div>
<div> </div>
<div>This hub_port node is only used for a usb-port LED trigger. It can be</div>
<div>dropped if you don't have a USB LED.</div>
<div> </div>
<div>> +};</div>
<div>> +</div>
<div>> +&usb_phy {</div>
<div>> + status = "okay";</div>
<div>> +};</div>
<div>> +</div>
<div>> +&spi {</div>
<div>> + status = "okay";</div>
<div>> + num-cs = <0>;</div>
<div>> +</div>
<div>> + flash@0 {</div>
<div>> + compatible = "jedec,spi-nor";</div>
<div>> + reg = <0>;</div>
<div>> + spi-max-frequency = <25000000>;</div>
<div>> +</div>
<div>> + partitions {</div>
<div>> + compatible = "fixed-partitions";</div>
<div>> + #address-cells = <1>;</div>
<div>> + #size-cells = <1>;</div>
<div>> +</div>
<div>> + partition@0 {</div>
<div>> + label = "u-boot";</div>
<div>> + reg = <0x000000 0x040000>;</div>
<div>> + read-only;</div>
<div>> + };</div>
<div>> +</div>
<div>> + partition@40000 {</div>
<div>> + label = "u-boot-env";</div>
<div>> + reg = <0x040000 0x010000>;</div>
<div>> + read-only;</div>
<div>> + };</div>
<div>> +</div>
<div>> + art: partition@50000 {</div>
<div>> + label = "art";</div>
<div>> + reg = <0x050000 0x010000>;</div>
<div>> + read-only;</div>
<div>> + };</div>
<div>> +</div>
<div>> + partition@60000 {</div>
<div>> + compatible = "denx,uimage";</div>
<div>> + label = "firmware";</div>
<div>> + reg = <0x060000 0xfa0000>;</div>
<div>> + };</div>
<div>> + };</div>
<div>> + };</div>
<div>> +};</div>
<div>> +</div>
<div>> +ð0 {</div>
<div>> + status = "okay";</div>
<div>> + mtd-mac-address = <&art 0x0>;</div>
<div>> + phy-handle = <&swphy4>;</div>
<div>> +};</div>
<div>> +</div>
<div>> +ð1 {</div>
<div>> + mtd-mac-address = <&art 0x0>;</div>
<div>> + mtd-mac-address-increment = <1>;</div>
<div>> +};</div>
<div>> +</div>
<div>> +&wmac {</div>
<div>> + status = "okay";</div>
<div>> + mtd-cal-data = <&art 0x1000>;</div>
<div>> +};</div>
<div>> diff --git a/target/linux/ath79/image/generic.mk b/target/linux/ath79/image/generic.mk</div>
<div>> index c5807f2..26b700d 100644</div>
<div>> --- a/target/linux/ath79/image/generic.mk</div>
<div>> +++ b/target/linux/ath79/image/generic.mk</div>
<div>> @@ -486,6 +486,16 @@ define Device/glinet_gl-ar300m-nor</div>
<div>> endef</div>
<div>> TARGET_DEVICES += glinet_gl-ar300m-nor</div>
<div>></div>
<div>> +define Device/glinet_gl-ar750</div>
<div>> + ATH_SOC := qca9531</div>
<div>> + DEVICE_VENDOR := GL.iNet</div>
<div>> + DEVICE_MODEL := GL-AR750</div>
<div>> + DEVICE_PACKAGES := kmod-usb2 kmod-ath10k-ct ath10k-firmware-qca9887-ct block-mount</div>
<div> </div>
<div>block-mount shouldn't be included in DEVICE_PACKAGES.</div>
<div> </div>
<div>> + IMAGE_SIZE := 16000k</div>
<div>> + SUPPORTED_DEVICES += gl-ar750</div>
<div>> +endef</div>
<div>> +TARGET_DEVICES += glinet_gl-ar750</div>
<div>> +</div>
<div>> define Device/glinet_gl-ar750s</div>
<div>> ATH_SOC := qca9563</div>
<div>> DEVICE_VENDOR := GL.iNet</div>
<div>> --</div>
<div>> 2.7.4</div>
<div>></div>
<div> </div>
<div>Regards,</div>
<div>Chuanhong Guo</div>
<div> </div>
</div></blockquote>
</body></html>