<div dir="ltr">Adrian-<div>I have a C7V2 and can do some testing on it if you'd explain exactly what you're looking for... I don't quite follow what is needed in the above thread. Something about looking at PCI paths before and after an upgrade from one version to another...</div><div>Camden</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Apr 22, 2019 at 4:45 AM <<a href="mailto:mail@adrianschmutzler.de">mail@adrianschmutzler.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi all,<br>
<br>
> -----Original Message-----<br>
> From: openwrt-devel [mailto:<a href="mailto:openwrt-devel-bounces@lists.openwrt.org" target="_blank">openwrt-devel-bounces@lists.openwrt.org</a>]<br>
> On Behalf Of David Bauer<br>
> Sent: Sonntag, 21. April 2019 15:19<br>
> To: Christian Lamparter <<a href="mailto:chunkeey@gmail.com" target="_blank">chunkeey@gmail.com</a>><br>
> Cc: Adrian Schmutzler <<a href="mailto:freifunk@adrianschmutzler.de" target="_blank">freifunk@adrianschmutzler.de</a>>; openwrt-<br>
> <a href="mailto:devel@lists.openwrt.org" target="_blank">devel@lists.openwrt.org</a>; Tomasz Maciej Nowak <<a href="mailto:tomek_n@o2.pl" target="_blank">tomek_n@o2.pl</a>><br>
> Subject: Re: [OpenWrt-Devel] [PATCH] ath79: Add SUPPORTED_DEVICES for<br>
> Archer C7 v1/v2<br>
> <br>
> Hello Christian,<br>
> <br>
> On 21.04.19 14:17, Christian Lamparter wrote:<br>
> > Hello David,<br>
> ><br>
> > On Sunday, April 21, 2019 11:42:52 AM CEST David Bauer wrote:<br>
> >> On 20.04.19 20:59, Christian Lamparter wrote:<br>
> >>> On Wednesday, April 17, 2019 3:45:52 PM CEST Adrian Schmutzler wrote:<br>
> >>>> The identifier for both devices is "archer-c7" on ar71xx, set here:<br>
> >>>><br>
> <a href="https://github.com/openwrt/openwrt/blob/master/target/linux/ar71xx/" rel="noreferrer" target="_blank">https://github.com/openwrt/openwrt/blob/master/target/linux/ar71xx/</a><br>
> >>>> base-files/lib/ar71xx.sh#L348<br>
> >>>><br>
> <a href="https://github.com/openwrt/openwrt/blob/master/target/linux/ar71xx/" rel="noreferrer" target="_blank">https://github.com/openwrt/openwrt/blob/master/target/linux/ar71xx/</a><br>
> >>>> base-files/lib/ar71xx.sh#L511<br>
> >>>><br>
> >>>> Signed-off-by: Adrian Schmutzler <<a href="mailto:freifunk@adrianschmutzler.de" target="_blank">freifunk@adrianschmutzler.de</a>><br>
> >>>> ---<br>
> >>>> target/linux/ath79/image/<a href="http://generic-tp-link.mk" rel="noreferrer" target="_blank">generic-tp-link.mk</a> | 2 ++<br>
> >>>> 1 file changed, 2 insertions(+)<br>
> >>>><br>
> >>>> diff --git a/target/linux/ath79/image/<a href="http://generic-tp-link.mk" rel="noreferrer" target="_blank">generic-tp-link.mk</a><br>
> >>>> b/target/linux/ath79/image/<a href="http://generic-tp-link.mk" rel="noreferrer" target="_blank">generic-tp-link.mk</a><br>
> >>>> index 6853f12341..db1eabd420 100644<br>
> >>>> --- a/target/linux/ath79/image/<a href="http://generic-tp-link.mk" rel="noreferrer" target="_blank">generic-tp-link.mk</a><br>
> >>>> +++ b/target/linux/ath79/image/<a href="http://generic-tp-link.mk" rel="noreferrer" target="_blank">generic-tp-link.mk</a><br>
> >>>> @@ -70,6 +70,7 @@ define Device/tplink_archer-c7-v1<br>
> >>>> DEVICE_TITLE := TP-Link Archer C7 v1<br>
> >>>> DEVICE_PACKAGES := kmod-usb-core kmod-usb2 kmod-usb-ledtrig-<br>
> usbport kmod-ath10k-ct ath10k-firmware-qca988x-ct<br>
> >>>> TPLINK_HWID := 0x75000001<br>
> >>>> + SUPPORTED_DEVICES += archer-c7<br>
> >>>> endef<br>
> >>>> TARGET_DEVICES += tplink_archer-c7-v1<br>
> >>>><br>
> >>>> @@ -79,6 +80,7 @@ define Device/tplink_archer-c7-v2<br>
> >>>> DEVICE_TITLE := TP-Link Archer C7 v2<br>
> >>>> DEVICE_PACKAGES := kmod-usb-core kmod-usb2 kmod-usb-ledtrig-<br>
> usbport kmod-ath10k-ct ath10k-firmware-qca988x-ct<br>
> >>>> TPLINK_HWID := 0xc7000002<br>
> >>>> + SUPPORTED_DEVICES += archer-c7<br>
> >>> In case of the v2, I think there's still the problem that a straight<br>
> >>> up upgrade from ar71xx to ath79 will affect the 5GHz ath10k wireless<br>
> >>> because it now has a new device path and hence a new default<br>
> >>> configuration (where the card is<br>
> >>> disabled) is created.<br>
> >><br>
> >> I recall upgrading my OCEDO Koala (which uses the same 9558/9880<br>
> >> combo) from ar71xx to ath79 and the PCIe path being consistent on both<br>
> platforms.<br>
> >><br>
> >> This however might have changed in the meantime, so someone should<br>
> >> probably confirm this with a real C7.<br>
> ><br>
> > On my C7 v1 with a QCA9880v2 the ar71xx installation back in<br>
> > 2018-08-17 looked like this:<br>
> ><br>
> > config wifi-device 'radio0'<br>
> > option type 'mac80211'<br>
> > option country 'DE'<br>
> > option channel 'auto'<br>
> > option hwmode '11g'<br>
> > option path 'platform/qca955x_wmac'<br>
> > option htmode 'HT20'<br>
> > option disabled '0'<br>
> > option txpower '10'<br>
> ><br>
> > config wifi-device 'radio1'<br>
> > option type 'mac80211'<br>
> > option channel '52'<br>
> > option country 'DE'<br>
> > option hwmode '11a'<br>
> > option path 'pci0000:01/0000:01:00.0'<br>
> > option htmode 'VHT80'<br>
> > option disabled '0'<br>
> > option txpower '14'<br>
> ><br>
> > vs ath79 (today):<br>
> ><br>
> > config wifi-device 'radio0'<br>
> > option type 'mac80211'<br>
> > option country 'DE'<br>
> > option channel 'auto'<br>
> > option hwmode '11g'<br>
> > option path 'platform/ahb/ahb:apb/18100000.wmac'<br>
> > option htmode 'HT20'<br>
> > option disabled '0'<br>
> > option txpower '10'<br>
> ><br>
> > config wifi-device 'radio1'<br>
> > option type 'mac80211'<br>
> > option channel '52'<br>
> > option country 'DE'<br>
> > option hwmode '11a'<br>
> > option path 'pci0000:00/0000:00:00.0'<br>
> > option htmode 'VHT80'<br>
> > option disabled '0'<br>
> > option txpower '14'<br>
> ><br>
> > so the path changed from "pci0000:01/0000:01:00.0" to<br>
> > "pci0000:00/0000:00:00.0". But again this is on a C7 v1.<br>
> ><br>
> > Based on the bootlog on the wiki for 18.06.1 :<br>
> > <a href="https://openwrt.org/toh/tp-link/archer-c7-1750#boot_logs" rel="noreferrer" target="_blank">https://openwrt.org/toh/tp-link/archer-c7-1750#boot_logs</a><br>
> > The ar71xx image enabling both pcie Root Complexes of the QCA955x.<br>
> > But unfortunately the pcie slot of the C7 is wired to the second RC,<br>
> > so the ath10k card gets pci0000:01/0000:01:00.0. Does anybody want to<br>
> > test what happens if the ath79 C7 v2 DTS enables "pcie0" too? It might<br>
> > work, but it might not (depending on whenever it might end up in a<br>
> > different pci domain like pci0001:00.).<br>
> <br>
> Damn, you are right. The Koala has it's only PCIe endpoint wired to the first<br>
> bus, so this works fine.<br>
> <br>
> Regarding enabling the first bus: Personally, I would prefer a migration script<br>
> over enabling a non-wired interface. There is already a migration script for<br>
> exactly this case in the mpc85xx target, so most of this work is probably<br>
> straight up copy-paste ;)<br>
> <br>
> Best wishes<br>
> David<br>
<br>
I normally do not care about the config-upgrade as I do it manually with custom scripts, partially relying on default config after upgrade.<br>
<br>
My patch was only meant to fix image-check.<br>
If the discussed upgrade-issue is considered a requirement for enabling SUPPORTED_DEVICES, I will have to wait for someone to test on C7v2.<br>
<br>
Best<br>
<br>
Adrian<br>
<br>
<br>
> <br>
> _______________________________________________<br>
> openwrt-devel mailing list<br>
> <a href="mailto:openwrt-devel@lists.openwrt.org" target="_blank">openwrt-devel@lists.openwrt.org</a><br>
> <a href="https://lists.openwrt.org/mailman/listinfo/openwrt-devel" rel="noreferrer" target="_blank">https://lists.openwrt.org/mailman/listinfo/openwrt-devel</a><br>
_______________________________________________<br>
openwrt-devel mailing list<br>
<a href="mailto:openwrt-devel@lists.openwrt.org" target="_blank">openwrt-devel@lists.openwrt.org</a><br>
<a href="https://lists.openwrt.org/mailman/listinfo/openwrt-devel" rel="noreferrer" target="_blank">https://lists.openwrt.org/mailman/listinfo/openwrt-devel</a><br>
</blockquote></div>