[From nobody Thu Jun 25 05:54:57 2020
Received: from smtp-eu21.fugro.com ([46.34.88.152])
 by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux))
 id 1gWL03-0007wM-SA
 for openwrt-devel@lists.openwrt.org; Mon, 10 Dec 2018 12:49:30 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=fugro.com; i=@fugro.com; q=dns/txt; s=mail1;
 t=1544446167; x=1575982167; h=from:to:subject:date:message-id:
 content-transfer-encoding:mime-version;
 bh=iDi/OYeS25nySGMVLRgD3MMqCI34dk9kbn+0+6FehYI=;
 b=Gq54lrW0FK4Vzdhw23lrgPTXUXfviMQLUUrtEEdeLEs24wuvRCqud92X
 2tHCOlBwn8wZVFgr9uFhEFUQ+HZMJupXnr+Wl0FPQBfYs+pTPhDMBQt3w
 Vz+qa+JZ7o37VDaOJ8KpZ+b8xIMs7lzc2dL2066nvO9erewBEyYuVNTaS
 vt4+r5agEJNhTLp1TOiJGI1xGoQnse1l3Oo1nvpKdysYY+7aXirQ/S5tz
 glfk17e4nUFP1ZFQaX+YBQWCYN2tC/ZMBJ77EDCCdAbej7kY8J0/vcy3h
 xU+OOGco5F5fC8zCY+oIqRD5K5WEay6xCAXs/59Q3EbSUNn4fj0Gm9lTk Q==;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2H7AABLXw5c/z4AHaxjHQEBBQEHBQG?=
 =?us-ascii?q?BVAUBCwGBMFCBWQMEMgqHNwOQE4JXmUMJDAEYFIRAAoNNNwYNAQMBAQEBAQE?=
 =?us-ascii?q?CAQECaR0LgjYigmUBAQIDAYEEBgEIDQQEAQEBJy8KFAkJAQQTCBODBoICAQO?=
 =?us-ascii?q?aBgKMJhoCigIJAYJ0ins+gVeBTn6EWimDM4ImApACkHMDBAICjS6EN4lmJAO?=
 =?us-ascii?q?HMIkij2cCBAIEBQINAQEFgVwjKIEucIM8kFtAATFNW4lbgS4BgR4BAQ?=
X-IPAS-Result: =?us-ascii?q?A2H7AABLXw5c/z4AHaxjHQEBBQEHBQGBVAUBCwGBMFCBW?=
 =?us-ascii?q?QMEMgqHNwOQE4JXmUMJDAEYFIRAAoNNNwYNAQMBAQEBAQECAQECaR0LgjYig?=
 =?us-ascii?q?mUBAQIDAYEEBgEIDQQEAQEBJy8KFAkJAQQTCBODBoICAQOaBgKMJhoCigIJA?=
 =?us-ascii?q?YJ0ins+gVeBTn6EWimDM4ImApACkHMDBAICjS6EN4lmJAOHMIkij2cCBAIEB?=
 =?us-ascii?q?QINAQEFgVwjKIEucIM8kFtAATFNW4lbgS4BgR4BAQ?=
X-IronPort-AV: E=Sophos;i="5.56,338,1539648000"; d="scan'208";a="20109914"
X-IRP-Internal: 1
X-IRP-FugroSender: 200661
Received: from unknown (HELO mail.fugro.com) ([172.29.0.62])
 by smtp-eu21.fugro.com with ESMTP/TLS/AES256-SHA; 10 Dec 2018 12:48:33 +0000
Received: from nldataex01.ad.fugro.com (172.29.0.61) by
 nldataex02.ad.fugro.com (172.29.0.62) with Microsoft SMTP Server (TLS) id
 15.0.1367.3; Mon, 10 Dec 2018 13:48:33 +0100
Received: from NAM05-CO1-obe.outbound.protection.outlook.com (104.47.48.56) by
 nldataex01.ad.fugro.com (172.29.0.61) with Microsoft SMTP Server
 (TLS) id
 15.0.1367.3 via Frontend Transport; Mon, 10 Dec 2018 13:48:33 +0100
Received: from BN6PR11MB1969.namprd11.prod.outlook.com (10.175.100.146) by
 BN6PR11MB1538.namprd11.prod.outlook.com (10.172.22.141) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.1404.22; Mon, 10 Dec 2018 12:47:13 +0000
Received: from BN6PR11MB1969.namprd11.prod.outlook.com
 ([fe80::f5e7:6655:5ba1:7f]) by BN6PR11MB1969.namprd11.prod.outlook.com
 ([fe80::f5e7:6655:5ba1:7f%7]) with mapi id 15.20.1404.026; Mon, 10 Dec 2018
 12:47:13 +0000
From: "Hattink, Tjalling" <t.hattink@fugro.com>
To: "openwrt-devel@lists.openwrt.org" <openwrt-devel@lists.openwrt.org>
Subject: RE: [OpenWrt-Devel] [PATCH] procd: remove /dev filter on uevents
Thread-Topic: [OpenWrt-Devel] [PATCH] procd: remove /dev filter on uevents
Thread-Index: AdSQhncUWtIwCiwOQ020uIF+HjPKhg==
Date: Mon, 10 Dec 2018 12:47:13 +0000
Message-ID: <BN6PR11MB19696E9AF6D8D70AAE95B054E3A50@BN6PR11MB1969.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=t.hattink@fugro.com; 
x-originating-ip: [185.46.212.75]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; BN6PR11MB1538;
 6:kKlXnT/aBILa441dTozO8xMa+1/EkupariPOD3qM0MlWGQHkvHs4mL9Tzx4Z9hJj1MEC4lO/a1AMpBUJMJln40apSjZak8fuVkK6gtTHtc5khAE1iOuhbrMYcV4jt2TIh0yNv3kLswwa2ko6ZxBmQjJRHgyNtI8tvvFhAWDFGObAbYrlEw+KtQvQgeiSk1hwhq5NbqPeP6QAR12jtWK3SoCZLfWXc6AHgqHwz26QczM1S3taivcsCxmFGYC8r6efrJson9SuJH/kppfFVZAcQwKlZA/8XhGF+e0zTdGyd/1XdUPZcAIhLF/qJBUN7fi95KwMlwytrFxYRUgEUIixUwmFg78Cn2qjdSRbpw99tWq0+d9sYA+7Qs9ShKa739j8DrB/Q1ZvDTek4DYtBrFnjzAeHa02dz8n45sePuDIILdC5Dq0EFRNhVuhknKnimrJifkPHw8tG7WNkMtMujG4Hw==;
 5:rk+TYUgn8uQOCe/W0R67HNpBG1fuizEWZDelHEliJ6OsZBsEi6Y3YC6/rkJXKOJ7If3B+8jDwQiFRpr01m5sC0ZL41NyzFhAm2aFLDwISL66sHoizP6A3DqiS3+DuMuODgCkDTqzvxBoqPOxxMVVvE9I73r1ekldjmF7irwm0CI=;
 7:zDyY49oXFjs/GkX6OzvNOPAQGvr9TvrGHSYP+9fP+Ez4a5jYAsaMHl5NO4QL7dO8vzI/tJdMUl4DN9mKnsX/JhcLNH4mhNI2OB4Mlm4Fm6VVpZm1xQwQ0E2U6HcljEL5cUjcXQhP4hLwWuRqDidviw==
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-correlation-id: 0eef068c-db44-4e50-5cd3-08d65e9d9bab
x-microsoft-antispam: BCL:0; PCL:0;
 RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020);
 SRVR:BN6PR11MB1538; 
x-ms-traffictypediagnostic: BN6PR11MB1538:
x-microsoft-antispam-prvs: <BN6PR11MB1538ACACDF270DA972109B31E3A50@BN6PR11MB1538.namprd11.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0;
 RULEID:(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231455)(999002)(944501520)(52105112)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201708071742011)(7699051)(76991095);
 SRVR:BN6PR11MB1538; BCL:0; PCL:0; RULEID:; SRVR:BN6PR11MB1538; 
x-forefront-prvs: 08828D20BC
x-forefront-antispam-report: SFV:NSPM;
 SFS:(10019020)(39860400002)(346002)(396003)(136003)(366004)(376002)(13464003)(199004)(189003)(256004)(2351001)(186003)(6436002)(74316002)(105586002)(305945005)(316002)(106356001)(476003)(486006)(6916009)(86362001)(68736007)(478600001)(66066001)(7736002)(25786009)(97736004)(229853002)(71190400001)(14454004)(6246003)(5640700003)(26005)(9686003)(55016002)(33656002)(71200400001)(53936002)(5660300001)(99286004)(2501003)(2906002)(3846002)(6116002)(102836004)(6506007)(53546011)(81156014)(81166006)(8936002)(8676002)(7696005);
 DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR11MB1538;
 H:BN6PR11MB1969.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en;
 PTR:InfoNoRecords; A:1; MX:1; 
received-spf: None (protection.outlook.com: fugro.com does not designate
 permitted sender hosts)
x-microsoft-antispam-message-info: gRBWgHb0+S+MMBQlYu6cLLKY53GviB3EqV20FiE1fmcSS3MKXUo26fifxCaPSir8YJx5adDoADYj4a7P/v2L07I20+crgdee4t2pk6fhPURuhU9nBvz4hll55voF2cf/g0ko8hmpPmkzhXAX3Rddow8d5JU6skVbrQnAdJl0Yt2Ayw6aMdTnHqNZxOuqEFNnnItT+nh8bhwM0V+oPiEiDuFk04zLlgCT2wfqzJQZPjOz5ou8gJ1RmbVpk/rGUPiFaT1CuzAGkdti+VzICNMKnBcER+yQYikCoITiHryUs1WYJjBX8RSPadATMG+j1Ztl
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0eef068c-db44-4e50-5cd3-08d65e9d9bab
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Dec 2018 12:47:13.2788 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: e3b48527-4cbe-42a2-b4d2-11b3cc7a86fc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1538
X-OriginatorOrg: fugro.com
X-TM-AS-Product-Ver: SMEX-12.0.0.1727-8.200.1013-24276.007
X-TM-AS-Result: No--15.458300-8.000000-31
X-TM-AS-MatchedID: 150567-139010-139006-711995-106660-106420-700075-710970-7
 03788-700560-705431-704156-700693-700546-105700-712032-708712-110462-704240
 -702187-700476-701837-706719-705102-702609-707788-780011-712052-703099-7104
 42-704980-701099-704034-110037-708339-702836-702050-705901-702872-702829-71
 0233-701928-701373-705388-707997-703586-702067-703267-700752-703045-704859-
 303424-148004-148007-148020-148051-20043-42000-42003-63
X-TM-AS-User-Approved-Sender: No
X-TM-AS-User-Blocked-Sender: No
X-Bad-Reply: 'Re:' in Subject but no References or In-Reply-To headers
X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 
X-CRM114-CacheID: sfid-20181210_044928_207606_D1B30F1A 
X-CRM114-Status: GOOD (  19.05  )
X-Spam-Score: -2.5 (--)
X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary:
 Content analysis details:   (-2.5 points)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -2.3 RCVD_IN_DNSWL_MED      RBL: Sender listed at http://www.dnswl.org/,
 medium trust [46.34.88.152 listed in list.dnswl.org]
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
 author's domain
 0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily
 valid
 -0.1 DKIM_VALID_EF          Message has a valid DKIM or DK signature from
 envelope-from domain
 -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature

> -----Original Message-----
> From: John Crispin [mailto:john@phrozen.org]
> Sent: Friday, December 7, 2018 19:39
> To: Hattink, Tjalling <t.hattink@fugro.com>; openwrt-
> devel@lists.openwrt.org
> Subject: Re: RE: [OpenWrt-Devel] [PATCH] procd: remove /dev filter on
> uevents
>=20
>=20
> On 07/12/2018 11:11, Hattink, Tjalling wrote:
> >> -----Original Message-----
> >> From: openwrt-devel [mailto:openwrt-devel-
> bounces@lists.openwrt.org]
> >> On Behalf Of Jo-Philipp Wich
> >> Sent: Friday, December 7, 2018 10:51
> >> To: openwrt-devel@lists.openwrt.org
> >> Subject: Re: [OpenWrt-Devel] [PATCH] procd: remove /dev filter on
> >> uevents
> >>
> >> Hi,
> >>
> >> I had a brief discussion with John on this matter and was being told
> >> that the reason for this filter was to optimize boot time.
> >>
> >> When we remove the /dev filter, boot time will increase considerably
> >> on lower end devices due to the resulting hotplug-call overhead of
> >> the huge volume of additional uevents.
> >>
> >> A better approach here would be to selectively whitelist uevents
> >> based on subsystem or similar attributes, e.g. `DEVTYPE=3Dusb_device`.
> >>
> >> ~ Jo
> > I can imagine that this would increase boot times on low end devices.
> > Looking at the commit message introducing the filter it seems to cut
> > down the amount of events by half.
> >
> > How about adding a compile option to procd that enables/disables this
> > filter. So by default this filter is enabled, but using a makemenu
> > option in the procd configuration (similar as "Mount /tmp using zram"
> > option) you would be able to disable the filter for high-end boards
> > that require it. This would be fairly easy to implement.
> >
> > Best regards,
> > Tjaling Hattink
>=20
> Hi,
>=20
> I actually have a rather strong opinion on this one and would prefer to
> hardcode uevents that we want to opt-in as Jo suggested. compile time
> options do look nice, but we have a trizillion of them already and they p=
er
> default are not enabled in binary releases making them virtually useless =
to
> anyone that was not involved in adding them to the tree.
>=20
>  =A0=A0=A0 John

Hi,

Very valid point. This would be the most clean solution when the hotplug sc=
ripts
themselves would indicate which uevents they want to trigger on. This could
also make hotplug itself more efficient if it has lists of uevents and scri=
pts it
should fire, instead of firing all scripts and see if one of them acts on i=
t.

Unfortunately I will not get the time from my employer to work on such a
system, so I cannot provide follow-up patches. I hope someone else can=20
eventually pick this up. Until then we will rework our hotplug scripts to
somehow get triggered on this limited set of uevents.

Best regards,
Tjalling Hattink


]