[From nobody Thu Jun 25 05:54:56 2020 Received: from smtp-eu21.fugro.com ([46.34.88.152]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gVD6q-0004NC-0W for openwrt-devel@lists.openwrt.org; Fri, 07 Dec 2018 10:11:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fugro.com; i=@fugro.com; q=dns/txt; s=mail1; t=1544177508; x=1575713508; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=+31xyZleLqzCQ5cof1BaVf5Pb0EyJRchiLlse5O2WuQ=; b=Q/JjIUdgh+gal7qezXk/nHECtdINqcCJGi0nRS/StJHBVwhcZVI0r7qj kAo1I7hb8AfLT5yV7C9LteeLlTsrOFaBVZT1eKdql9qDoJ2A5k/0DP3nY TKqtsZ6mARNoIP0FprAohr6nGDwKeWwIksZruKKfq0kAw48QVNXen6HAI rgscbzHhLkmLRShwnsPtbDyfiXxytJ3PUyZFys0TFZIkpS+lAQQCDMagj oDR1jo5UeslP5pw9NdosnhoiYqbEbV2ET2ThRI70Hpqy4yUF2SbBTwMuf CYzubuLdvGKqOflxMlpIfPvf8ZDqNfrzz3A4GecwH9Y42+R7j0wp1VAZR g==; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2FTAABNRgpc/z4AHaxiHAEBAQQBAQc?= =?us-ascii?q?EAQGBUwUBAQsBgTBQgVwEMgqHNwOQFYJXl1CBcAoMARgUhEACgzo2Bw0BAwE?= =?us-ascii?q?BAQEBAQIBAQJpHQuCNiKCZQEBAQEDATlLBAIBCA0EBAEBHwkHKAoUCQgCBBM?= =?us-ascii?q?IgxmCAgEDmhcCjCYaAooTCQGCdIp5PoFXgU5+hQODM4ImAqBiAwQCAo0qhDa?= =?us-ascii?q?JYiQDhy2JD49kAgQCBAUCDQEBBYFNBiyBVXCDPJBbQAExTVuIfwGBHgEB?= X-IPAS-Result: =?us-ascii?q?A2FTAABNRgpc/z4AHaxiHAEBAQQBAQcEAQGBUwUBAQsBg?= =?us-ascii?q?TBQgVwEMgqHNwOQFYJXl1CBcAoMARgUhEACgzo2Bw0BAwEBAQEBAQIBAQJpH?= =?us-ascii?q?QuCNiKCZQEBAQEDATlLBAIBCA0EBAEBHwkHKAoUCQgCBBMIgxmCAgEDmhcCj?= =?us-ascii?q?CYaAooTCQGCdIp5PoFXgU5+hQODM4ImAqBiAwQCAo0qhDaJYiQDhy2JD49kA?= =?us-ascii?q?gQCBAUCDQEBBYFNBiyBVXCDPJBbQAExTVuIfwGBHgEB?= X-IronPort-AV: E=Sophos;i="5.56,326,1539648000"; d="scan'208";a="19946386" X-IRP-Internal: 1 X-IRP-FugroSender: 200661 Received: from unknown (HELO mail.fugro.com) ([172.29.0.62]) by smtp-eu21.fugro.com with ESMTP/TLS/AES256-SHA; 07 Dec 2018 10:11:32 +0000 Received: from nldataex01.ad.fugro.com (172.29.0.61) by nldataex02.ad.fugro.com (172.29.0.62) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 7 Dec 2018 11:11:31 +0100 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (104.47.49.51) by nldataex01.ad.fugro.com (172.29.0.61) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Fri, 7 Dec 2018 11:11:31 +0100 Received: from BN6PR11MB1969.namprd11.prod.outlook.com (10.175.100.146) by BN6PR11MB2049.namprd11.prod.outlook.com (10.173.26.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1404.19; Fri, 7 Dec 2018 10:11:29 +0000 Received: from BN6PR11MB1969.namprd11.prod.outlook.com ([fe80::f5e7:6655:5ba1:7f]) by BN6PR11MB1969.namprd11.prod.outlook.com ([fe80::f5e7:6655:5ba1:7f%7]) with mapi id 15.20.1404.021; Fri, 7 Dec 2018 10:11:29 +0000 From: "Hattink, Tjalling" <t.hattink@fugro.com> To: "openwrt-devel@lists.openwrt.org" <openwrt-devel@lists.openwrt.org> Subject: RE: [OpenWrt-Devel] [PATCH] procd: remove /dev filter on uevents Thread-Topic: [OpenWrt-Devel] [PATCH] procd: remove /dev filter on uevents Thread-Index: AQHUjhG1JvPydTQzQ0ixcf8Qt50qvKVzCKkAgAADaeA= Date: Fri, 7 Dec 2018 10:11:28 +0000 Message-ID: <BN6PR11MB19694BB7A3799A38F8BAC397E3AA0@BN6PR11MB1969.namprd11.prod.outlook.com> References: <mailman.7032.1544175957.2376.openwrt-devel@lists.openwrt.org> <424161b8-2d5c-42c8-51ed-3b037eae208d@wwsnet.net> In-Reply-To: <424161b8-2d5c-42c8-51ed-3b037eae208d@wwsnet.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=t.hattink@fugro.com; x-originating-ip: [185.46.212.75] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BN6PR11MB2049; 6:QM9pclQeQ7wRhDPk5M6BCOH4/u2UILdIVdgx44Qk5peXaUatcTJUj5SkN81IKf/JL46lCbMDxl4uv5paqxpngFkEZ9RiSmEBRuPf1JfiCJkiA67iKqGmwmisaCDlM0bqa4Tpxos/7Dp7/lOOOJa2cEyN811EciPZBTH1FvuzsksWWVFlWR2XlQfPYVZ/uPI9KtXbKk+EBwkIhorGfgLahp4rFT0vNX4qLixxHq1EO69XLUK9/Hh8xL1d4+EAuEwQOe9Pe/HG4y3VcpFY0ghiGtCxVGvesJ7W+xSJd0OijdfaO8EVMHUQiqrQIh+JzNGqNtH/5ktPuyR7IkMVZX/eoIWCp28AuKdBCieZtAHejRZ7RjQRdr1Xvv65eEr12Bker2wQ4ZH3lNXn2ELVXCnDE7eqthNnWmK1KRWs3nwwVKOPTWOple0+UPibwuqF6iyGvqmS36TNfZEBWp+vtV6hiw==; 5:/ggxHbeUqvdGzB0N0zfsg/z0LxZx8WpfbXtjAiGt7pj2+oG/JyZBAc2ULbRlRCoDXSx6PewlDZwoGE/LQktDAa+MXdhif7NRtWkGfWBxzv/7NQl2oXXZ2fo/B1cPbd59QS2MmvDBeqkWT7duC47zFVNJ/YVVEsUXNgSe4ZR9LIE=; 7:+yd0Iy/8pglRRs7BVVuPtWgv1dbprAIP3UbdDDR3qL83YJldYnf/y2rDvByJx02qNrdfvK2dAz5InoWkLcpa9A7n7hrlGDRxfMZiS1VGuJgb5HZUnZwn5dRoTzZL2fUL7nG+9L85SvBFZ6q99h3D6Q== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 5693ba5f-9405-4da9-d1d7-08d65c2c5acf x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BN6PR11MB2049; x-ms-traffictypediagnostic: BN6PR11MB2049: x-microsoft-antispam-prvs: <BN6PR11MB20494BE1B76000FE699799A2E3AA0@BN6PR11MB2049.namprd11.prod.outlook.com> x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(3231455)(999002)(944501520)(52105112)(93006095)(93001095)(3002001)(10201501046)(148016)(149066)(150057)(6041310)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:BN6PR11MB2049; BCL:0; PCL:0; RULEID:; SRVR:BN6PR11MB2049; x-forefront-prvs: 0879599414 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(376002)(136003)(366004)(346002)(396003)(199004)(189003)(13464003)(6116002)(2501003)(229853002)(86362001)(3846002)(25786009)(6436002)(105586002)(305945005)(2906002)(2351001)(316002)(6916009)(68736007)(106356001)(74316002)(7736002)(14454004)(9686003)(11346002)(446003)(6506007)(486006)(476003)(5660300001)(53546011)(55016002)(53936002)(26005)(256004)(102836004)(478600001)(76176011)(7696005)(5640700003)(33656002)(71200400001)(71190400001)(99286004)(97736004)(186003)(81156014)(81166006)(8936002)(8676002)(6246003)(66066001); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR11MB2049; H:BN6PR11MB1969.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: fugro.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 1SqOf+rakSOV5+cxjUhgaXVTWxLa7fZhkqu75OLERQKpf+TKtE59PU2FVIcGUNln0uerpUv304QBvRhmJimP3yWlldp38A5/6qvzlMsvIz7dpnt3OSUlblLXq9RojC50Ge/LakRxiWUrr0dGZ6XJHK8Ca3mLn8PL/AM4VT9YQo0XDQEoVPrvLtqqWPNlYpZipdwuiKh5rbxOkFbjNobgCU5rxhBlCpkd6VoqnW39B3loGZUrryGpW+ID3Po36QEPcuytKe9CiL1L5camT+h8vGj4jS08JJmQcNBixXsSWYmX0U0cVGGRjq8AVFugXBD7rkvhLAvnV7pgdMqvZ1yOo5JrMoORCw3S2+6pyj9s/mg= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 5693ba5f-9405-4da9-d1d7-08d65c2c5acf X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2018 10:11:28.9667 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: e3b48527-4cbe-42a2-b4d2-11b3cc7a86fc X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB2049 X-OriginatorOrg: fugro.com X-TM-AS-Product-Ver: SMEX-12.0.0.1727-8.200.1013-24268.005 X-TM-AS-Result: No--0.848100-8.000000-31 X-TM-AS-MatchedID: 150567-139010-139006-711995-106660-106420-710970-703788-7 00560-705431-704156-700693-700546-105700-712032-708712-704240-702187-700476 -701837-706719-705102-702609-707788-780011-712052-703099-710442-148004-1480 07-148020-148050-42000-42003-63 X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181207_021148_358119_86E42F01 X-CRM114-Status: GOOD ( 10.18 ) X-Spam-Score: -2.5 (--) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-2.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [46.34.88.152 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain > -----Original Message----- > From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org] > On Behalf Of Jo-Philipp Wich > Sent: Friday, December 7, 2018 10:51 > To: openwrt-devel@lists.openwrt.org > Subject: Re: [OpenWrt-Devel] [PATCH] procd: remove /dev filter on uevents >=20 > Hi, >=20 > I had a brief discussion with John on this matter and was being told that= the > reason for this filter was to optimize boot time. >=20 > When we remove the /dev filter, boot time will increase considerably on > lower end devices due to the resulting hotplug-call overhead of the huge > volume of additional uevents. >=20 > A better approach here would be to selectively whitelist uevents based on > subsystem or similar attributes, e.g. `DEVTYPE=3Dusb_device`. >=20 > ~ Jo I can imagine that this would increase boot times on low end devices. Looking at the commit message introducing the filter it seems to cut down the amount of events by half. How about adding a compile option to procd that enables/disables this filter. So by default this filter is enabled, but using a makemenu option in the procd configuration (similar as "Mount /tmp using zram" option) you would be able to disable the filter for high-end boards that require it. This would be fairly easy to implement. Best regards, Tjaling Hattink ]