[From nobody Thu Jun 25 05:54:55 2020 Received: from sonic315-20.consmr.mail.ne1.yahoo.com ([66.163.190.146]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gQd9m-0004wA-Ml for openwrt-devel@lists.openwrt.org; Sat, 24 Nov 2018 18:59:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1543085980; bh=HAESNRL3EmTjoMrdnAZi9CuTazqnyuaWa/S5y1yf8aM=; h=Date:From:To:Cc:Subject:References:From:Subject; b=aSADw/HH2giymlmKG12GrTCyLi2YhjfFz1wKgZCqZvsf0fVAgod9ONysaFfSwPmrFK1gPBb9XeoQc4TbajyaKviHa6+qSjg6ir7a5DSIcEZx96OzsW9I6Lwjb+Vun0hydkm1+DfMgGGJvnKbdf95xtFlesTk/7fOXabyB8IaMebmIedKP2QC8MkBGdbkzk37Nx6qoDJ1oIMMs/VBQ3Q7yMoZEyDNOxWLyPu17wGo6zNXeJEpIgKuOJC3gsphr4MENDaRwdXJVCPFtY0p9YNvepEuaujdL0REbRRzYm/4064DnekWmB8vi5JX9cXbRtLDfXUuai5VBLr6WbrC4nSekA== X-YMail-OSG: yTPGM0cVM1mLQYCobcgI3nMWfIdrcYabfb7ee8wxmp4erChuAznMqCh1DBbG8kb uS7y_eEpa1C2cbJcQBFfp_FfBL2ONYnlK6Y_BJd45xIUM1p_WtiqP4s11aZK375djIwBw30972W8 149_r..zHVzlRKQ2M4pAIcgGqWfphwuU3hyopggtOJV2lir7sWwItYQRPO86J5KUIxpdP0q1GlSJ U1QafYzRuIqFHuIpvh6ZJlWy7K9mD5w77ExburK6MWfhLQ6psv6ohlKbFlHLIveEM_R1_QycIjW8 ONfqBWyCFfY2UrPSFxiTaKYU7Mc_Rt86Al7vxUISaZFrRvZ.InQF.UjzZum3_Dt541suChq6u97F 5LR2SYzib_LTmbvCFwBAVGwYflSpS3_jbI6cYi47z1sEuBXOM4_FTTHtoHJU8DmRSZyaHdLgA..Q h3j4ghpd_Zkb7WDLM9YulwEr69_xq7WUXrMvlWAxGlzwtb3NTl9hDfRmkEz0289kz1NL9gCvPoWV CCFgQQdVDeX8oP5TX_mdKhn6gVEphab9OMm4GDKJFKexLlffmREVr79ixQd1LTSMpvZxtP1I1M2r rjMZtemsNX3VnRmche39KQod_.Tsaznzl7hZLzcjWaeEmPQ09CPIWEE3_vdUYirOQiwDQYCzK0.e iL6ZDG0rC5Yr4KY1x3imMXq_PdyCnGnEJcXcLdZ6dZrO9J65TZbEj5RhBzqgYjt5E5Bc_Awz3du. EnJtqGtI55iVPgRsRi7NqK7bnOPRopG4O4lpJ.pFfx0LL.WcTqtDVs5U1OBvkti6tA9a78eWodqv vpu22PMtmCfODNr.48uCiuDIYsf4WO_3OnOJ5.FVX_vGDa58c.CfobRXgLnRa6W7LKzNkKGEPZPz .DyuJPZyBNc6dWoHya4aNeCpLiZqVzKkDTaGFiuxkrhCtC78xdxB2mepgTzvdE.Yg.UzzxEOYP0G tjLWGfPdlie1dlnrrO8bvanNhZsO4LsGQPAl4TGOmvIK5cT9_ickTO0VF7_p08Bs427KyObpefnD FGmUaQiJprjycuc8yO3g- Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.ne1.yahoo.com with HTTP; Sat, 24 Nov 2018 18:59:40 +0000 Date: Sat, 24 Nov 2018 18:59:02 +0000 (UTC) From: Eneas Ulir de Queiroz <cote2004-github@yahoo.com> To: Hauke Mehrtens <hauke@hauke-m.de> Cc: openwrt-devel@lists.openwrt.org Message-ID: <1377035907.2058763.1543085942712@mail.yahoo.com> Subject: Re: [PATCH] cryptodev-linux: move from packages feed MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable References: <1377035907.2058763.1543085942712.ref@mail.yahoo.com> X-Mailer: WebService/1.1.12729 YMailNorrin Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36 Content-Length: 3901 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181124_105954_797515_55BB498B X-CRM114-Status: UNSURE ( 6.77 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [66.163.190.146 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (cote2004-github[at]yahoo.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain On Sat, 24 Nov 2018, Hauke Mehrtens wrote: > On 11/9/18 6:06 PM, Eneas U de Queiroz wrote: >> This is actually a build dependency for /dev/crypto support in openssl. >> Since it is a kernel module, it belongs here anyway. >> >> Acked-by: Ansuel Smith <ansuelsmth@gmail.com> >> Signed-off-by: Eneas U de Queiroz <cote2004-github@yahoo.com> >> >> diff --git a/package/kernel/cryptodev-linux/Makefile b/package/kernel/cr= yptodev-linux/Makefile >> new file mode 100644 >> index 0000000000..8e9c7ed8b0 >> --- /dev/null >> +++ b/package/kernel/cryptodev-linux/Makefile >> @@ -0,0 +1,74 @@ >> +# >> +# Copyright (C) 2014 OpenWrt.org >> +# >> +# This is free software, licensed under the GNU General Public License = v2. >> +# See /LICENSE for more information. >> +# >> +# $Id$ >> + >> +include $(TOPDIR)/rules.mk >> +include $(INCLUDE_DIR)/kernel.mk >> + >> +PKG_NAME:=3Dcryptodev-linux >> +PKG_VERSION:=3D1.9.git-2018-11-02 >> +PKG_RELEASE:=3D1 >> + >> +PKG_SOURCE_URL:=3Dhttps://github.com/cryptodev-linux/cryptodev-linux >> +PKG_SOURCE_PROTO:=3Dgit >> +PKG_SOURCE_VERSION:=3Df1a693000d116718379f8b53ed7bc6b9c0f7de27 >> +PKG_MIRROR_HASH:=3D340d314e2a88bf2449ccee906b141e085d376f6e2a94a64e3625= 4e8376323169 >> +PKG_LICENSE:=3DGPL-2.0 >> +PKG_LICENSE_FILES:=3DCOPYING >> + >> +PKG_MAINTAINER:=3DAnsuel Smith <ansuelsmth@gmail.com> >> + >> +PKG_BUILD_DIR:=3D$(KERNEL_BUILD_DIR)/$(PKG_NAME)-$(PKG_VERSION) >> + >> +include $(INCLUDE_DIR)/package.mk >> + >> +CRYPTODEV_AUTOLOAD:=3D \ >> +=C2=A0=C2=A0=C2=A0 cryptodev > > Please inline this, this extra variable is unneeded. > >> + >> +define KernelPackage/cryptodev >> +=C2=A0 SUBMENU:=3DCryptographic API modules >> +=C2=A0 DEFAULT:=3Dm if ALL >> +=C2=A0 TITLE:=3DDriver for cryptographic acceleration >> +=C2=A0 URL:=3Dhttp://cryptodev-linux.org/ >> +=C2=A0 MAINTAINER:=3DNikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail= .com> > > Why are there two different maintainers in this file? > >> +=C2=A0 VERSION:=3D$(LINUX_VERSION)+$(PKG_VERSION)-$(BOARD)-$(PKG_RELEAS= E) >> +=C2=A0 DEPENDS:=3D+kmod-crypto-authenc +kmod-crypto-hash >> +=C2=A0 FILES:=3D \ >> +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 $(PKG_BUILD_DIR)/cryptodev.$(LINU= X_KMOD_SUFFIX) >> +=C2=A0 AUTOLOAD:=3D$(call AutoLoad,50,$(CRYPTODEV_AUTOLOAD)) >> +=C2=A0 MODPARAMS.cryptodev:=3D cryptodev_verbosity=3D-1 >> +endef >> + >> +define KernelPackage/cryptodev/description >> +=C2=A0 This is a driver for that allows to use the Linux kernel support= ed >> +=C2=A0 hardware ciphers by user-space applications. >> +endef >> + >> +CRYPTODEV_MAKEOPTS=3D -C $(PKG_BUILD_DIR) \ >> +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 PATH=3D"$(TARGET_PATH)" \ >> +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 ARCH=3D"$(LINUX_KARCH)" \ >> +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 CROSS_COMPILE=3D"$(TARGET_CROSS)"= \ >> +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 TOOLPREFIX=3D"$(KERNEL_CROSS)" \ >> +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 TOOLPATH=3D"$(KERNEL_CROSS)" \ >> +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 KERNEL_DIR=3D"$(LINUX_DIR)" \ >> +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 LDOPTS=3D" " \ >> +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 DOMULTI=3D1 > > Most of these options are already defined in KERNEL_MAKE_FLAGS, please > use that as a base. > >> + >> +define Build/Compile/cryptodev >> +=C2=A0=C2=A0=C2=A0 $(MAKE) $(CRYPTODEV_MAKEOPTS) >> +endef > > Why is Build/Compile/cryptodev needed? > >> + >> +define Build/Compile >> +=C2=A0=C2=A0=C2=A0 $(call Build/Compile/cryptodev) >> +endef >> + >> +define Build/InstallDev >> +=C2=A0=C2=A0=C2=A0 $(INSTALL_DIR) $(STAGING_DIR)/usr/include/crypto >> +=C2=A0=C2=A0=C2=A0 $(CP) $(PKG_BUILD_DIR)/crypto/cryptodev.h $(STAGING_= DIR)/usr/include/crypto/ >> +endef >> + >> +$(eval $(call KernelPackage,cryptodev)) >> > > > I had shipped the Makefile as it was. I have streamlined it, but still I ne= ed to sort out the maintainers. Then I'll resend. Thanks for the review. Eneas ]