[From nobody Thu Jun 25 05:54:50 2020 Received: from mail-oi0-x242.google.com ([2607:f8b0:4003:c06::242]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fsYlh-0004zz-JR for openwrt-devel@lists.openwrt.org; Wed, 22 Aug 2018 19:26:14 +0000 Received: by mail-oi0-x242.google.com with SMTP id k12-v6so5107100oiw.8 for <openwrt-devel@lists.openwrt.org>; Wed, 22 Aug 2018 12:26:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vxugqRvC2kNsDO62rfdQq88opmQNpcmqGlB2yCCbF7A=; b=bWra51nWP/u6GZGGMe2929bPo4AKJVvJfVfCAn8ZIn60LfFriWAPcrEuWEF9FEJylG rOPEg7zNF0Bx9XMY9NHZQBfBIipLj+++aObJRAULacJYbaszZWns3Oc07gdwCfbcXP/F 465Ihd9V5DOx4jhRa7ARUJ+yDiPJ+Oga0MXIypJgXpLdqJQuS+ZAoM+Qrwi2GcV/wCMR yU/VyzT1KQcfRHPphP9+P/cbWbK9bqYlJQYGPRI2JMZK9e559iSA7M5bAmwaqUHxr3a1 S8oAcSFmOSq19GgVcEK1Ps+eEWaDWeHEPV94NzGUs6vVdc9zGj4D83+0aKG+LBCcZmes vJGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vxugqRvC2kNsDO62rfdQq88opmQNpcmqGlB2yCCbF7A=; b=E1Le+UrYC7nevzhiarZCe2yWVcJicvMqGKdW7VlW7mYfL5dPmP4eFkn0ys4ZLONA5u cJsgm2t5PsgPAlruHAzLHn8KYG7AFxUfqLcipjWUIWWBoQZxm2q+9QOo1vAAwCaW0x4t +UFM4UUUa5f5JK7aQC196li4ixwWp3G3sLb9nZpfEBRrCrcYw4SnCCKlt4v4R6gHvR3l tKnSyibORqKUWnCdBbuGoAgpFQNCUvXnLTuou66AFKZIiodUbrxBqxDxCmFTUkyTMoqP VqtCtcNyZc7jUHmDr4Jee/Arn747lNYi063HEtt2uGVrdJkBFSbOUexrOaWnotnTXOl3 k5vQ== X-Gm-Message-State: APzg51BVjbEVzuW5sP4mMlqRs0mI3ALn0Sk9wbJ1B4cSccF2o4SCuhcA g+R5aAKRta4e4nnJv6hnRwGgcNPRs1racYn8s7A= X-Google-Smtp-Source: ANB0VdaDIx79FqdvjOUQm9I8WltY4XDXQb8RyoECCt3Littv2JEKO/GPDdDPyS1o/LNZ02q5oRIN6vCDX/KaLN0jNfk= X-Received: by 2002:aca:f0d7:: with SMTP id o206-v6mr5036100oih.200.1534965962010; Wed, 22 Aug 2018 12:26:02 -0700 (PDT) MIME-Version: 1.0 References: <1534928794-8740-1-git-send-email-hanipouspilot@gmail.com> <CAJsYDVJxaxdwvXPkd0_=hxUiP0Qtw1C7afeW8LFB1zHZZvCWBg@mail.gmail.com> <CANoib0G-8i+6fxzgUJLJ+wOSesg7Wb-b+yWpDVqi_w817M0yUA@mail.gmail.com> In-Reply-To: <CANoib0G-8i+6fxzgUJLJ+wOSesg7Wb-b+yWpDVqi_w817M0yUA@mail.gmail.com> From: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Date: Wed, 22 Aug 2018 21:25:50 +0200 Message-ID: <CAFBinCCEF1F6Ezqh-mQLEOQKLzEgHQ8A0RRpbP=katuGVbhEdw@mail.gmail.com> Subject: Re: [OpenWrt-Devel] [PATCH] ath79: ar7100: remove IRQ code from PCI driver To: hanipouspilot@gmail.com Cc: gch981213@gmail.com, openwrt-devel@lists.openwrt.org, john@phrozen.org Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180822_122613_643295_65A94724 X-CRM114-Status: GOOD ( 13.41 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4003:c06:0:0:0:242 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (martin.blumenstingl[at]googlemail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature On Wed, Aug 22, 2018 at 6:58 PM Dmitry Tunin <hanipouspilot@gmail.com> wrote: > > Looking into irq-ath79-misc.c I found a few things to cleanup. > > 1. It appears that two chips are declared: "qca,ar7100-misc-intc" and > "qca,ar7240-misc-intc". > The only difference is mask-ack proc. The registers seem to work the > same way and practically we are using "qca,ar7240-misc-intc" on ar7100 > according to dtsi. > I found that the other chip was declared only when looking into the code. > > At the same time the code I removed from the PCI driver used the > ar7100 type of mask-ack, that worked also OK. > > I see no reason of having two different ways of mask-ack for similar > hardware. We need to chose one that looks better and drop the other. I suggest discussing any irq-ath79-misc changes with the upstream developers Alban Bedel did *a lot* of work to make the ath79 code devicetree compatible. it would be a shame not to "use" his knowledge by including him in the discussion upstream > 2. Instead of declaring two different chips this way, since we are > reusing this driver for PCI, I suggest to declare also > "qca,ath79-pci-intc" that will > have a different chip name = "PCI", so that "MISC and "PCI" will be > seen separately in /proc/interrupts. some existing irqchip drivers: - set the name dynamically, see drivers/irqchip/irq-ts4800.c for example - have a different number of interrupts per "compatible", see drivers/irqchip/irq-meson-gpio.c for example you may need the latter for your other patch which tries to reduce ATH79_MISC_IRQ_COUNT anyways > 3. I suggest removing legacy __init ath79_misc_irq_init() and leaving > only the OF stuff. I suggest coordinating this with the upstream developers as well as that function is part of the upstream code > Any comments? slightly off-topic: please try not to top-post as it can be confusing Regards Martin ]