[From nobody Thu Jun 25 05:54:49 2020 Received: from sonic305-20.consmr.mail.ne1.yahoo.com ([66.163.185.146]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fkpZd-0004Tv-8R for openwrt-devel@lists.openwrt.org; Wed, 01 Aug 2018 11:45:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1533123936; bh=C+jCrDoyCRGwpjVOezpqOITbC3CrpGl+BcE1Kx67Aok=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject; b=Pd7M1tm3WSCrVuFW7FoaxN/r2zsVzyc5UwV+c0J1fLWh2LzL9S/FZM796XSgb9patqCnPLMhqjLqL15d6DXX5ltIJ2aHQJQ4FDV7K8RSpNvYcZ1q3AeGbHgJ6kijh113rbuMj2MDLuP7fhqjSKH5HqVqXjESqI9LsZVA1/c2ZpntBhxMn8xoV01UvzPtFslC3dXVKM63YJTMEPEM/7q30crQWjBr66tUMFWLD4LkvZ4RJoHg2XNpDRFtC/3t8T6yygw9l4lr2RxlGfsu7UfBDEr81D6DP2viXPT61aI1I64pMREQmN9dgekg6c1A18g+Mb3xUrMwkpmvGG274cd0lA== X-YMail-OSG: EDL.j7QVM1lv1hRawSqZbG6NObb8wSTMiDDPiv6nJ1aAqWSS6FIrZgBzEyxQ7kj 2hL1hC5B22cLiPfaz9_m4vz.SOpoda_hZLodQzw7zj3iX7Kq7dFlj_qTTu23MR9ZYjYYTy_1UbHk Z6pfNNNqolUD7JCE.reI1q52jd.OfOGE7G5TpuLdXKmwPbNZgJm3S1QfyPs8kjMKPBL8M21_msAr 1PU9.HL2TAkgh.36M_LC7pZwuTbTrVjiWtfSmqxswoLLb8fZobmiRORsm86ZFydVnJpZ65xoLZmm 6hMcgGDo6H2lMrrrBQc4Ts740c1PBC1QzvWtPS9PkxIj76sWan2VO5kLRmF1gqa.AJGNkdLOlWao SvnhTdgpsgqCi7PWk1sRuOg8cjOPuz_.J4Exbkc3se_pEfWFMTgg1xMtcNBxeM_tl_1qYNmYtag9 X78vwUug4uJd1C0wthGR8QEO0f3MsCUx5YNET7CpOnVMLTw3znFflfQtCFUio3VccY2GbnW.EcQv hl5DU6b9LbBk1AEgVXLI3ZNxneItz6ZwR6w4Rvzcfb4fMdiHpIBphOSsZDUtklWY4JUkAFGM3RIi Mf_.XqBDbuFXfnyqvcGxC5MmjxWMrjF_zpE3sexz3SKI4E9HkJBCbvQH2Gg5mE321p38E51erqe2 3xZwCdmR9f_gWhvax06t5wpQWfXBW7X6v3rJhZMYPSobnAeHwWfAkoA3sRGIBqrKKK59MKM5xA61 Ongkg5_YAVDL4KM5BcuhxUSEIelzAnVhEDckY65NusczSnJfQLVw5i4_PGoFmD4ELzEN13n0q.Xs PCCe5NU__0GcxzmZziiF5sAvkTZ2hVCq3HvQPkzYRndfBzWrQ0hWg_REnJPItD4kLJOKJ.kj6Fxp 5yDaxpwtvXPdkyXyCIvj0Sm8Xoimsq2Dp9b7LkccAGdF.GoyQCaYNB.60cWIfeP_m56CcFHUsLRJ 3YViEA49HHGikBp1_wpDVTWC_1jf5IiM- Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ne1.yahoo.com with HTTP; Wed, 1 Aug 2018 11:45:36 +0000 Date: Wed, 1 Aug 2018 11:45:35 +0000 (UTC) From: Eneas Ulir de Queiroz <cote2004-github@yahoo.com> To: John Crispin <john@phrozen.org>, "openwrt-devel@lists.openwrt.org" <openwrt-devel@lists.openwrt.org> Message-ID: <509048554.346223.1533123935274@mail.yahoo.com> In-Reply-To: <d18b5638-2b3b-1829-b6d1-6409679caba2@phrozen.org> References: <mailman.13975.1533034632.25356.openwrt-devel@lists.openwrt.org> <d18b5638-2b3b-1829-b6d1-6409679caba2@phrozen.org> Subject: Re: [OpenWrt-Devel] [PATCH] libpcap: patch to add limits.h to pcap-usb-linux.c MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_346222_187075607.1533123935272" X-Mailer: WebService/1.1.12206 YMailNorrin Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0 Content-Length: 2938 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180801_044549_341443_6ECAC5D0 X-CRM114-Status: UNSURE ( 3.98 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [66.163.185.146 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (cote2004-github[at]yahoo.com) 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-Mailman-Approved-At: Mon, 20 Aug 2018 03:42:23 -0700 ------=_Part_346222_187075607.1533123935272 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I will repost the patch with a cover letter explaining all this, and with = a better commit message.=C2=A0 I made the wrong assumption that the commit = id on top of the patch would be enough to identify its origin.=C2=A0 I'm st= ill learning, and shall do it right next time. The reason why the buildservers don't fail is that they're probably not set= ting CONFIG_PCAP_HAS_USB (default is OFF), so the patched file does not get= compiled.=C2=A0 I will add that info in the cover letter. Cheers, Eneas Em quarta-feira, 1 de agosto de 2018 06:01:58 BRT, John Crispin <john@p= hrozen.org> escreveu: =20 =20 none of the buildservers seem to break without this patch. please repost= =20 explaining how the build breaks without this patch. also reference the=20 place where you copied the patch from =C2=A0=C2=A0=C2=A0 John =20 ------=_Part_346222_187075607.1533123935272 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit <html><head></head><body><div style="font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:13px;"><div style="font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:13px;"><div style="font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:13px;"><div></div> <div>I will repost the patch with a cover letter explaining all this, and with a better commit message.  I made the wrong assumption that the commit id on top of the patch would be enough to identify its origin.  I'm still learning, and shall do it right next time.<br></div><div><br></div><div>The reason why the buildservers don't fail is that they're probably not setting<span><span> CONFIG_PCAP_HAS_USB (default is OFF), so the patched file does not get compiled.  I will add that info in the cover letter.<br></span></span></div><div><br><span><span></span></span></div><div>Cheers,</div><div><br></div><div>Eneas</div><div><br></div> </div></div><div id="ydp2bd1deb5yahoo_quoted_3947069750" class="ydp2bd1deb5yahoo_quoted"> <div style="font-family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:13px;color:#26282a;"> <div> Em quarta-feira, 1 de agosto de 2018 06:01:58 BRT, John Crispin <john@phrozen.org> escreveu: </div> <div><br></div> <div><br></div> <div><div dir="ltr">none of the buildservers seem to break without this patch. please repost <br></div><div dir="ltr">explaining how the build breaks without this patch. also reference the <br></div><div dir="ltr">place where you copied the patch from<br></div><div dir="ltr">     John<br></div></div> </div> </div></div></body></html> ------=_Part_346222_187075607.1533123935272-- ]