[From nobody Thu Jun 25 05:54:49 2020
Received: from mail-oi0-x244.google.com ([2607:f8b0:4003:c06::244])
 by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux))
 id 1fqkh9-0004C9-1M
 for openwrt-devel@lists.openwrt.org; Fri, 17 Aug 2018 19:46:04 +0000
Received: by mail-oi0-x244.google.com with SMTP id d189-v6so15937862oib.6
 for <openwrt-devel@lists.openwrt.org>; Fri, 17 Aug 2018 12:45:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=googlemail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=TPuWaUpaKq6QvMhg5O9ofGQcanRteyx6v9knm76MhL0=;
 b=YTdZbDvXae+4ndn523UNX3/xRQP0tVrSXBId+6lxPWUK+J3z48I9jxxnK2rGLtdaYd
 u7atXkbJL0QyIdnSz8/WXg0qfrTNu89K9A4ZmuU3Hxl1lXPP8guptoD9AgBV1QkymoJp
 IarYhPsJ0AnLZL10i+GC5NASCEWSPSfFJ87Cz8Jt+fu5PXqONpZaPXJmRuElYuVrPsy7
 vAGswfCOnMU1cvsT7ETgE1053qLAGm5WTZvdQbjMKkWkxyyKQduRJkKgLhA+5RgnGiOa
 xfMoyJCX2BkX2Eq5moKTvd84xujMO/aXvRGshvjNRszZaF4xkrBCiF5duIHDwdvQTugb
 KTDA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=TPuWaUpaKq6QvMhg5O9ofGQcanRteyx6v9knm76MhL0=;
 b=TDxtT5qvISLIsIwTYuqEy56anTWVhidB1n2Kc5ERocAyUs+IQh54zr3w9YtJ5n/OMg
 fOL69hr7fOLETkgbIEUCtCS15xXHu750kSmS4TFJpdC5WNhNXAx1v6h/f6P0fVhjPhj6
 GfHH6Jju20VmUSlJcDG6QGrI/aAgCdETpEyVOihtvRRcKkLWuQXmzSwwO2CrFzcNIbti
 v3FzzGrScw8LHco39DxKvhOl3HTmEXZc828I6mwfULlhSmNOCpiRxlFye7SuD4z6QheO
 w3Tqk/KUk4bqFqzlPahQhK4lEiuaghzuNR5UfzcZu3tmELZqPOxY8c2EqBeT2MZcDLnV
 VW2Q==
X-Gm-Message-State: AOUpUlG81keZQOPofvjcQOmxAqQzWA7tguaHrkS5nm1GINkwPGqlMwvN
 rWkdZC2g010W3UETMrIFgQ7K6ziCEOjcspFOl+E=
X-Google-Smtp-Source: AA+uWPxstilfCtCcTHOZUSpmBdzspCcHhVwgQox5ngdLhQmLqNygMc0NkJlMdRxJbZfkjCnrIPC3NY3JSfZIVUjjL/w=
X-Received: by 2002:aca:4782:: with SMTP id
 u124-v6mr4125871oia.45.1534535151951; 
 Fri, 17 Aug 2018 12:45:51 -0700 (PDT)
MIME-Version: 1.0
References: <20180816030522.9634-1-gch981213@gmail.com>
In-Reply-To: <20180816030522.9634-1-gch981213@gmail.com>
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date: Fri, 17 Aug 2018 21:45:40 +0200
Message-ID: <CAFBinCA2RzUYJfG9qzPfb2KfAgc-hDFihTko2x3J8Hnqti0f-Q@mail.gmail.com>
Subject: Re: [OpenWrt-Devel] [PATCH] [RFC] ath79: ag71xx: apply interface mode
 to MII0/1_CNTL on ar71xx/ar913x
To: gch981213@gmail.com
Cc: openwrt-devel@lists.openwrt.org
Content-Type: text/plain; charset="UTF-8"
X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 
X-CRM114-CacheID: sfid-20180817_124603_085239_8412B665 
X-CRM114-Status: GOOD (  15.90  )
X-Spam-Score: -0.1 (/)
X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary:
 Content analysis details:   (-0.1 points)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at http://www.dnswl.org/, no
 trust [2607:f8b0:4003:c06:0:0:0:244 listed in] [list.dnswl.org]
 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
 (martin.blumenstingl[at]googlemail.com)
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's
 domain
 0.1 DKIM_SIGNED            Message has a DKIM or DK signature,
 not necessarily valid
 -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature

On Thu, Aug 16, 2018 at 5:06 AM Chuanhong Guo <gch981213@gmail.com> wrote:
>
> Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
> ---
> RFC:
> Previous discussion about this patch can be found on GitHub PR#1271.
> This patch applies correct interface mode to MII0/1_CNTL register at 0x18070000/
> 0x18070004. But there is a small difference in values for these two registers:
> | GMAC0    | GMAC1   |
> |----------|---------|
> | 0 GMII   | 0 RGMII |
> | 1 MII    | 1 RMII  |
> | 2 RGMII  |         |
> | 3 RMII   |         |
> I currently have 4 ways of dealing with this:
> 1. Use a bool value in dts indicating whether this is the second GMAC. This one
>    is pretty dirty and I dropped it.
> 2. Split MII_CNTL into separated dt node and use different compatible for them
>    like we did for ETH_CFG (gmac node) on ar933x and later SoCs. After some discussion
>    on GitHub it turns out to be unreasonable to treat those in separated nodes.
> 3. Use ar7100-eth0/ar7100-eth1 as compatible string. This is what I've done in
>    this patch I sent here. But I think my way of using compatible string here is ugly :(
>    A possible cleaner implementation would be introducing ar7100-eth0/ar7100-eth1/
>    ar9130-eth0/ar9130-eth1 to replace ar7100-eth/ar9130-eth. But I doubt whether
>    introducing 4 new compatible strings for such a slight difference is worthy.
I think the naming "ar7100-eth0" / "ar7100-eth1" was my idea
maybe it's not super intuitive since it reads as if the target
Ethernet device will be called "eth0" or "eth1" - this is not what I
meant with this naming. I wonder if "ar7100-mii0-eth" /
"ar7100-mii1-eth" is any better. other ideas are highly welcome

"There are only two hard things in Computer Science: cache
invalidation and naming things."
-- Phil Karlton


Regards
Martin

]