[From nobody Thu Jun 25 05:54:42 2020 Received: from mail-ve1eur01on0066.outbound.protection.outlook.com ([104.47.1.66] helo=EUR01-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fVuwX-0005kk-2C for openwrt-devel@lists.openwrt.org; Thu, 21 Jun 2018 08:27:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darbyshire-bryant.me.uk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hgIy8DcbcU2xNbRB+SKDr2m/FpBwbP6S4gUczCkspdg=; b=EyrXvbWG8JvrXUC6UuYpC9XFjEw97JLLroUWurBf1VcAdjxuhuQGgOuv2vWV5mNtlrz64aCf3fAkO7gUHufW+Yofm/jqDBMTjVYNCytqaN3AW3HacLe5UO0YzhhA6YMuPQRfcYsFc3PjuxMfw0kuXZFYoVpJzLHMUy/JqUuTYFE= Received: from DB6PR07MB4246.eurprd07.prod.outlook.com (10.168.23.147) by DB6PR07MB3448.eurprd07.prod.outlook.com (10.175.234.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.16; Thu, 21 Jun 2018 08:27:34 +0000 Received: from DB6PR07MB4246.eurprd07.prod.outlook.com ([fe80::5dc:e909:d343:a895]) by DB6PR07MB4246.eurprd07.prod.outlook.com ([fe80::5dc:e909:d343:a895%4]) with mapi id 15.20.0884.010; Thu, 21 Jun 2018 08:27:34 +0000 From: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> To: Jaap Buurman <jaapbuurman@gmail.com> CC: OpenWrt Development List <openwrt-devel@lists.openwrt.org>, Mathias Kresin <dev@kresin.me> Subject: Re: [OpenWrt-Devel] 18.06: Cherry pick mtu fix Thread-Topic: [OpenWrt-Devel] 18.06: Cherry pick mtu fix Thread-Index: AQHUCS97bnpXrbw4bUGilE83RCi36KRqYQiA Date: Thu, 21 Jun 2018 08:27:34 +0000 Message-ID: <05A31E27-EB89-4F1F-85EC-065D52B7EEE8@darbyshire-bryant.me.uk> References: <CAN-r--kXjAxA+dRwjpFcVikUGcwiuOZDaV4urPcEniya9eTk4Q@mail.gmail.com> In-Reply-To: <CAN-r--kXjAxA+dRwjpFcVikUGcwiuOZDaV4urPcEniya9eTk4Q@mail.gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=kevin@darbyshire-bryant.me.uk; x-originating-ip: [2a02:c7f:1231:2000::dc83] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB6PR07MB3448; 7:HtrMuknM47ujwPIYUDiTL/QrXrgrHI3fLsqGcEW4NhQo0vVShdmiodlb5slhI6WSvkZdXin/63QercDwsMfQATz8b1AByuxg/VXyU6SLYpjdcjpb+Zh8t+7K2i/ZItqP1kVpINsK21amJTkvsTRSKmEZ7HcRw1i226fIeCfJbIfOO3U6MHxEK4vmhLmezVbUIOGDurlX287+cVPsU6JbHSzzXyhKegN0MplwES90QNEG2yqvcktILWjYmC2Bmy/S x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 16638c4d-de68-4946-9a02-08d5d750d6c6 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(7021125)(4534165)(7022125)(4603075)(4627221)(201702281549075)(7048125)(7024125)(7027125)(7028125)(7023125)(5600026)(711020)(2017052603328)(7153060)(49563074)(7193020); SRVR:DB6PR07MB3448; x-ms-traffictypediagnostic: DB6PR07MB3448: x-microsoft-antispam-prvs: <DB6PR07MB34489F9A7261359EB54406D6A5760@DB6PR07MB3448.eurprd07.prod.outlook.com> x-exchange-antispam-report-test: UriScan:(85827821059158); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(102415395)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231254)(944501410)(52105095)(3002001)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123560045)(2016111802025)(20161123564045)(6072148)(6043046)(201708071742011)(7699016); SRVR:DB6PR07MB3448; BCL:0; PCL:0; RULEID:; SRVR:DB6PR07MB3448; x-forefront-prvs: 07106EF9B9 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(346002)(39830400003)(366004)(39380400002)(199004)(189003)(7736002)(83716003)(1411001)(2906002)(476003)(11346002)(3280700002)(6916009)(86362001)(305945005)(6436002)(74482002)(97736004)(486006)(14454004)(575784001)(3660700001)(6116002)(46003)(186003)(316002)(5250100002)(2616005)(446003)(105586002)(6512007)(76176011)(54906003)(25786009)(33656002)(99936001)(99286004)(4326008)(6506007)(966005)(68736007)(53936002)(2900100001)(36756003)(53546011)(106356001)(5660300001)(8936002)(81156014)(81166006)(413944005)(8676002)(229853002)(6246003)(39060400002)(6306002)(478600001)(82746002)(102836004)(6486002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR07MB3448; H:DB6PR07MB4246.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: darbyshire-bryant.me.uk does not designate permitted sender hosts) x-microsoft-antispam-message-info: Jb8pixGwYVGuFiq8Czqevek7mXNuLJJWJ0LRHHq7qa+4siQJEhiaS2nJMyBxXES3Ut0FZbXV0hH07aZyH/f+O8L+CjeDr7/F3pnud6jT7ZmExeJgpAvYJadpClDpEXH69DJtZfWizkSptPqDZmHkWbElaaWwGscN2/k3OD5MLWAu25QXiRYKsJeG8aed9MiDmb+HZLF+jKJ4LLDSXEtPtQT9cc+tJrPqu0l4nIEDLMYbf/DeTK0LAEwIh3YpdhiYGqxtmpzGjimn5FO5bsubNz68hBZYGv7CuYz8W2B+hg6bLmIQLYp6R70opGQYyf11 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: multipart/signed; boundary="Apple-Mail=_0D2030C4-3963-4640-903F-8ED602DF17E8"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 X-OriginatorOrg: darbyshire-bryant.me.uk X-MS-Exchange-CrossTenant-Network-Message-Id: 16638c4d-de68-4946-9a02-08d5d750d6c6 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2018 08:27:34.1136 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 9151708b-c553-406f-8e56-694f435154a4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR07MB3448 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180621_012749_313965_70FEA76D X-CRM114-Status: GOOD ( 16.06 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [104.47.1.66 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain --Apple-Mail=_0D2030C4-3963-4640-903F-8ED602DF17E8 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 21 Jun 2018, at 08:13, Jaap Buurman <jaapbuurman@gmail.com> wrote: >=20 > Dear all, >=20 > The move to kernel 4.14 broke mtu settings larger than 1500 by > default, unless the correct mtu was explicitly specified. The > following commit fixes this for the mt7621 target: > = https://git.openwrt.org/?p=3Dopenwrt/openwrt.git;a=3Dcommit;h=3D5da2c68d00= 1ee44b15a58639ed03a0ebb6f68020 >=20 > 1) Would it be possible for someone to cherry-pick this to the 18.06 > branch, so that it can receive widespread testing in the upcoming > 18.06 RC1 release? Personally I=E2=80=99d also pick the preceding mtk driver commit = "ec502cd3fe ramips: rename ethernet driver folder to the same one that = upstream uses=E2=80=9D for clarity & easier cherry-picks going forward = for 18.06. And I=E2=80=99d be very strongly tempted to have 9a4253b81f = ramips: improve ethernet driver performance with GRO/TSO as well=E2=80=A6= . which gets 18.06 into the same state as master for mtk eth drivers. > 2) =46rom the commit's message I get the impression this isn't an = issue > with just mt7621, but with all targets that are able to handle a mtu > > 1500. Is my impression correct in this regard, and is this something > that should be fixed before a 18.06 release? Changing mtu settings > > 1500 does sound like basic functionality for routers nowadays. It is dependent upon the driver setting a suitable max_mtu in the netdev = structure *IF* it supports values greater than 1500. + if (IS_ENABLED(CONFIG_SOC_MT7621)) + netdev->max_mtu =3D 2048; The version of driver included with kernel 4.14 at present is too dumb = to understand >1500 mtu, which is why openwrt replaces it with a version = that (now) does. That=E2=80=99s my opinion anyway :-) Kevin --Apple-Mail=_0D2030C4-3963-4640-903F-8ED602DF17E8 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEASyssijGxT6XdZEjs6I4m53iM0oFAlsrYXUACgkQs6I4m53i M0paNRAAhzQJYVpS+KAwOHRfNGWbJfsKgh0Pl1kiUIqPvibDviENbUY0DaK0ZHm2 s0jE2Ew82tjraucQsNwgv8vlP0m3T099xRkdBWtgLO/Zcna54HmT/S/Rr2lbk+RK FEs7zcA6kpjLaJSIVLdjNjcx0cUBr7u4jEJMdeFDfxkOGQw+P2mNkjE5R3bIpS52 5ICOjF4d0R0JA3Q2lFSgjkNzVzK8ECAlNDLWGAug2MhqstznMVszE4QuYzw+baip sNBUgmS0DMd+Pj/W+oYcA1wZ/73Z/KxbPCgTiIsE9FqVXuWGqqxGySFNk+91cGp2 VtSrynvP0UVD4n6vqlpZR7fQvlny7uJT6nFGBmCtccqGMrowtYXQzv73Kjkk+i99 v58KT9pSNPkaSHry7TXXXyGnb4om2d0Bz0j7onnWbQVTfvYZkXZjqFuFhk5dRy84 ySconw9XKqYQI/TZHU30ev3qN23BWmZazTnKnTju4w5tyFBZGt2ukhf4M+cUaFMm pAvJrk4armKeslwIph2eeHH7KJ7vL13GrVJnaD4FQWfLDZm6JqveUakVFklq2wL5 wfA+jCs4hCJd9RKFzkz/kvJQeh+JlRXjOIz59WTx/BMWNA+46+WG47d5L2eJJIyz k3gkKbnqifsBtmAPPw42UClyw+iQzXq8eEdAeWFWPlGu13nPipM= =Ygkb -----END PGP SIGNATURE----- --Apple-Mail=_0D2030C4-3963-4640-903F-8ED602DF17E8-- ]