<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Zoltan HERPAI kirjoitti 24.10.2017 klo
14:46:<br>
</div>
<blockquote type="cite"
cite="mid:%3C1508845578-30041-1-git-send-email-wigyori@uid0.hu%3E">
<pre wrap="">Given that we've decided to sail under the same flag for
the benefit of the whole community, and acknowledge the
achievements of the LEDE project, let's start the final
steps of the merge.
The git and other sources are untouched until the infra merge.
...</pre>
</blockquote>
<blockquote type="cite"
cite="mid:%3C1508845578-30041-1-git-send-email-wigyori@uid0.hu%3E">
<pre wrap="">--- a/package/base-files/files/etc/banner
+++ b/package/base-files/files/etc/banner
@@ -1,10 +1,13 @@
- _________
- / /\ _ ___ ___ ___
- / LE / \ | | | __| \| __|
- / DE / \ | |__| _|| |) | _|
- /________/ LE \ |____|___|___/|___| lede-project.org
- \ \ DE /
- \ LE \ / -----------------------------------------------------------
- \ DE \ / %N (%V, %C)
- \________\/ -----------------------------------------------------------
-
+ _______ ________ __
+ | |.-----.-----.-----.| | | |.----.| |_
+ | - || _ | -__| || | | || _|| _|
+ |_______|| __|_____|__|__||________||__| |____|
+ |__| W I R E L E S S F R E E D O M
+ -----------------------------------------------------
+ DESIGNATED DRIVER (%C, %R)
+ -----------------------------------------------------
+ * 2 oz. Orange Juice Combine all juices in a
+ * 2 oz. Pineapple Juice tall glass filled with
+ * 2 oz. Grapefruit Juice ice, stir well.
+ * 2 oz. Cranberry Juice
+ -----------------------------------------------------
</pre>
</blockquote>
<p><br>
</p>
<p>Please do not re-introduce hard-coded version branding into
various files.</p>
All version info was centralised to include/version.mk by this
commit:
<p><a class="moz-txt-link-freetext" href="https://github.com/lede-project/source/commit/3193053df7d27bde82fbcc310e4404cc43f39313#diff-d08225593c57fc07ce549597f7fd4c68">https://github.com/lede-project/source/commit/3193053df7d27bde82fbcc310e4404cc43f39313#diff-d08225593c57fc07ce549597f7fd4c68</a></p>
<p>and further refined with</p>
<p><a class="moz-txt-link-freetext" href="https://github.com/lede-project/source/commit/5f3c96c28503b8a0aad1514ef144b15e670d338b#diff-d08225593c57fc07ce549597f7fd4c68">https://github.com/lede-project/source/commit/5f3c96c28503b8a0aad1514ef144b15e670d338b#diff-d08225593c57fc07ce549597f7fd4c68</a><br>
</p>
<p>Having hard-coded versions scattered around in various files
proved to be cumbersome at several Openwrt releases, as some of
the hard-coded names were forgotten to be changed in connection to
several releases.</p>
In LEDE sources the variables like "%N (%V, %C)" take nicely care of
the version branding also in /etc/banner, also including the version
name. <br>
<p>Using hard-coded name like "DESIGNATED DRIVER (%C, %R)" would be
a clear step backwards.</p>
<p><br>
</p>
<p><br>
</p>
<p>Ps.</p>
<p>And are the drinks really back on the menu?</p>
<p><br>
</p>
</body>
</html>