<div dir="ltr">Sorry,<div><br></div><div>Re-send After correcting the patch.<br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">2015-08-18 3:13 GMT+09:00 Piotr Dymacz <span dir="ltr"><<a href="mailto:pepe2k@gmail.com" target="_blank">pepe2k@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br>
<br>
Please, see my comments inline.<br>
<div><div class="h5"><br>
2015-08-17 19:20 GMT+02:00 YuheiOKAWA <<a href="mailto:tochiro.srchack@gmail.com">tochiro.srchack@gmail.com</a>>:<br>
>  This patch add support for Planex DB-WRT01. DANBOARD route on<br>
>  the MT7620A SoC with two Ethernet port and a 802.11n 2.4 GHz radio.<br>
>  DANBOARD is Cartoon character.<br>
><br>
> Signed-off-by: YuheiOKAWA <<a href="mailto:tochiro.srchack@gmail.com">tochiro.srchack@gmail.com</a>><br>
> ---<br>
>  target/linux/ramips/base-files/etc/board.d/01_leds |  3 +<br>
>  .../linux/ramips/base-files/etc/board.d/02_network |  1 +<br>
>  target/linux/ramips/base-files/etc/diag.sh         |  1 +<br>
>  target/linux/ramips/base-files/lib/ramips.sh       |  3 +<br>
>  .../ramips/base-files/lib/upgrade/platform.sh      |  1 +<br>
>  target/linux/ramips/dts/DB-WRT01.dts               | 99 ++++++++++++++++++++++<br>
>  target/linux/ramips/image/Makefile                 |  2 +<br>
>  7 files changed, 110 insertions(+)<br>
>  create mode 100644 target/linux/ramips/dts/DB-WRT01.dts<br>
><br>
> diff --git a/target/linux/ramips/base-files/etc/board.d/01_leds b/target/linux/ramips/base-files/etc/board.d/01_leds<br>
> index 71cf3ac..a9959e3 100755<br>
> --- a/target/linux/ramips/base-files/etc/board.d/01_leds<br>
> +++ b/target/linux/ramips/base-files/etc/board.d/01_leds<br>
> @@ -87,6 +87,9 @@ d105)<br>
>         ucidef_set_led_default "power" "POWER" "$board:red:power" "1"<br>
>         set_usb_led "$board:green:usb"<br>
>         ;;<br>
> +db-wrt01)<br>
> +       ucidef_set_led_default "power" "power" "$board:orange:power" "1"<br>
> +       ;;<br>
>  dcs-930l-b1)<br>
>         ucidef_set_led_default "power" "POWER" "$board:red:power" "1"<br>
>         ucidef_set_led_netdev "wifi" "WiFi" "$board:blue:wps"<br>
> diff --git a/target/linux/ramips/base-files/etc/board.d/02_network b/target/linux/ramips/base-files/etc/board.d/02_network<br>
> index 6a2f042..02cd682 100755<br>
> --- a/target/linux/ramips/base-files/etc/board.d/02_network<br>
> +++ b/target/linux/ramips/base-files/etc/board.d/02_network<br>
> @@ -61,6 +61,7 @@ ramips_setup_interfaces()<br>
>                 ;;<br>
>         3g-6200n|\<br>
>         ai-br100|\<br>
> +       db-wrt01|\<br>
>         dir-300-b7|\<br>
>         dir-320-b1|\<br>
>         dir-610-a1|\<br>
> diff --git a/target/linux/ramips/base-files/etc/diag.sh b/target/linux/ramips/base-files/etc/diag.sh<br>
> index a4911b0..f886b5d 100644<br>
> --- a/target/linux/ramips/base-files/etc/diag.sh<br>
> +++ b/target/linux/ramips/base-files/etc/diag.sh<br>
> @@ -94,6 +94,7 @@ get_status_led() {<br>
>         y1s)<br>
>                 status_led="$board:blue:power"<br>
>                 ;;<br>
> +       db-wrt01|\<br>
>         esr-9753)<br>
>                 status_led="$board:orange:power"<br>
>                 ;;<br>
> diff --git a/target/linux/ramips/base-files/lib/ramips.sh b/target/linux/ramips/base-files/lib/ramips.sh<br>
> index 5cafd45..5b6808e 100755<br>
> --- a/target/linux/ramips/base-files/lib/ramips.sh<br>
> +++ b/target/linux/ramips/base-files/lib/ramips.sh<br>
> @@ -97,6 +97,9 @@ ramips_board_detect() {<br>
>         *"DAP-1350")<br>
>                 name="dap-1350"<br>
>                 ;;<br>
> +       *"DB-WRT01")<br>
> +               name="db-wrt01"<br>
> +               ;;<br>
>         *"DCS-930")<br>
>                 name="dcs-930"<br>
>                 ;;<br>
> diff --git a/target/linux/ramips/base-files/lib/upgrade/platform.sh b/target/linux/ramips/base-files/lib/upgrade/platform.sh<br>
> index 53e7070..844ed5d 100755<br>
> --- a/target/linux/ramips/base-files/lib/upgrade/platform.sh<br>
> +++ b/target/linux/ramips/base-files/lib/upgrade/platform.sh<br>
> @@ -36,6 +36,7 @@ platform_check_image() {<br>
>         cf-wr800n|\<br>
>         d105|\<br>
>         dap-1350|\<br>
> +       db-wrt01|\<br>
>         dcs-930|\<br>
>         dcs-930l-b1|\<br>
>         dir-300-b1|\<br>
> diff --git a/target/linux/ramips/dts/DB-WRT01.dts b/target/linux/ramips/dts/DB-WRT01.dts<br>
> new file mode 100644<br>
> index 0000000..a8953e9<br>
> --- /dev/null<br>
> +++ b/target/linux/ramips/dts/DB-WRT01.dts<br>
> @@ -0,0 +1,99 @@<br>
> +/dts-v1/;<br>
> +<br>
> +/include/ "mt7620a.dtsi"<br>
> +<br>
> +/ {<br>
> +       compatible = "ralink,mt7620a-soc";<br>
> +       model = "Planex DB-WRT01";<br>
> +<br>
> +       palmbus@10000000 {<br>
> +               gpio1: gpio@638 {<br>
> +                       status = "okay";<br>
> +               };<br>
> +<br>
> +               spi@b00 {<br>
> +                       status = "okay";<br>
> +<br>
> +                       m25p80@0 {<br>
> +                               #address-cells = <1>;<br>
> +                               #size-cells = <1>;<br>
> +                               compatible = "en25q64";<br>
> +                               reg = <0 0>;<br>
> +                               linux,modalias = "m25p80", "mx25l6405d";<br>
> +                               spi-max-frequency = <10000000>;<br>
> +<br>
> +                               partition@0 {<br>
> +                                       label = "u-boot";<br>
> +                                       reg = <0x0 0x30000>;<br>
> +                                       read-only;<br>
> +                               };<br>
> +<br>
> +                               partition@30000 {<br>
> +                                       label = "u-boot-env";<br>
> +                                       reg = <0x30000 0x10000>;<br>
> +                                       read-only;<br>
> +                               };<br>
> +<br>
> +                               factory: partition@40000 {<br>
> +                                       label = "factory";<br>
> +                                       reg = <0x40000 0x10000>;<br>
> +                                       read-only;<br>
> +                               };<br>
> +<br>
> +                               partition@50000 {<br>
> +                                       label = "firmware";<br>
> +                                       reg = <0x50000 0x7b0000>;<br>
> +                               };<br>
> +                       };<br>
> +               };<br>
> +       };<br>
> +<br>
> +       pinctrl {<br>
> +               state_default: pinctrl0 {<br>
> +                       gpio {<br>
> +                               ralink,group = "i2c", "spi refclk", "rgmii1";<br>
> +                               ralink,function = "gpio";<br>
> +                       };<br>
> +               };<br>
> +       };<br>
> +<br>
> +       ethernet@10100000 {<br>
> +               pinctrl-names = "default";<br>
> +               pinctrl-0 = <&ephy_pins>;<br>
> +<br>
<br>
</div></div>Is this empty line really needed here?<br>
<span class=""><br>
> +               mtd-mac-address = <&factory 0x4>;<br>
> +               ralink,port-map = "llllw";<br>
> +       };<br>
> +<br>
> +       gsw@10110000 {<br>
> +               ralink,port4 = "ephy";<br>
> +       };<br>
> +<br>
> +       wmac@10180000 {<br>
> +               ralink,mtd-eeprom = <&factory 0>;<br>
> +       };<br>
> +<br>
> +       pcie@10140000 {<br>
> +               status = "okay";<br>
> +       };<br>
> +<br>
> +       gpio-leds {<br>
> +               compatible = "gpio-leds";<br>
<br>
</span>Empty line here, please.<br>
<span class=""><br>
> +               power {<br>
> +                       label = "db-wrt01:orange:power";<br>
> +                       gpios = <&gpio1 1 1>;<br>
> +               };<br>
> +       };<br>
> +<br>
> +       gpio-keys-polled {<br>
> +               compatible = "gpio-keys-polled";<br>
> +               #address-cells = <1>;<br>
> +               #size-cells = <0>;<br>
> +               poll-interval = <20>;<br>
<br>
</span>And here too.<br>
<div><div class="h5"><br>
> +               s1 {<br>
> +                       label = "wps";<br>
> +                       gpios = <&gpio0 2 1>;<br>
> +                       linux,code = <0x211>;<br>
> +               };<br>
> +       };<br>
> +};<br>
> diff --git a/target/linux/ramips/image/Makefile b/target/linux/ramips/image/Makefile<br>
> index 2f4d4cb..4632ad2 100644<br>
> --- a/target/linux/ramips/image/Makefile<br>
> +++ b/target/linux/ramips/image/Makefile<br>
> @@ -868,6 +868,7 @@ Image/Build/Profile/CF-WR800N=$(call BuildFirmware/Default8M/$(1),$(1),cf-wr800n<br>
>  Image/Build/Profile/DIR-810L=$(call BuildFirmware/CustomFlash/$(1),$(1),dir-810l,DIR-810L,$(dlink810l_mtd_size))<br>
>  na930_mtd_size=20971520<br>
>  Image/Build/Profile/NA930=$(call BuildFirmware/CustomFlash/$(1),$(1),na930,NA930,$(na930_mtd_size))<br>
> +Image/Build/Profile/DB-WRT01=$(call BuildFirmware/Default8M/$(1),$(1),db-wrt01,DB-WRT01)<br>
>  Image/Build/Profile/MZK-750DHP=$(call BuildFirmware/Default8M/$(1),$(1),mzk-750dhp,MZK-750DHP)<br>
>  Image/Build/Profile/OY-0001=$(call BuildFirmware/Default16M/$(1),$(1),oy-0001,OY-0001)<br>
>  Image/Build/Profile/Y1=$(call BuildFirmware/Default16M/$(1),$(1),y1,Y1)<br>
> @@ -901,6 +902,7 @@ define Image/Build/Profile/Default<br>
>         $(call Image/Build/Profile/WHR300HP2,$(1))<br>
>         $(call Image/Build/Profile/WHR600D,$(1))<br>
>         $(call Image/Build/Profile/WHR1166D,$(1))<br>
> +       $(call Image/Build/Profile/DB-WRT01,$(1))<br>
>         $(call Image/Build/Profile/MZK-750DHP,$(1))<br>
>         $(call Image/Build/Profile/NA930,$(1))<br>
>         $(call Image/Build/Profile/OY-0001,$(1))<br>
> --<br>
> 1.9.1<br>
</div></div>> _______________________________________________<br>
> openwrt-devel mailing list<br>
> <a href="mailto:openwrt-devel@lists.openwrt.org">openwrt-devel@lists.openwrt.org</a><br>
> <a href="https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel" rel="noreferrer" target="_blank">https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel</a><br>
</blockquote></div><br></div>